* [PATCH RESEND 0/4] Small updates to Snow and Peach Pit/Pi DTS
@ 2015-01-02 15:24 Javier Martinez Canillas
2015-01-02 15:24 ` [PATCH RESEND 1/4] ARM: dts: Add power and lid GPIO keys pinctrl for exynos5250-snow Javier Martinez Canillas
` (4 more replies)
0 siblings, 5 replies; 11+ messages in thread
From: Javier Martinez Canillas @ 2015-01-02 15:24 UTC (permalink / raw)
To: linux-arm-kernel
Hello Kukjin,
This series adds some DTS snippets that were missing in the mainline
Snow and Peach Pit/Pi Device Trees but are present in the downstream
ChromeOS kernel.
The series is composed of the following patches:
Javier Martinez Canillas (4):
ARM: dts: Add power and lid GPIO keys pinctrl for exynos5250-snow
ARM: dts: Add lid GPIO key device node for Peach boards
ARM: dts: Set Peach boards USB WebCam regulators to always on
ARM: dts: Configure regulators for suspend on exynos Peach boards
arch/arm/boot/dts/exynos5250-snow.dts | 16 +++++
arch/arm/boot/dts/exynos5420-peach-pit.dts | 100 +++++++++++++++++++++++++++-
arch/arm/boot/dts/exynos5800-peach-pi.dts | 101 ++++++++++++++++++++++++++++-
3 files changed, 215 insertions(+), 2 deletions(-)
Patch #1 adds some pinctrl lines for the GPIO keys in the Snow DTS.
Patch #2 adds a device node and pinctrl lines for the lid GPIO in
the Peach boards DTS.
Patch #3 sets the regulators that supply voltage to the USB WebCam
in Peach boards as always on.
Patch #4 configures the max77802 regulators on the Peach Pit and Pi
boards to be enabled or disabled during system suspend.
Best regards,
Javier
^ permalink raw reply [flat|nested] 11+ messages in thread* [PATCH RESEND 1/4] ARM: dts: Add power and lid GPIO keys pinctrl for exynos5250-snow 2015-01-02 15:24 [PATCH RESEND 0/4] Small updates to Snow and Peach Pit/Pi DTS Javier Martinez Canillas @ 2015-01-02 15:24 ` Javier Martinez Canillas 2015-01-14 15:17 ` Kukjin Kim 2015-01-02 15:24 ` [PATCH RESEND 2/4] ARM: dts: Add lid GPIO key device node for Peach boards Javier Martinez Canillas ` (3 subsequent siblings) 4 siblings, 1 reply; 11+ messages in thread From: Javier Martinez Canillas @ 2015-01-02 15:24 UTC (permalink / raw) To: linux-arm-kernel The Exynos5250 Snow Chromebook has GPIO keys for power and lid so the SoC I/O pins have to be configured in external interrupt mode. Currently, this is working without setting the pinctrl lines but is better to set it explicitly instead of relying on the previous state of the I/O pins. The DTS snippets were taken from the downstream ChromeOS tree. Signed-off-by: Javier Martinez Canillas <javier.martinez@collabora.co.uk> --- arch/arm/boot/dts/exynos5250-snow.dts | 16 ++++++++++++++++ 1 file changed, 16 insertions(+) diff --git a/arch/arm/boot/dts/exynos5250-snow.dts b/arch/arm/boot/dts/exynos5250-snow.dts index effaf2a..b9aeec4 100644 --- a/arch/arm/boot/dts/exynos5250-snow.dts +++ b/arch/arm/boot/dts/exynos5250-snow.dts @@ -33,6 +33,8 @@ gpio-keys { compatible = "gpio-keys"; + pinctrl-names = "default"; + pinctrl-0 = <&power_key_irq &lid_irq>; power { label = "Power"; @@ -540,6 +542,13 @@ }; &pinctrl_0 { + power_key_irq: power-key-irq { + samsung,pins = "gpx1-3"; + samsung,pin-function = <0xf>; + samsung,pin-pud = <0>; + samsung,pin-drv = <0>; + }; + ec_irq: ec-irq { samsung,pins = "gpx1-6"; samsung,pin-function = <0>; @@ -575,6 +584,13 @@ samsung,pin-drv = <0>; }; + lid_irq: lid-irq { + samsung,pins = "gpx3-5"; + samsung,pin-function = <0xf>; + samsung,pin-pud = <0>; + samsung,pin-drv = <0>; + }; + hdmi_hpd_irq: hdmi-hpd-irq { samsung,pins = "gpx3-7"; samsung,pin-function = <0>; -- 2.1.3 ^ permalink raw reply related [flat|nested] 11+ messages in thread
* [PATCH RESEND 1/4] ARM: dts: Add power and lid GPIO keys pinctrl for exynos5250-snow 2015-01-02 15:24 ` [PATCH RESEND 1/4] ARM: dts: Add power and lid GPIO keys pinctrl for exynos5250-snow Javier Martinez Canillas @ 2015-01-14 15:17 ` Kukjin Kim 2015-01-14 15:37 ` Javier Martinez Canillas 0 siblings, 1 reply; 11+ messages in thread From: Kukjin Kim @ 2015-01-14 15:17 UTC (permalink / raw) To: linux-arm-kernel On 01/03/15 00:24, Javier Martinez Canillas wrote: > The Exynos5250 Snow Chromebook has GPIO keys for power and lid > so the SoC I/O pins have to be configured in external interrupt > mode. Currently, this is working without setting the pinctrl > lines but is better to set it explicitly instead of relying on > the previous state of the I/O pins. > > The DTS snippets were taken from the downstream ChromeOS tree. > > Signed-off-by: Javier Martinez Canillas <javier.martinez@collabora.co.uk> > --- > arch/arm/boot/dts/exynos5250-snow.dts | 16 ++++++++++++++++ > 1 file changed, 16 insertions(+) > > diff --git a/arch/arm/boot/dts/exynos5250-snow.dts b/arch/arm/boot/dts/exynos5250-snow.dts > index effaf2a..b9aeec4 100644 > --- a/arch/arm/boot/dts/exynos5250-snow.dts > +++ b/arch/arm/boot/dts/exynos5250-snow.dts > @@ -33,6 +33,8 @@ > > gpio-keys { > compatible = "gpio-keys"; > + pinctrl-names = "default"; > + pinctrl-0 = <&power_key_irq &lid_irq>; > > power { > label = "Power"; > @@ -540,6 +542,13 @@ > }; > > &pinctrl_0 { > + power_key_irq: power-key-irq { > + samsung,pins = "gpx1-3"; > + samsung,pin-function = <0xf>; I think, this setting should be same with exynos5250-spring but different. from: arch/arm/boot/dts/exynos5250-spring.dts 491 power_key_irq: power-key-irq { 492 samsung,pins = "gpx1-3"; 493 samsung,pin-function = <0>; 494 samsung,pin-pud = <0>; 495 samsung,pin-drv = <0>; 496 }; Hmm...0xf should be correct so need to fix the spring DT? > + samsung,pin-pud = <0>; > + samsung,pin-drv = <0>; > + }; > + > ec_irq: ec-irq { > samsung,pins = "gpx1-6"; > samsung,pin-function = <0>; > @@ -575,6 +584,13 @@ > samsung,pin-drv = <0>; > }; > > + lid_irq: lid-irq { > + samsung,pins = "gpx3-5"; > + samsung,pin-function = <0xf>; Same as above. > + samsung,pin-pud = <0>; > + samsung,pin-drv = <0>; > + }; > + > hdmi_hpd_irq: hdmi-hpd-irq { > samsung,pins = "gpx3-7"; > samsung,pin-function = <0>; Thanks, Kukjin ^ permalink raw reply [flat|nested] 11+ messages in thread
* [PATCH RESEND 1/4] ARM: dts: Add power and lid GPIO keys pinctrl for exynos5250-snow 2015-01-14 15:17 ` Kukjin Kim @ 2015-01-14 15:37 ` Javier Martinez Canillas 0 siblings, 0 replies; 11+ messages in thread From: Javier Martinez Canillas @ 2015-01-14 15:37 UTC (permalink / raw) To: linux-arm-kernel Hello Kukjin, On 01/14/2015 04:17 PM, Kukjin Kim wrote: >> >> &pinctrl_0 { >> + power_key_irq: power-key-irq { >> + samsung,pins = "gpx1-3"; >> + samsung,pin-function = <0xf>; > > I think, this setting should be same with exynos5250-spring but different. > > from: arch/arm/boot/dts/exynos5250-spring.dts > 491 power_key_irq: power-key-irq { > 492 samsung,pins = "gpx1-3"; > 493 samsung,pin-function = <0>; > 494 samsung,pin-pud = <0>; > 495 samsung,pin-drv = <0>; > 496 }; > > Hmm...0xf should be correct so need to fix the spring DT? > Yes, the same problem has exynos5250-snow.dts. This is less relevant now after commit f6a8249f9e55 ("pinctrl: exynos: Lock GPIOs as interrupts when used as EINTs") that moved the pinmux reconfiguration to .irq_{request,release}_resources() preventing the pads to be reconfigured as regulator input/output. But still for correctness we should audit spring / snow and change to 0xf. Best regards, Javier ^ permalink raw reply [flat|nested] 11+ messages in thread
* [PATCH RESEND 2/4] ARM: dts: Add lid GPIO key device node for Peach boards 2015-01-02 15:24 [PATCH RESEND 0/4] Small updates to Snow and Peach Pit/Pi DTS Javier Martinez Canillas 2015-01-02 15:24 ` [PATCH RESEND 1/4] ARM: dts: Add power and lid GPIO keys pinctrl for exynos5250-snow Javier Martinez Canillas @ 2015-01-02 15:24 ` Javier Martinez Canillas 2015-01-02 15:24 ` [PATCH RESEND 3/4] ARM: dts: Set Peach boards USB WebCam regulators to always on Javier Martinez Canillas ` (2 subsequent siblings) 4 siblings, 0 replies; 11+ messages in thread From: Javier Martinez Canillas @ 2015-01-02 15:24 UTC (permalink / raw) To: linux-arm-kernel The Exynos5420 Peach Pit and Exynos5800 Peach Pi boards have both a power and lid GPIO keys but only the former was defined in the DTS. Add DTS snippets for the lid GPIO key too. These were taken from the downstream ChromeOS 3.8 kernel tree. Signed-off-by: Javier Martinez Canillas <javier.martinez@collabora.co.uk> --- arch/arm/boot/dts/exynos5420-peach-pit.dts | 18 +++++++++++++++++- arch/arm/boot/dts/exynos5800-peach-pi.dts | 19 ++++++++++++++++++- 2 files changed, 35 insertions(+), 2 deletions(-) diff --git a/arch/arm/boot/dts/exynos5420-peach-pit.dts b/arch/arm/boot/dts/exynos5420-peach-pit.dts index 9a050e1..fa74a73 100644 --- a/arch/arm/boot/dts/exynos5420-peach-pit.dts +++ b/arch/arm/boot/dts/exynos5420-peach-pit.dts @@ -53,7 +53,7 @@ compatible = "gpio-keys"; pinctrl-names = "default"; - pinctrl-0 = <&power_key_irq>; + pinctrl-0 = <&power_key_irq &lid_irq>; power { label = "Power"; @@ -61,6 +61,15 @@ linux,code = <KEY_POWER>; gpio-key,wakeup; }; + + lid-switch { + label = "Lid"; + gpios = <&gpx3 4 GPIO_ACTIVE_LOW>; + linux,input-type = <5>; /* EV_SW */ + linux,code = <0>; /* SW_LID */ + debounce-interval = <1>; + gpio-key,wakeup; + }; }; memory { @@ -658,6 +667,13 @@ samsung,pin-drv = <0>; }; + lid_irq: lid-irq { + samsung,pins = "gpx3-4"; + samsung,pin-function = <0xf>; + samsung,pin-pud = <0>; + samsung,pin-drv = <0>; + }; + hdmi_hpd_irq: hdmi-hpd-irq { samsung,pins = "gpx3-7"; samsung,pin-function = <0>; diff --git a/arch/arm/boot/dts/exynos5800-peach-pi.dts b/arch/arm/boot/dts/exynos5800-peach-pi.dts index e8fdda8..d603e73 100644 --- a/arch/arm/boot/dts/exynos5800-peach-pi.dts +++ b/arch/arm/boot/dts/exynos5800-peach-pi.dts @@ -52,7 +52,7 @@ compatible = "gpio-keys"; pinctrl-names = "default"; - pinctrl-0 = <&power_key_irq>; + pinctrl-0 = <&power_key_irq &lid_irq>; power { label = "Power"; @@ -60,6 +60,16 @@ linux,code = <KEY_POWER>; gpio-key,wakeup; }; + + lid-switch { + label = "Lid"; + gpios = <&gpx3 4 GPIO_ACTIVE_LOW>; + linux,input-type = <5>; /* EV_SW */ + linux,code = <0>; /* SW_LID */ + debounce-interval = <1>; + gpio-key,wakeup; + }; + }; memory { @@ -646,6 +656,13 @@ samsung,pin-drv = <0>; }; + lid_irq: lid-irq { + samsung,pins = "gpx3-4"; + samsung,pin-function = <0xf>; + samsung,pin-pud = <0>; + samsung,pin-drv = <0>; + }; + hdmi_hpd_irq: hdmi-hpd-irq { samsung,pins = "gpx3-7"; samsung,pin-function = <0>; -- 2.1.3 ^ permalink raw reply related [flat|nested] 11+ messages in thread
* [PATCH RESEND 3/4] ARM: dts: Set Peach boards USB WebCam regulators to always on 2015-01-02 15:24 [PATCH RESEND 0/4] Small updates to Snow and Peach Pit/Pi DTS Javier Martinez Canillas 2015-01-02 15:24 ` [PATCH RESEND 1/4] ARM: dts: Add power and lid GPIO keys pinctrl for exynos5250-snow Javier Martinez Canillas 2015-01-02 15:24 ` [PATCH RESEND 2/4] ARM: dts: Add lid GPIO key device node for Peach boards Javier Martinez Canillas @ 2015-01-02 15:24 ` Javier Martinez Canillas 2015-01-02 15:24 ` [PATCH RESEND 4/4] ARM: dts: Configure regulators for suspend on exynos Peach boards Javier Martinez Canillas 2015-01-12 10:41 ` [PATCH RESEND 0/4] Small updates to Snow and Peach Pit/Pi DTS Javier Martinez Canillas 4 siblings, 0 replies; 11+ messages in thread From: Javier Martinez Canillas @ 2015-01-02 15:24 UTC (permalink / raw) To: linux-arm-kernel The Exynos5420 Peach Pit and Exynos5800 Peach Pi boards have a built-in Silicon Motion USB UVC WebCam whose power supply is the tps65090 fet5 regulator. Since the camera uses the generic USB Video Class driver and this does not grab a regulator, mark the regulator as always on so the USB device is enumerated and usable. Signed-off-by: Javier Martinez Canillas <javier.martinez@collabora.co.uk> --- arch/arm/boot/dts/exynos5420-peach-pit.dts | 1 + arch/arm/boot/dts/exynos5800-peach-pi.dts | 1 + 2 files changed, 2 insertions(+) diff --git a/arch/arm/boot/dts/exynos5420-peach-pit.dts b/arch/arm/boot/dts/exynos5420-peach-pit.dts index fa74a73..a4c5152 100644 --- a/arch/arm/boot/dts/exynos5420-peach-pit.dts +++ b/arch/arm/boot/dts/exynos5420-peach-pit.dts @@ -831,6 +831,7 @@ }; tps65090_fet5: fet5 { regulator-name = "camout"; + regulator-always-on; }; tps65090_fet6: fet6 { regulator-name = "lcd_vdd"; diff --git a/arch/arm/boot/dts/exynos5800-peach-pi.dts b/arch/arm/boot/dts/exynos5800-peach-pi.dts index d603e73..1367276 100644 --- a/arch/arm/boot/dts/exynos5800-peach-pi.dts +++ b/arch/arm/boot/dts/exynos5800-peach-pi.dts @@ -820,6 +820,7 @@ }; tps65090_fet5: fet5 { regulator-name = "camout"; + regulator-always-on; }; tps65090_fet6: fet6 { regulator-name = "lcd_vdd"; -- 2.1.3 ^ permalink raw reply related [flat|nested] 11+ messages in thread
* [PATCH RESEND 4/4] ARM: dts: Configure regulators for suspend on exynos Peach boards 2015-01-02 15:24 [PATCH RESEND 0/4] Small updates to Snow and Peach Pit/Pi DTS Javier Martinez Canillas ` (2 preceding siblings ...) 2015-01-02 15:24 ` [PATCH RESEND 3/4] ARM: dts: Set Peach boards USB WebCam regulators to always on Javier Martinez Canillas @ 2015-01-02 15:24 ` Javier Martinez Canillas 2015-01-12 10:41 ` [PATCH RESEND 0/4] Small updates to Snow and Peach Pit/Pi DTS Javier Martinez Canillas 4 siblings, 0 replies; 11+ messages in thread From: Javier Martinez Canillas @ 2015-01-02 15:24 UTC (permalink / raw) To: linux-arm-kernel The regulator core now has support to choose if a regulator has to be enabled or disabled during system suspend and also supports changing the regulator operating mode during runtime and when the system enters into sleep mode. To lower power during suspend, configure the regulators state using the same configuration found in the ChromeOS 3.8 kernel Signed-off-by: Javier Martinez Canillas <javier.martinez@collabora.co.uk> --- arch/arm/boot/dts/exynos5420-peach-pit.dts | 81 ++++++++++++++++++++++++++++++ arch/arm/boot/dts/exynos5800-peach-pi.dts | 81 ++++++++++++++++++++++++++++++ 2 files changed, 162 insertions(+) diff --git a/arch/arm/boot/dts/exynos5420-peach-pit.dts b/arch/arm/boot/dts/exynos5420-peach-pit.dts index a4c5152..c47bb70 100644 --- a/arch/arm/boot/dts/exynos5420-peach-pit.dts +++ b/arch/arm/boot/dts/exynos5420-peach-pit.dts @@ -13,6 +13,7 @@ #include <dt-bindings/gpio/gpio.h> #include <dt-bindings/interrupt-controller/irq.h> #include <dt-bindings/clock/maxim,max77802.h> +#include <dt-bindings/regulator/maxim,max77802.h> #include "exynos5420.dtsi" / { @@ -201,6 +202,9 @@ regulator-always-on; regulator-boot-on; regulator-ramp-delay = <12500>; + regulator-state-mem { + regulator-off-in-suspend; + }; }; buck2_reg: BUCK2 { @@ -210,6 +214,9 @@ regulator-always-on; regulator-boot-on; regulator-ramp-delay = <12500>; + regulator-state-mem { + regulator-off-in-suspend; + }; }; buck3_reg: BUCK3 { @@ -219,6 +226,9 @@ regulator-always-on; regulator-boot-on; regulator-ramp-delay = <12500>; + regulator-state-mem { + regulator-off-in-suspend; + }; }; buck4_reg: BUCK4 { @@ -228,6 +238,9 @@ regulator-always-on; regulator-boot-on; regulator-ramp-delay = <12500>; + regulator-state-mem { + regulator-off-in-suspend; + }; }; buck5_reg: BUCK5 { @@ -236,6 +249,9 @@ regulator-max-microvolt = <1200000>; regulator-always-on; regulator-boot-on; + regulator-state-mem { + regulator-off-in-suspend; + }; }; buck6_reg: BUCK6 { @@ -245,6 +261,9 @@ regulator-always-on; regulator-boot-on; regulator-ramp-delay = <12500>; + regulator-state-mem { + regulator-off-in-suspend; + }; }; buck7_reg: BUCK7 { @@ -253,6 +272,9 @@ regulator-max-microvolt = <1350000>; regulator-always-on; regulator-boot-on; + regulator-state-mem { + regulator-on-in-suspend; + }; }; buck8_reg: BUCK8 { @@ -261,6 +283,9 @@ regulator-max-microvolt = <2850000>; regulator-always-on; regulator-boot-on; + regulator-state-mem { + regulator-off-in-suspend; + }; }; buck9_reg: BUCK9 { @@ -269,6 +294,9 @@ regulator-max-microvolt = <2000000>; regulator-always-on; regulator-boot-on; + regulator-state-mem { + regulator-on-in-suspend; + }; }; buck10_reg: BUCK10 { @@ -277,6 +305,9 @@ regulator-max-microvolt = <1800000>; regulator-always-on; regulator-boot-on; + regulator-state-mem { + regulator-on-in-suspend; + }; }; ldo1_reg: LDO1 { @@ -284,6 +315,10 @@ regulator-min-microvolt = <1000000>; regulator-max-microvolt = <1000000>; regulator-always-on; + regulator-state-mem { + regulator-on-in-suspend; + regulator-mode = <MAX77802_OPMODE_LP>; + }; }; ldo2_reg: LDO2 { @@ -297,6 +332,10 @@ regulator-min-microvolt = <1800000>; regulator-max-microvolt = <1800000>; regulator-always-on; + regulator-state-mem { + regulator-on-in-suspend; + regulator-mode = <MAX77802_OPMODE_LP>; + }; }; vqmmc_sdcard: ldo4_reg: LDO4 { @@ -304,6 +343,9 @@ regulator-min-microvolt = <1800000>; regulator-max-microvolt = <2800000>; regulator-always-on; + regulator-state-mem { + regulator-off-in-suspend; + }; }; ldo5_reg: LDO5 { @@ -311,6 +353,9 @@ regulator-min-microvolt = <1800000>; regulator-max-microvolt = <1800000>; regulator-always-on; + regulator-state-mem { + regulator-off-in-suspend; + }; }; ldo6_reg: LDO6 { @@ -318,6 +363,9 @@ regulator-min-microvolt = <1800000>; regulator-max-microvolt = <1800000>; regulator-always-on; + regulator-state-mem { + regulator-off-in-suspend; + }; }; ldo7_reg: LDO7 { @@ -331,6 +379,9 @@ regulator-min-microvolt = <1000000>; regulator-max-microvolt = <1000000>; regulator-always-on; + regulator-state-mem { + regulator-off-in-suspend; + }; }; ldo9_reg: LDO9 { @@ -338,6 +389,10 @@ regulator-min-microvolt = <1800000>; regulator-max-microvolt = <1800000>; regulator-always-on; + regulator-state-mem { + regulator-on-in-suspend; + regulator-mode = <MAX77802_OPMODE_LP>; + }; }; ldo10_reg: LDO10 { @@ -345,6 +400,9 @@ regulator-min-microvolt = <1800000>; regulator-max-microvolt = <1800000>; regulator-always-on; + regulator-state-mem { + regulator-off-in-suspend; + }; }; ldo11_reg: LDO11 { @@ -352,6 +410,10 @@ regulator-min-microvolt = <1800000>; regulator-max-microvolt = <1800000>; regulator-always-on; + regulator-state-mem { + regulator-on-in-suspend; + regulator-mode = <MAX77802_OPMODE_LP>; + }; }; ldo12_reg: LDO12 { @@ -359,6 +421,9 @@ regulator-min-microvolt = <3000000>; regulator-max-microvolt = <3000000>; regulator-always-on; + regulator-state-mem { + regulator-off-in-suspend; + }; }; ldo13_reg: LDO13 { @@ -366,6 +431,10 @@ regulator-min-microvolt = <1800000>; regulator-max-microvolt = <1800000>; regulator-always-on; + regulator-state-mem { + regulator-on-in-suspend; + regulator-mode = <MAX77802_OPMODE_LP>; + }; }; ldo14_reg: LDO14 { @@ -373,6 +442,9 @@ regulator-min-microvolt = <1800000>; regulator-max-microvolt = <1800000>; regulator-always-on; + regulator-state-mem { + regulator-off-in-suspend; + }; }; ldo15_reg: LDO15 { @@ -380,6 +452,9 @@ regulator-min-microvolt = <1000000>; regulator-max-microvolt = <1000000>; regulator-always-on; + regulator-state-mem { + regulator-off-in-suspend; + }; }; ldo17_reg: LDO17 { @@ -387,6 +462,9 @@ regulator-min-microvolt = <900000>; regulator-max-microvolt = <1400000>; regulator-always-on; + regulator-state-mem { + regulator-off-in-suspend; + }; }; ldo18_reg: LDO18 { @@ -460,6 +538,9 @@ regulator-min-microvolt = <1000000>; regulator-max-microvolt = <1000000>; regulator-always-on; + regulator-state-mem { + regulator-off-in-suspend; + }; }; ldo32_reg: LDO32 { diff --git a/arch/arm/boot/dts/exynos5800-peach-pi.dts b/arch/arm/boot/dts/exynos5800-peach-pi.dts index 1367276..06737c6 100644 --- a/arch/arm/boot/dts/exynos5800-peach-pi.dts +++ b/arch/arm/boot/dts/exynos5800-peach-pi.dts @@ -13,6 +13,7 @@ #include <dt-bindings/gpio/gpio.h> #include <dt-bindings/interrupt-controller/irq.h> #include <dt-bindings/clock/maxim,max77802.h> +#include <dt-bindings/regulator/maxim,max77802.h> #include "exynos5800.dtsi" / { @@ -201,6 +202,9 @@ regulator-always-on; regulator-boot-on; regulator-ramp-delay = <12500>; + regulator-state-mem { + regulator-off-in-suspend; + }; }; buck2_reg: BUCK2 { @@ -210,6 +214,9 @@ regulator-always-on; regulator-boot-on; regulator-ramp-delay = <12500>; + regulator-state-mem { + regulator-off-in-suspend; + }; }; buck3_reg: BUCK3 { @@ -219,6 +226,9 @@ regulator-always-on; regulator-boot-on; regulator-ramp-delay = <12500>; + regulator-state-mem { + regulator-off-in-suspend; + }; }; buck4_reg: BUCK4 { @@ -228,6 +238,9 @@ regulator-always-on; regulator-boot-on; regulator-ramp-delay = <12500>; + regulator-state-mem { + regulator-off-in-suspend; + }; }; buck5_reg: BUCK5 { @@ -236,6 +249,9 @@ regulator-max-microvolt = <1200000>; regulator-always-on; regulator-boot-on; + regulator-state-mem { + regulator-off-in-suspend; + }; }; buck6_reg: BUCK6 { @@ -245,6 +261,9 @@ regulator-always-on; regulator-boot-on; regulator-ramp-delay = <12500>; + regulator-state-mem { + regulator-off-in-suspend; + }; }; buck7_reg: BUCK7 { @@ -253,6 +272,9 @@ regulator-max-microvolt = <1350000>; regulator-always-on; regulator-boot-on; + regulator-state-mem { + regulator-on-in-suspend; + }; }; buck8_reg: BUCK8 { @@ -261,6 +283,9 @@ regulator-max-microvolt = <2850000>; regulator-always-on; regulator-boot-on; + regulator-state-mem { + regulator-off-in-suspend; + }; }; buck9_reg: BUCK9 { @@ -269,6 +294,9 @@ regulator-max-microvolt = <2000000>; regulator-always-on; regulator-boot-on; + regulator-state-mem { + regulator-on-in-suspend; + }; }; buck10_reg: BUCK10 { @@ -277,6 +305,9 @@ regulator-max-microvolt = <1800000>; regulator-always-on; regulator-boot-on; + regulator-state-mem { + regulator-on-in-suspend; + }; }; ldo1_reg: LDO1 { @@ -284,6 +315,10 @@ regulator-min-microvolt = <1000000>; regulator-max-microvolt = <1000000>; regulator-always-on; + regulator-state-mem { + regulator-on-in-suspend; + regulator-mode = <MAX77802_OPMODE_LP>; + }; }; ldo2_reg: LDO2 { @@ -297,6 +332,10 @@ regulator-min-microvolt = <1800000>; regulator-max-microvolt = <1800000>; regulator-always-on; + regulator-state-mem { + regulator-on-in-suspend; + regulator-mode = <MAX77802_OPMODE_LP>; + }; }; vqmmc_sdcard: ldo4_reg: LDO4 { @@ -304,6 +343,9 @@ regulator-min-microvolt = <1800000>; regulator-max-microvolt = <2800000>; regulator-always-on; + regulator-state-mem { + regulator-off-in-suspend; + }; }; ldo5_reg: LDO5 { @@ -311,6 +353,9 @@ regulator-min-microvolt = <1800000>; regulator-max-microvolt = <1800000>; regulator-always-on; + regulator-state-mem { + regulator-off-in-suspend; + }; }; ldo6_reg: LDO6 { @@ -318,6 +363,9 @@ regulator-min-microvolt = <1800000>; regulator-max-microvolt = <1800000>; regulator-always-on; + regulator-state-mem { + regulator-off-in-suspend; + }; }; ldo7_reg: LDO7 { @@ -331,6 +379,9 @@ regulator-min-microvolt = <1000000>; regulator-max-microvolt = <1000000>; regulator-always-on; + regulator-state-mem { + regulator-off-in-suspend; + }; }; ldo9_reg: LDO9 { @@ -338,6 +389,10 @@ regulator-min-microvolt = <1800000>; regulator-max-microvolt = <1800000>; regulator-always-on; + regulator-state-mem { + regulator-on-in-suspend; + regulator-mode = <MAX77802_OPMODE_LP>; + }; }; ldo10_reg: LDO10 { @@ -345,6 +400,9 @@ regulator-min-microvolt = <1800000>; regulator-max-microvolt = <1800000>; regulator-always-on; + regulator-state-mem { + regulator-off-in-suspend; + }; }; ldo11_reg: LDO11 { @@ -352,6 +410,10 @@ regulator-min-microvolt = <1800000>; regulator-max-microvolt = <1800000>; regulator-always-on; + regulator-state-mem { + regulator-on-in-suspend; + regulator-mode = <MAX77802_OPMODE_LP>; + }; }; ldo12_reg: LDO12 { @@ -359,6 +421,9 @@ regulator-min-microvolt = <3000000>; regulator-max-microvolt = <3000000>; regulator-always-on; + regulator-state-mem { + regulator-off-in-suspend; + }; }; ldo13_reg: LDO13 { @@ -366,6 +431,10 @@ regulator-min-microvolt = <1800000>; regulator-max-microvolt = <1800000>; regulator-always-on; + regulator-state-mem { + regulator-on-in-suspend; + regulator-mode = <MAX77802_OPMODE_LP>; + }; }; ldo14_reg: LDO14 { @@ -373,6 +442,9 @@ regulator-min-microvolt = <1800000>; regulator-max-microvolt = <1800000>; regulator-always-on; + regulator-state-mem { + regulator-off-in-suspend; + }; }; ldo15_reg: LDO15 { @@ -380,6 +452,9 @@ regulator-min-microvolt = <1000000>; regulator-max-microvolt = <1000000>; regulator-always-on; + regulator-state-mem { + regulator-off-in-suspend; + }; }; ldo17_reg: LDO17 { @@ -387,6 +462,9 @@ regulator-min-microvolt = <900000>; regulator-max-microvolt = <1400000>; regulator-always-on; + regulator-state-mem { + regulator-off-in-suspend; + }; }; ldo18_reg: LDO18 { @@ -460,6 +538,9 @@ regulator-min-microvolt = <1000000>; regulator-max-microvolt = <1000000>; regulator-always-on; + regulator-state-mem { + regulator-off-in-suspend; + }; }; ldo32_reg: LDO32 { -- 2.1.3 ^ permalink raw reply related [flat|nested] 11+ messages in thread
* [PATCH RESEND 0/4] Small updates to Snow and Peach Pit/Pi DTS 2015-01-02 15:24 [PATCH RESEND 0/4] Small updates to Snow and Peach Pit/Pi DTS Javier Martinez Canillas ` (3 preceding siblings ...) 2015-01-02 15:24 ` [PATCH RESEND 4/4] ARM: dts: Configure regulators for suspend on exynos Peach boards Javier Martinez Canillas @ 2015-01-12 10:41 ` Javier Martinez Canillas 2015-01-14 15:12 ` Kukjin Kim 4 siblings, 1 reply; 11+ messages in thread From: Javier Martinez Canillas @ 2015-01-12 10:41 UTC (permalink / raw) To: linux-arm-kernel Hello Kukjin, On 01/02/2015 04:24 PM, Javier Martinez Canillas wrote: > > This series adds some DTS snippets that were missing in the mainline > Snow and Peach Pit/Pi Device Trees but are present in the downstream > ChromeOS kernel. > > The series is composed of the following patches: > > Javier Martinez Canillas (4): > ARM: dts: Add power and lid GPIO keys pinctrl for exynos5250-snow > ARM: dts: Add lid GPIO key device node for Peach boards > ARM: dts: Set Peach boards USB WebCam regulators to always on > ARM: dts: Configure regulators for suspend on exynos Peach boards > > arch/arm/boot/dts/exynos5250-snow.dts | 16 +++++ > arch/arm/boot/dts/exynos5420-peach-pit.dts | 100 +++++++++++++++++++++++++++- > arch/arm/boot/dts/exynos5800-peach-pi.dts | 101 ++++++++++++++++++++++++++++- > 3 files changed, 215 insertions(+), 2 deletions(-) > > Patch #1 adds some pinctrl lines for the GPIO keys in the Snow DTS. > > Patch #2 adds a device node and pinctrl lines for the lid GPIO in > the Peach boards DTS. > > Patch #3 sets the regulators that supply voltage to the USB WebCam > in Peach boards as always on. > > Patch #4 configures the max77802 regulators on the Peach Pit and Pi > boards to be enabled or disabled during system suspend. > I saw that you collected some DTS patches for 3.20 but these are not included. Any comments about this series? Thanks a lot and best regards, Javier ^ permalink raw reply [flat|nested] 11+ messages in thread
* [PATCH RESEND 0/4] Small updates to Snow and Peach Pit/Pi DTS 2015-01-12 10:41 ` [PATCH RESEND 0/4] Small updates to Snow and Peach Pit/Pi DTS Javier Martinez Canillas @ 2015-01-14 15:12 ` Kukjin Kim 2015-01-14 15:28 ` Kukjin Kim 0 siblings, 1 reply; 11+ messages in thread From: Kukjin Kim @ 2015-01-14 15:12 UTC (permalink / raw) To: linux-arm-kernel On 01/12/15 19:41, Javier Martinez Canillas wrote: > Hello Kukjin, > Hi, > On 01/02/2015 04:24 PM, Javier Martinez Canillas wrote: >> >> This series adds some DTS snippets that were missing in the mainline >> Snow and Peach Pit/Pi Device Trees but are present in the downstream >> ChromeOS kernel. >> >> The series is composed of the following patches: >> >> Javier Martinez Canillas (4): >> ARM: dts: Add power and lid GPIO keys pinctrl for exynos5250-snow >> ARM: dts: Add lid GPIO key device node for Peach boards >> ARM: dts: Set Peach boards USB WebCam regulators to always on >> ARM: dts: Configure regulators for suspend on exynos Peach boards >> >> arch/arm/boot/dts/exynos5250-snow.dts | 16 +++++ >> arch/arm/boot/dts/exynos5420-peach-pit.dts | 100 +++++++++++++++++++++++++++- >> arch/arm/boot/dts/exynos5800-peach-pi.dts | 101 ++++++++++++++++++++++++++++- >> 3 files changed, 215 insertions(+), 2 deletions(-) >> >> Patch #1 adds some pinctrl lines for the GPIO keys in the Snow DTS. >> >> Patch #2 adds a device node and pinctrl lines for the lid GPIO in >> the Peach boards DTS. >> >> Patch #3 sets the regulators that supply voltage to the USB WebCam >> in Peach boards as always on. >> >> Patch #4 configures the max77802 regulators on the Peach Pit and Pi >> boards to be enabled or disabled during system suspend. >> > > I saw that you collected some DTS patches for 3.20 but these are not > included. Any comments about this series? > Yeah, but I don't think I checked all of submitted patches including this at that time and I'll have a look at this series soon. Thanks for your gentle reminder. - Kukjin ^ permalink raw reply [flat|nested] 11+ messages in thread
* [PATCH RESEND 0/4] Small updates to Snow and Peach Pit/Pi DTS 2015-01-14 15:12 ` Kukjin Kim @ 2015-01-14 15:28 ` Kukjin Kim 2015-01-14 15:41 ` Javier Martinez Canillas 0 siblings, 1 reply; 11+ messages in thread From: Kukjin Kim @ 2015-01-14 15:28 UTC (permalink / raw) To: linux-arm-kernel On 01/15/15 00:12, Kukjin Kim wrote: > On 01/12/15 19:41, Javier Martinez Canillas wrote: >> Hello Kukjin, >> > Hi, > >> On 01/02/2015 04:24 PM, Javier Martinez Canillas wrote: >>> >>> This series adds some DTS snippets that were missing in the mainline >>> Snow and Peach Pit/Pi Device Trees but are present in the downstream >>> ChromeOS kernel. >>> >>> The series is composed of the following patches: >>> >>> Javier Martinez Canillas (4): >>> ARM: dts: Add power and lid GPIO keys pinctrl for exynos5250-snow >>> ARM: dts: Add lid GPIO key device node for Peach boards >>> ARM: dts: Set Peach boards USB WebCam regulators to always on >>> ARM: dts: Configure regulators for suspend on exynos Peach boards >>> >>> arch/arm/boot/dts/exynos5250-snow.dts | 16 +++++ >>> arch/arm/boot/dts/exynos5420-peach-pit.dts | 100 +++++++++++++++++++++++++++- >>> arch/arm/boot/dts/exynos5800-peach-pi.dts | 101 ++++++++++++++++++++++++++++- >>> 3 files changed, 215 insertions(+), 2 deletions(-) >>> >>> Patch #1 adds some pinctrl lines for the GPIO keys in the Snow DTS. >>> >>> Patch #2 adds a device node and pinctrl lines for the lid GPIO in >>> the Peach boards DTS. >>> >>> Patch #3 sets the regulators that supply voltage to the USB WebCam >>> in Peach boards as always on. >>> >>> Patch #4 configures the max77802 regulators on the Peach Pit and Pi >>> boards to be enabled or disabled during system suspend. >>> >> >> I saw that you collected some DTS patches for 3.20 but these are not >> included. Any comments about this series? >> > Yeah, but I don't think I checked all of submitted patches including > this at that time and I'll have a look at this series soon. > > Thanks for your gentle reminder. > This series looks good to me, applied ;-) Thanks, Kukjin ^ permalink raw reply [flat|nested] 11+ messages in thread
* [PATCH RESEND 0/4] Small updates to Snow and Peach Pit/Pi DTS 2015-01-14 15:28 ` Kukjin Kim @ 2015-01-14 15:41 ` Javier Martinez Canillas 0 siblings, 0 replies; 11+ messages in thread From: Javier Martinez Canillas @ 2015-01-14 15:41 UTC (permalink / raw) To: linux-arm-kernel Hello Kukjin, On 01/14/2015 04:28 PM, Kukjin Kim wrote: >>> >>> I saw that you collected some DTS patches for 3.20 but these are not >>> included. Any comments about this series? >>> >> Yeah, but I don't think I checked all of submitted patches including >> this at that time and I'll have a look at this series soon. >> >> Thanks for your gentle reminder. >> > This series looks good to me, applied ;-) > Great, thanks a lot for your help! > Thanks, > Kukjin > Best regards, Javier ^ permalink raw reply [flat|nested] 11+ messages in thread
end of thread, other threads:[~2015-01-14 15:41 UTC | newest] Thread overview: 11+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2015-01-02 15:24 [PATCH RESEND 0/4] Small updates to Snow and Peach Pit/Pi DTS Javier Martinez Canillas 2015-01-02 15:24 ` [PATCH RESEND 1/4] ARM: dts: Add power and lid GPIO keys pinctrl for exynos5250-snow Javier Martinez Canillas 2015-01-14 15:17 ` Kukjin Kim 2015-01-14 15:37 ` Javier Martinez Canillas 2015-01-02 15:24 ` [PATCH RESEND 2/4] ARM: dts: Add lid GPIO key device node for Peach boards Javier Martinez Canillas 2015-01-02 15:24 ` [PATCH RESEND 3/4] ARM: dts: Set Peach boards USB WebCam regulators to always on Javier Martinez Canillas 2015-01-02 15:24 ` [PATCH RESEND 4/4] ARM: dts: Configure regulators for suspend on exynos Peach boards Javier Martinez Canillas 2015-01-12 10:41 ` [PATCH RESEND 0/4] Small updates to Snow and Peach Pit/Pi DTS Javier Martinez Canillas 2015-01-14 15:12 ` Kukjin Kim 2015-01-14 15:28 ` Kukjin Kim 2015-01-14 15:41 ` Javier Martinez Canillas
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).