From: hdegoede@redhat.com (Hans de Goede)
To: linux-arm-kernel@lists.infradead.org
Subject: sun9i pll4 upstream kernel code seems wrong
Date: Sat, 17 Jan 2015 10:34:14 +0100 [thread overview]
Message-ID: <54BA2C96.7050102@redhat.com> (raw)
Hi ChenYu,
Looking at drivers/clk/sunxi/clk-sun9i-core.c:
sun9i_a80_get_pll4_factors(), and comparing it with
the A80 user manual, things seem way off, this seems
more accurate (although also possibly not quite)
for pll1 / pll2 then for pll4, and the comment at
the top does mention PLL1 once.
Note according to the datasheet pll4 should be treated
as an inmutable pll fixed at 960 MHz, so maybe we should
just drop the get_factors function for it ?
Luckily the struct clk_factors_config sun9i_a80_pll4_config
is correct, so as long as we do not try to change the
rate the current upstream code for pll4 does work.
Regards,
Hans
next reply other threads:[~2015-01-17 9:34 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-17 9:34 Hans de Goede [this message]
2015-01-17 10:37 ` sun9i pll4 upstream kernel code seems wrong Chen-Yu Tsai
2015-01-17 11:12 ` Hans de Goede
2015-01-17 11:15 ` Hans de Goede
2015-01-17 12:09 ` Chen-Yu Tsai
2015-01-17 12:30 ` Hans de Goede
2015-01-20 15:55 ` Chen-Yu Tsai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54BA2C96.7050102@redhat.com \
--to=hdegoede@redhat.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).