From mboxrd@z Thu Jan  1 00:00:00 1970
From: sergei.shtylyov@cogentembedded.com (Sergei Shtylyov)
Date: Sun, 18 Jan 2015 22:55:00 +0300
Subject: [PATCHv3 1/5] USB: host: ehci_atmel: Add suspend/resume support
In-Reply-To: <20150117224900.GA22439@gradator.net>
References: <Pine.LNX.4.44L0.1501171524050.13485-100000@netrider.rowland.org>
 <1421529942-18437-1-git-send-email-sylvain.rochet@finsecur.com>
 <1421529942-18437-2-git-send-email-sylvain.rochet@finsecur.com>
 <54BAE0AE.5060705@cogentembedded.com> <20150117224900.GA22439@gradator.net>
Message-ID: <54BC0F94.6030402@cogentembedded.com>
To: linux-arm-kernel@lists.infradead.org
List-Id: linux-arm-kernel.lists.infradead.org

Hello.

On 01/18/2015 01:49 AM, Sylvain Rochet wrote:

>>     There's little inconsistency in your patch subjects: you're using
>> '_' but the files you're modifying are named using '-'...

> Indeed.

>>> @@ -187,6 +217,8 @@ static struct platform_driver ehci_atmel_driver = {
>>>   	.probe		= ehci_atmel_drv_probe,
>>>   	.remove		= ehci_atmel_drv_remove,
>>>   	.shutdown	= usb_hcd_platform_shutdown,
>>> +	.suspend	= ehci_atmel_drv_suspend,
>>> +	.resume		= ehci_atmel_drv_resume,
>>
>>     I think you should use 'struct dev_pm_ops' now.

    I'm not sure but perhaps scripts/checkpatch.pl would complain about the 
old-style PM methods... should check.

> This way ?

> static int ehci_atmel_drv_suspend(struct device *dev)
> {
> 	struct usb_hcd *hcd = dev_get_drvdata(dev);
> (...)
>
>
> static SIMPLE_DEV_PM_OPS(ehci_atmel_pm_ops, ehci_atmel_drv_suspend, ehci_atmel_drv_resume);
>
> (...)
> 	.driver         = {
> 		.pm     = &ehci_atmel_pm_ops,
> 	}
> (...)

    Yes, probably.

> Should I send a v4 or can I send this change separately on top of the
> previous change ?

    v4 please.

> Sylvain

WBR, Sergei