[PATCH] mm: export "high_memory" symbol on !MMU

[PATCH] mm: export "high_memory" symbol on !MMU

[Arnd Bergmann]

>From f391eb37fafc8a22d7fd9574b8d220f0d90a91d0 Mon Sep 17 00:00:00 2001
From: Arnd Bergmann <arnd@arndb.de>
Date: Mon, 25 Aug 2014 16:24:41 +0200
Subject: [PATCH] mm: export "high_memory" symbol on !MMU

The symbol 'high_memory' is provided on both MMU- and NOMMU-kernels,
but only one of them is exported, which leads to module build errors
in drivers that work fine built-in:

ERROR: "high_memory" [drivers/net/virtio_net.ko] undefined!
ERROR: "high_memory" [drivers/net/ppp/ppp_mppe.ko] undefined!
ERROR: "high_memory" [drivers/mtd/nand/nand.ko] undefined!
ERROR: "high_memory" [crypto/tcrypt.ko] undefined!
ERROR: "high_memory" [crypto/cts.ko] undefined!

This exports the symbol to get these to work on NOMMU as well.

Signed-off-by: Arnd Bergmann <arnd@arndb.de>

diff --git a/mm/nommu.c b/mm/nommu.c
index e9228cbe46de..7bdeb281ad0e 100644
--- a/mm/nommu.c
+++ b/mm/nommu.c
@@ -59,6 +59,7 @@
 #endif
 
 void *high_memory;
+EXPORT_SYMBOL(high_memory);
 struct page *mem_map;
 unsigned long max_mapnr;
 unsigned long highest_memmap_pfn;

[PATCH] mm: export "high_memory" symbol on !MMU

[Greg Ungerer]

On 29/01/15 00:43, Arnd Bergmann wrote:
>>From f391eb37fafc8a22d7fd9574b8d220f0d90a91d0 Mon Sep 17 00:00:00 2001
> From: Arnd Bergmann <arnd@arndb.de>
> Date: Mon, 25 Aug 2014 16:24:41 +0200
> Subject: [PATCH] mm: export "high_memory" symbol on !MMU
> 
> The symbol 'high_memory' is provided on both MMU- and NOMMU-kernels,
> but only one of them is exported, which leads to module build errors
> in drivers that work fine built-in:
> 
> ERROR: "high_memory" [drivers/net/virtio_net.ko] undefined!
> ERROR: "high_memory" [drivers/net/ppp/ppp_mppe.ko] undefined!
> ERROR: "high_memory" [drivers/mtd/nand/nand.ko] undefined!
> ERROR: "high_memory" [crypto/tcrypt.ko] undefined!
> ERROR: "high_memory" [crypto/cts.ko] undefined!
> 
> This exports the symbol to get these to work on NOMMU as well.
> 
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>

Here is an ack if you want one:

Acked-by: Greg Ungerer <gerg@uclinux.org>

Regards
Greg


> diff --git a/mm/nommu.c b/mm/nommu.c
> index e9228cbe46de..7bdeb281ad0e 100644
> --- a/mm/nommu.c
> +++ b/mm/nommu.c
> @@ -59,6 +59,7 @@
>  #endif
>  
>  void *high_memory;
> +EXPORT_SYMBOL(high_memory);
>  struct page *mem_map;
>  unsigned long max_mapnr;
>  unsigned long highest_memmap_pfn;
> 
> 

[PATCH] mm: export "high_memory" symbol on !MMU

[David Rientjes]

On Wed, 28 Jan 2015, Arnd Bergmann wrote:

> The symbol 'high_memory' is provided on both MMU- and NOMMU-kernels,
> but only one of them is exported, which leads to module build errors
> in drivers that work fine built-in:
> 
> ERROR: "high_memory" [drivers/net/virtio_net.ko] undefined!
> ERROR: "high_memory" [drivers/net/ppp/ppp_mppe.ko] undefined!
> ERROR: "high_memory" [drivers/mtd/nand/nand.ko] undefined!
> ERROR: "high_memory" [crypto/tcrypt.ko] undefined!
> ERROR: "high_memory" [crypto/cts.ko] undefined!
> 
> This exports the symbol to get these to work on NOMMU as well.
> 
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>

Acked-by: David Rientjes <rientjes@google.com>