linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: daniel@zonque.org (Daniel Mack)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: pxa: pxa27x skip default device initialization with DT
Date: Sat, 07 Feb 2015 23:32:00 +0100	[thread overview]
Message-ID: <54D69260.3020204@zonque.org> (raw)
In-Reply-To: <1423343914-32342-1-git-send-email-robert.jarzmik@free.fr>

On 02/07/2015 10:18 PM, Robert Jarzmik wrote:
> When booting via DT, the default PXA devices must not have been probed
> before, otherwise the augmented information from the device tree is
> ignored.
> 
> This is the twin commit of commit 82ce44d104dc ("ARM: pxa3xx: skip
> default device initialization when booting via DT").
> 
> Signed-off-by: Robert Jarzmik <robert.jarzmik@free.fr>

Looks good to me - thanks!

Acked-by: Daniel Mack <daniel@zonque.org>

> ---
>  arch/arm/mach-pxa/pxa27x.c | 8 ++++++--
>  1 file changed, 6 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/arm/mach-pxa/pxa27x.c b/arch/arm/mach-pxa/pxa27x.c
> index 0485248..b5abdeb 100644
> --- a/arch/arm/mach-pxa/pxa27x.c
> +++ b/arch/arm/mach-pxa/pxa27x.c
> @@ -307,8 +307,12 @@ static int __init pxa27x_init(void)
>  		register_syscore_ops(&pxa_irq_syscore_ops);
>  		register_syscore_ops(&pxa2xx_mfp_syscore_ops);
>  
> -		pxa_register_device(&pxa27x_device_gpio, &pxa27x_gpio_info);
> -		ret = platform_add_devices(devices, ARRAY_SIZE(devices));
> +		if (!of_have_populated_dt()) {
> +			pxa_register_device(&pxa27x_device_gpio,
> +					    &pxa27x_gpio_info);
> +			ret = platform_add_devices(devices,
> +						   ARRAY_SIZE(devices));
> +		}
>  	}
>  
>  	return ret;
> 

  reply	other threads:[~2015-02-07 22:32 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-02-07 21:18 [PATCH] ARM: pxa: pxa27x skip default device initialization with DT Robert Jarzmik
2015-02-07 22:32 ` Daniel Mack [this message]
2015-02-14 21:36   ` Robert Jarzmik
  -- strict thread matches above, loose matches on Subject: below --
2015-01-31 22:36 Robert Jarzmik

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=54D69260.3020204@zonque.org \
    --to=daniel@zonque.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).