From: t-kristo@ti.com (Tero Kristo)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 9/9] RFC: ARM: DRA7: enable DSS_DESHDCP_CLKEN
Date: Fri, 13 Feb 2015 17:42:54 +0200 [thread overview]
Message-ID: <54DE1B7E.10505@ti.com> (raw)
In-Reply-To: <CAGo_u6p89ot-eNwK65otoYsLM6NXeh929=SBG6uKAsX8Tnd_RQ@mail.gmail.com>
On 02/13/2015 05:25 PM, Nishanth Menon wrote:
> On Fri, Feb 13, 2015 at 9:11 AM, Tomi Valkeinen <tomi.valkeinen@ti.com> wrote:
>> DRA7xx's CTRL_CORE_CONTROL_IO_2 register contains bits for various
>> subsystems, including PCIe, DCAN, QSPI and DSS. At the moment only DCAN
>> bits are used by the SW via syscon.
>>
>> For DSS there is DSS_DESHDCP_CLKEN bit. This (presumably) enables a
>> clock related to DSS's HDCP. If that clock is off, DSS module does not
>> start at all, causing OCP errors. This means that the HWMOD code is not
>> able to reset and initialize DSS.
>>
>> Signed-off-by: Tomi Valkeinen <tomi.valkeinen@ti.com>
>> ---
>> arch/arm/mach-omap2/io.c | 11 +++++++++++
>> 1 file changed, 11 insertions(+)
>>
>> diff --git a/arch/arm/mach-omap2/io.c b/arch/arm/mach-omap2/io.c
>> index a1bd6affb508..2206fb13f195 100644
>> --- a/arch/arm/mach-omap2/io.c
>> +++ b/arch/arm/mach-omap2/io.c
>> @@ -700,6 +700,17 @@ void __init dra7xx_init_early(void)
>> dra7xx_hwmod_init();
>> omap_hwmod_init_postsetup();
>> omap_clk_soc_init = dra7xx_dt_clk_init;
>> +
>> + if (soc_is_dra7xx()) {
>
> Umm.. this code will only be executed for dra7xx :)
>
>> + u32 v;
>> + const u16 ctrl_core_control_io_2 = 0x558;
>> +
>> + /* set CTRL_CORE_CONTROL_IO_2:DSS_DESHDCP_CLKEN */
>> +
>> + v = omap_ctrl_readl(ctrl_core_control_io_2);
>> + v |= 1;
>> + omap_ctrl_writel(v, ctrl_core_control_io_2);
>> + }
>> }
>>
>> void __init dra7xx_init_late(void)
> just my 2 cents.
> I would probably wait for control module to become syscon and probably
> model this as syscon clk - I thin we should be seeing a series
> sometime soon.
Yeah, I will be posting a series in a bit, just running some final tests
on it.
-Tero
next prev parent reply other threads:[~2015-02-13 15:42 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-13 15:11 [PATCH 0/9] ARM: DRA7: add display support Tomi Valkeinen
2015-02-13 15:11 ` [PATCH 1/9] arm/dts: dra7xx: add 'ti, set-rate-parent' for dss_dss_clk Tomi Valkeinen
2015-02-13 15:11 ` [PATCH 2/9] ARM: DRA7: hwmod: add DMM hwmod description Tomi Valkeinen
2015-02-13 15:11 ` [PATCH 3/9] ARM: DRA7: hwmod: set DSS submodule parent hwmods Tomi Valkeinen
2015-02-13 15:11 ` [PATCH 4/9] ARM: OMAP: display: change compat names to array Tomi Valkeinen
2015-02-13 15:11 ` [PATCH 5/9] ARM: OMAP2+: display: detect DRA7 DSS Tomi Valkeinen
2015-02-13 15:11 ` [PATCH 6/9] arm/dts: dra7.dtsi: add DSS support Tomi Valkeinen
2015-02-13 15:11 ` [PATCH 7/9] arm/dts: dra72-evm.dts: add HDMI Tomi Valkeinen
2015-02-13 15:11 ` [PATCH 8/9] arm/dts: am57xx-beagle-x15.dts: " Tomi Valkeinen
2015-02-13 15:11 ` [PATCH 9/9] RFC: ARM: DRA7: enable DSS_DESHDCP_CLKEN Tomi Valkeinen
2015-02-13 15:25 ` Nishanth Menon
2015-02-13 15:42 ` Tero Kristo [this message]
2015-02-20 11:46 ` Tomi Valkeinen
2015-02-20 12:59 ` Tero Kristo
2015-02-20 13:48 ` Tomi Valkeinen
2015-02-20 16:59 ` Tero Kristo
2015-02-16 8:28 ` Tomi Valkeinen
2015-02-13 16:01 ` [PATCH 0/9] ARM: DRA7: add display support Nishanth Menon
2015-02-16 8:30 ` Tomi Valkeinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54DE1B7E.10505@ti.com \
--to=t-kristo@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).