From: hanjun.guo@linaro.org (Hanjun Guo)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v3 2/9] ACPI: clear up warnings on use of printk reported by checkpatch.pl
Date: Wed, 25 Feb 2015 20:55:41 +0800 [thread overview]
Message-ID: <54EDC64D.8040301@linaro.org> (raw)
In-Reply-To: <1424824585-6405-3-git-send-email-al.stone@linaro.org>
On 2015?02?25? 08:36, al.stone at linaro.org wrote:
> From: Al Stone <al.stone@linaro.org>
>
> In preparation for later splitting out some of the arch-dependent code from
> osl.c, clear up all the warnings reported by checkpatch.pl where pr_* should
> be used instead of printk(KERN_* ...).
>
> Signed-off-by: Al Stone <al.stone@linaro.org>
> ---
> drivers/acpi/osl.c | 46 +++++++++++++++++++---------------------------
> 1 file changed, 19 insertions(+), 27 deletions(-)
>
> diff --git a/drivers/acpi/osl.c b/drivers/acpi/osl.c
> index 1dc3a3b..865317c 100644
> --- a/drivers/acpi/osl.c
> +++ b/drivers/acpi/osl.c
> @@ -141,7 +141,7 @@ static u32 acpi_osi_handler(acpi_string interface, u32 supported)
> {
> if (!strcmp("Linux", interface)) {
>
> - printk_once(KERN_NOTICE FW_BUG PREFIX
> + pr_notice_once(FW_BUG PREFIX
I think you can use pr_fmt() and then remove all the PREFIX in
this patch, just
#define pr_fmt(fmt) "ACPI: " fmt
in top of this file before all #includes.
Thanks
Hanjun
next prev parent reply other threads:[~2015-02-25 12:55 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-25 0:36 [PATCH v3 0/9] Start deprecating _OSI on new architectures al.stone at linaro.org
2015-02-25 0:36 ` [PATCH v3 1/9] ACPI: fix all errors reported by cleanpatch.pl in osl.c al.stone at linaro.org
2015-02-25 12:47 ` Hanjun Guo
2015-03-04 23:04 ` Rafael J. Wysocki
2015-03-04 23:56 ` Al Stone
2015-03-05 0:25 ` Rafael J. Wysocki
2015-03-05 0:06 ` Al Stone
2015-02-25 0:36 ` [PATCH v3 2/9] ACPI: clear up warnings on use of printk reported by checkpatch.pl al.stone at linaro.org
2015-02-25 12:55 ` Hanjun Guo [this message]
2015-02-25 20:56 ` Al Stone
2015-02-25 0:36 ` [PATCH v3 3/9] ACPI: clean up checkpatch warnings for various bits of syntax al.stone at linaro.org
2015-02-25 12:59 ` [Linaro-acpi] " Hanjun Guo
2015-02-25 0:36 ` [PATCH v3 4/9] ACPI: clean up checkpatch warnings for items with possible semantic value al.stone at linaro.org
2015-02-25 13:08 ` [Linaro-acpi] " Hanjun Guo
2015-02-25 20:57 ` Al Stone
2015-02-25 0:36 ` [PATCH v3 5/9] ACPI: move acpi_os_handler() so it can be made arch-dependent later al.stone at linaro.org
2015-02-25 13:47 ` [Linaro-acpi] " Hanjun Guo
2015-02-25 0:36 ` [PATCH v3 6/9] ACPI: move _OSI support functions to allow arch-dependent implementation al.stone at linaro.org
2015-03-04 23:09 ` Rafael J. Wysocki
2015-02-25 0:36 ` [PATCH v3 7/9] ACPI: enable arch-specific compilation for _OSI and the blacklist al.stone at linaro.org
2015-03-04 23:11 ` Rafael J. Wysocki
2015-02-25 0:36 ` [PATCH v3 8/9] ACPI: arm64: use an arch-specific ACPI _OSI method and ACPI blacklist al.stone at linaro.org
2015-03-02 17:29 ` Will Deacon
2015-03-02 19:00 ` Al Stone
2015-03-04 23:14 ` Rafael J. Wysocki
2015-03-05 10:17 ` Will Deacon
2015-03-05 12:56 ` Rafael J. Wysocki
2015-03-04 23:16 ` Rafael J. Wysocki
2015-02-25 0:36 ` [PATCH v3 9/9] ACPI: arm64: use "Linux" as ACPI_OS_NAME for _OS on arm64 al.stone at linaro.org
2015-03-04 23:17 ` Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54EDC64D.8040301@linaro.org \
--to=hanjun.guo@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).