From mboxrd@z Thu Jan 1 00:00:00 1970 From: hanjun.guo@linaro.org (Hanjun Guo) Date: Wed, 25 Feb 2015 20:55:41 +0800 Subject: [PATCH v3 2/9] ACPI: clear up warnings on use of printk reported by checkpatch.pl In-Reply-To: <1424824585-6405-3-git-send-email-al.stone@linaro.org> References: <1424824585-6405-1-git-send-email-al.stone@linaro.org> <1424824585-6405-3-git-send-email-al.stone@linaro.org> Message-ID: <54EDC64D.8040301@linaro.org> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 2015?02?25? 08:36, al.stone at linaro.org wrote: > From: Al Stone > > In preparation for later splitting out some of the arch-dependent code from > osl.c, clear up all the warnings reported by checkpatch.pl where pr_* should > be used instead of printk(KERN_* ...). > > Signed-off-by: Al Stone > --- > drivers/acpi/osl.c | 46 +++++++++++++++++++--------------------------- > 1 file changed, 19 insertions(+), 27 deletions(-) > > diff --git a/drivers/acpi/osl.c b/drivers/acpi/osl.c > index 1dc3a3b..865317c 100644 > --- a/drivers/acpi/osl.c > +++ b/drivers/acpi/osl.c > @@ -141,7 +141,7 @@ static u32 acpi_osi_handler(acpi_string interface, u32 supported) > { > if (!strcmp("Linux", interface)) { > > - printk_once(KERN_NOTICE FW_BUG PREFIX > + pr_notice_once(FW_BUG PREFIX I think you can use pr_fmt() and then remove all the PREFIX in this patch, just #define pr_fmt(fmt) "ACPI: " fmt in top of this file before all #includes. Thanks Hanjun