linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: sudeep.holla@arm.com (Sudeep Holla)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: vexpress: update CONFIG_USB_ISP1760 option
Date: Thu, 26 Feb 2015 12:48:00 +0000	[thread overview]
Message-ID: <54EF1600.7000508@arm.com> (raw)
In-Reply-To: <CANLsYkx3B1PD_RTUPZBNASULOXXOXNnKScbt-JFpKyeWbOC_Yg@mail.gmail.com>

Hi Arnd,

On 24/02/15 17:10, Mathieu Poirier wrote:
> On 24 February 2015 at 08:17, Sudeep Holla <sudeep.holla@arm.com> wrote:
>>
>>
>> On 24/02/15 15:08, Mathieu Poirier wrote:
>>>
>>> On 24 February 2015 at 08:02, Sudeep Holla <sudeep.holla@arm.com> wrote:
>>>>
>>>> Commt 7ef077a8ad35 ("usb: isp1760: Move driver from drivers/usb/host/
>>>> to drivers/usb/isp1760/") moved the isp1760 driver and changed the
>>>> Kconfig option. This makes CONFIG_USB_ISP1760_HCD not selectable
>>>> directly anymore. This results in driver being not compiled in when
>>>> using vexpress_defconfig and the USB is non-functional.
>>>>
>>>> This patch updates the CONFIG_USB_ISP1760_HCD to CONFIG_USB_ISP1760 to
>>>> get back USB functional on vexpress platforms.
>>>>
>>>> Cc: Liviu Dudau <liviu.dudau@arm.com>
>>>> Cc: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
>>>> Signed-off-by: Sudeep Holla <sudeep.holla@arm.com>
>>>> ---
>>>>    arch/arm/configs/vexpress_defconfig | 2 +-
>>>>    1 file changed, 1 insertion(+), 1 deletion(-)
>>>>
>>>> diff --git a/arch/arm/configs/vexpress_defconfig
>>>> b/arch/arm/configs/vexpress_defconfig
>>>> index f489fdaa19b8..37fe607a4ede 100644
>>>> --- a/arch/arm/configs/vexpress_defconfig
>>>> +++ b/arch/arm/configs/vexpress_defconfig
>>>> @@ -118,8 +118,8 @@ CONFIG_HID_ZEROPLUS=y
>>>>    CONFIG_USB=y
>>>>    CONFIG_USB_ANNOUNCE_NEW_DEVICES=y
>>>>    CONFIG_USB_MON=y
>>>> -CONFIG_USB_ISP1760_HCD=y
>>>>    CONFIG_USB_STORAGE=y
>>>> +CONFIG_USB_ISP1760=y
>>>>    CONFIG_MMC=y
>>>>    CONFIG_MMC_ARMMMCI=y
>>>>    CONFIG_NEW_LEDS=y
>>>> --
>>>> 1.9.1
>>>
>>>
>>> I tested this change and confirm that it does indeed re-activate USB
>>> functionality.
>>
>>
>> Thanks indeed. So I assume we can add
>>
>> Tested-by: Mathieu Poirier <mathieu.poirier@linaro.org>
>
> You sure can.
>

This has to go as fix, without this USB is not enabled with
vexpress_defconfig and breaks for people using rootfs on USB on vepress
platform.

Regards,
Sudeep

      reply	other threads:[~2015-02-26 12:48 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-02-24 15:02 [PATCH] ARM: vexpress: update CONFIG_USB_ISP1760 option Sudeep Holla
2015-02-24 15:08 ` Mathieu Poirier
2015-02-24 15:17   ` Sudeep Holla
2015-02-24 17:10     ` Mathieu Poirier
2015-02-26 12:48       ` Sudeep Holla [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=54EF1600.7000508@arm.com \
    --to=sudeep.holla@arm.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).