From: kgene@kernel.org (Kukjin Kim)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: EXYNOS: Don't use LDREX and STREX after disabling cache coherency
Date: Fri, 27 Feb 2015 05:52:52 +0900 [thread overview]
Message-ID: <54EF87A4.6090609@kernel.org> (raw)
In-Reply-To: <54E3BFB3.5030801@codeaurora.org>
On 02/18/15 07:24, Stephen Boyd wrote:
> On 02/16/15 05:36, Krzysztof Kozlowski wrote:
>> During CPU shutdown the exynos_cpu_power_down() is called after
>> disabling cache coherency and it uses LDREX and STREX instructions (by
>> calling of_machine_is_compatible() -> kobject_get() -> kref_get()).
>>
>> The LDREX and STREX should not be used after disabling the cache
>> coherency so just use soc_is_exynos().
>>
>> Signed-off-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
>> Fixes: adc548d77c22 ("ARM: EXYNOS: Use MCPM call-backs to support S2R on exynos5420")
>> Cc: <stable@vger.kernel.org>
>> Reported-by: Stephen Boyd <sboyd@codeaurora.org>
>> ---
>
> Looks good to me.
>
> Reviewed-by: Stephen Boyd <sboyd@codeaurora.org>
>
Thanks for this fix, applied.
- Kukjin
prev parent reply other threads:[~2015-02-26 20:52 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-16 13:36 [PATCH] ARM: EXYNOS: Don't use LDREX and STREX after disabling cache coherency Krzysztof Kozlowski
2015-02-17 22:24 ` Stephen Boyd
2015-02-26 20:52 ` Kukjin Kim [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54EF87A4.6090609@kernel.org \
--to=kgene@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).