From: kgene@kernel.org (Kukjin Kim)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: fix exynos randconfig build error
Date: Fri, 27 Feb 2015 06:30:57 +0900 [thread overview]
Message-ID: <54EF9091.30802@kernel.org> (raw)
In-Reply-To: <CAJKOXPf2F-g9fU9TrNXz8LPwp8fBNZ6NpaAoP15N0nbHWVesaw@mail.gmail.com>
On 02/25/15 20:46, Krzysztof Kozlowski wrote:
> 2015-02-25 12:26 GMT+01:00 Russell King <rmk+kernel@arm.linux.org.uk>:
>> The following error was observed with SMP=n in v4.0-rc1:
>>
>> arch/arm/mach-exynos/pm.c: In function 'exynos_cpu0_enter_aftr':
>> arch/arm/mach-exynos/pm.c:246:4: error: implicit declaration of function 'arch_send_wakeup_ipi_mask' [-Werror=implicit-function-declaration]
>>
>> As the code unconditionally calls a function only available with SMP=y,
>> make the Exynos PM support depend on SMP.
>>
>> Signed-off-by: Russell King <rmk+kernel@arm.linux.org.uk>
>
> Hi,
>
> Thanks for the patch but this already waits for Kukjin top be picked
> up. The first patch was similar to yours (adds dependency on SMP),
> sent on 4th of February:
> https://patchwork.ozlabs.org/patch/436231/
>
> But later Bartlomiej fixed this in other way (allowing to use cpuidle
> on non-SMP):
> https://patchwork.ozlabs.org/patch/436445/
>
> Unfortunately none of them were picked up.
>
I've missed the fix, sorry.
BTW, as you know, all of exynos SoCs are based on SMP so generally (in
normal case) there is no reason to use non-SMP on exynos
platforms...even though I understand the build error should be fixed...
Anyway, I'll have a look Bart's patch and Russell's fix in this weekend.
Thanks for your kindly pointing out.
Kukjin
next prev parent reply other threads:[~2015-02-26 21:30 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-25 11:26 [PATCH] ARM: fix exynos randconfig build error Russell King
2015-02-25 11:46 ` Krzysztof Kozlowski
2015-02-26 21:30 ` Kukjin Kim [this message]
2015-03-02 19:40 ` Kukjin Kim
2015-03-03 12:44 ` Bartlomiej Zolnierkiewicz
2015-03-30 21:37 ` Russell King - ARM Linux
2015-03-31 9:26 ` Bartlomiej Zolnierkiewicz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54EF9091.30802@kernel.org \
--to=kgene@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).