From: dinguyen@opensource.altera.com (Dinh Nguyen)
To: linux-arm-kernel@lists.infradead.org
Subject: [BUG] ARM: socfpga: L2 cache init
Date: Wed, 4 Mar 2015 12:37:26 -0600 [thread overview]
Message-ID: <54F750E6.5030703@opensource.altera.com> (raw)
In-Reply-To: <20150304102342.GA14613@pengutronix.de>
On 03/04/2015 04:23 AM, Steffen Trumtrar wrote:
> On Wed, Feb 25, 2015 at 10:30:32AM -0600, Dinh Nguyen wrote:
>> On Wed, Feb 25, 2015 at 3:26 AM, Russell King - ARM Linux
>> <linux@arm.linux.org.uk> wrote:
>>> On Tue, Feb 24, 2015 at 05:55:05PM -0600, Dinh Nguyen wrote:
>>>> Do you have a recommendation on what should be done?
>>>
>>> Please try this:
>>>
>>> arch/arm/mach-socfpga/socfpga.c | 5 +++++
>>> 1 file changed, 5 insertions(+)
>>>
>>> diff --git a/arch/arm/mach-socfpga/socfpga.c b/arch/arm/mach-socfpga/socfpga.c
>>> index 383d61e138af..f5e597c207b9 100644
>>> --- a/arch/arm/mach-socfpga/socfpga.c
>>> +++ b/arch/arm/mach-socfpga/socfpga.c
>>> @@ -23,6 +23,7 @@
>>> #include <asm/hardware/cache-l2x0.h>
>>> #include <asm/mach/arch.h>
>>> #include <asm/mach/map.h>
>>> +#include <asm/cacheflush.h>
>>>
>>> #include "core.h"
>>>
>>> @@ -73,6 +74,10 @@ void __init socfpga_sysmgr_init(void)
>>> (u32 *) &socfpga_cpu1start_addr))
>>> pr_err("SMP: Need cpu1-start-addr in device tree.\n");
>>>
>>> + /* Ensure that socfpga_cpu1start_addr is visible to other CPUs */
>>> + smp_wmb();
>>> + sync_cache_w(&socfpga_cpu1start_addr);
>>> +
>>> sys_manager_base_addr = of_iomap(np, 0);
>>>
>>> np = of_find_compatible_node(NULL, NULL, "altr,rst-mgr");
>>>
>>> --
>>
>>
>> Thanks Russell! I have been able to run the test for > 30 minutes now
>> with both cores coming up just fine.
>>
>> Do you mind taking this patch for 4.0-rc? If so,
>>
>> Tested-by: Dinh Nguyen <dinguyen@opensource.altera.com>
>>
>> Steffen, if you don't mind, do you want to test on your setup as well?
>
> Looks good for me, too:
>
> Tested-by: Steffen Trumtrar <s.trumtrar@pengutronix.de>
>
Steffen, thanks for testing.
Russell, if you don't mind, I'll take this patch through my tree as I
have a couple of other fixes for 4.0-rc as well.
Thanks,
Dinh
next prev parent reply other threads:[~2015-03-04 18:37 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-06 10:39 [BUG] ARM: socfpga: L2 cache init Steffen Trumtrar
2015-02-06 11:05 ` Russell King - ARM Linux
2015-02-09 15:53 ` Steffen Trumtrar
2015-02-09 16:43 ` Dinh Nguyen
2015-02-09 18:58 ` Steffen Trumtrar
2015-02-09 21:30 ` Steffen Trumtrar
2015-02-12 22:39 ` Dinh Nguyen
2015-02-13 8:01 ` Steffen Trumtrar
2015-02-17 22:00 ` Dinh Nguyen
2015-02-17 22:28 ` Russell King - ARM Linux
2015-02-24 23:55 ` Dinh Nguyen
2015-02-25 8:21 ` Steffen Trumtrar
2015-02-25 9:26 ` Russell King - ARM Linux
2015-02-25 16:30 ` Dinh Nguyen
2015-02-26 8:30 ` Steffen Trumtrar
2015-03-04 10:23 ` Steffen Trumtrar
2015-03-04 18:37 ` Dinh Nguyen [this message]
2015-03-09 17:15 ` Russell King - ARM Linux
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54F750E6.5030703@opensource.altera.com \
--to=dinguyen@opensource.altera.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).