linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: rjui@broadcom.com (Ray Jui)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v9 2/4] pinctrl: cygnus: add gpio/pinconf driver
Date: Wed, 4 Mar 2015 21:01:45 -0800	[thread overview]
Message-ID: <54F7E339.50902@broadcom.com> (raw)
In-Reply-To: <54F742CA.7080500@broadcom.com>

Hi Linus,

>>> +#include <linux/kernel.h>
>>> +#include <linux/slab.h>
>>> +#include <linux/module.h>
>>> +#include <linux/interrupt.h>
>>> +#include <linux/io.h>
>>> +#include <linux/gpio.h>
>>
>> This should be:
>> #include <linux/gpio/driver.h>

In fact, just by trying it out I found I need linux/gpio.h for APIs like
gpiochip_add_pin_range, and etc.

>>
>>
> 
> Great! I will address all comments and re-send a BIG patch series with
> the other pinctrl patch series consolidated.
> 
> Thanks!
> 
> Ray
> 

I've consolidated this patch series with the IOMUX and sent out a
combined patch series earlier. I believe all other comments have been
addressed except the above include header one.

Thanks,

Ray

  reply	other threads:[~2015-03-05  5:01 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-02-10 22:16 [PATCH v9 0/4] Add gpio/pinconf support to Broadcom Cygnus SoC Ray Jui
2015-02-10 22:16 ` [PATCH v9 1/4] pinctrl: Cygnus: define Broadcom Cygnus GPIO/PINCONF binding Ray Jui
2015-02-10 22:16 ` [PATCH v9 2/4] pinctrl: cygnus: add gpio/pinconf driver Ray Jui
2015-03-04  9:48   ` Linus Walleij
2015-03-04 17:37     ` Ray Jui
2015-03-05  5:01       ` Ray Jui [this message]
2015-02-10 22:16 ` [PATCH v9 3/4] ARM: dts: enable GPIO for Broadcom Cygnus Ray Jui
2015-02-10 22:16 ` [PATCH v9 4/4] ARM: dts: cygnus: enable GPIO based hook detection Ray Jui
2015-02-25 19:30 ` [PATCH v9 0/4] Add gpio/pinconf support to Broadcom Cygnus SoC Dmitry Torokhov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=54F7E339.50902@broadcom.com \
    --to=rjui@broadcom.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).