From: Chunfeng Yun <chunfeng.yun@mediatek.com>
To: Wan Jiabing <wanjiabing@vivo.com>,
Kishon Vijay Abraham I <kishon@ti.com>,
Vinod Koul <vkoul@kernel.org>,
Matthias Brugger <matthias.bgg@gmail.com>,
<linux-arm-kernel@lists.infradead.org>,
<linux-mediatek@lists.infradead.org>,
<linux-phy@lists.infradead.org>, <linux-kernel@vger.kernel.org>
Cc: <jiabing.wan@qq.com>
Subject: Re: [PATCH] phy: phy-mtk-tphy: Fix dumplicated argument in phy-mtk-tphy
Date: Fri, 7 Jan 2022 13:31:52 +0800 [thread overview]
Message-ID: <54af6850e07aba2ca8002e344be86498c810067d.camel@mediatek.com> (raw)
In-Reply-To: <20220107025050.787720-1-wanjiabing@vivo.com>
On Fri, 2022-01-07 at 10:50 +0800, Wan Jiabing wrote:
> Fix following coccicheck warning:
> ./drivers/phy/mediatek/phy-mtk-tphy.c:994:6-29: duplicated argument
> to && or ||
>
> The efuse_rx_imp is duplicate. Here should be efuse_tx_imp.
>
> Signed-off-by: Wan Jiabing <wanjiabing@vivo.com>
> ---
> drivers/phy/mediatek/phy-mtk-tphy.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/phy/mediatek/phy-mtk-tphy.c
> b/drivers/phy/mediatek/phy-mtk-tphy.c
> index 6d307102f4f6..8ee7682b8e93 100644
> --- a/drivers/phy/mediatek/phy-mtk-tphy.c
> +++ b/drivers/phy/mediatek/phy-mtk-tphy.c
> @@ -992,7 +992,7 @@ static int phy_efuse_get(struct mtk_tphy *tphy,
> struct mtk_phy_instance *instanc
> /* no efuse, ignore it */
> if (!instance->efuse_intr &&
> !instance->efuse_rx_imp &&
> - !instance->efuse_rx_imp) {
> + !instance->efuse_tx_imp) {
> dev_warn(dev, "no u3 intr efuse, but dts enable
> it\n");
> instance->efuse_sw_en = 0;
> break;
Acked-by: Chunfeng Yun <chunfeng.yun@mediatek.com>
Thanks a lot
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2022-01-07 5:46 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-07 2:50 [PATCH] phy: phy-mtk-tphy: Fix dumplicated argument in phy-mtk-tphy Wan Jiabing
2022-01-07 5:31 ` Chunfeng Yun [this message]
2022-01-27 6:42 ` Vinod Koul
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54af6850e07aba2ca8002e344be86498c810067d.camel@mediatek.com \
--to=chunfeng.yun@mediatek.com \
--cc=jiabing.wan@qq.com \
--cc=kishon@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-phy@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=vkoul@kernel.org \
--cc=wanjiabing@vivo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox