From: Krzysztof Kozlowski <krzk@kernel.org>
To: Liang He <windhl@126.com>, tony@atomide.com, linux@armlinux.org.uk
Cc: linux-arm-kernel@lists.infradead.org, linux-omap@vger.kernel.org
Subject: Re: [PATCH v2] arm/mach-omap2: Fix refcount leak bugs
Date: Wed, 22 Jun 2022 10:53:33 +0200 [thread overview]
Message-ID: <54ba0e78-ad1a-af2b-74de-5db77a022602@kernel.org> (raw)
In-Reply-To: <20220620155421.4076532-1-windhl@126.com>
On 20/06/2022 17:54, Liang He wrote:
> We need to add of_node_put() to keep refcount balance for of_find_xxx()
> which will return a node pointer with refcount incremented.
>
> Signed-off-by: Liang He <windhl@126.com>
> ---
> changelog:
>
> v2:(1) we find several new leak bugs
> (2) we merge all mach-omap2 related bugs in to one commit
>
> v1: we send a patch for each missing of_node_put bug
>
>
>
> arch/arm/mach-omap2/display.c | 1 +
> arch/arm/mach-omap2/omap4-common.c | 1 +
> arch/arm/mach-omap2/omap_hwmod.c | 6 ++++++
> arch/arm/mach-omap2/pdata-quirks.c | 2 ++
> 4 files changed, 10 insertions(+)
Before applying the patch please check it carefully. Previous evidence
[1] suggests that not it was not even compiled.
[1] https://lore.kernel.org/all/202206221602.odN70SHs-lkp@intel.com/
Best regards,
Krzysztof
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2022-06-22 8:54 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-20 15:54 [PATCH v2] arm/mach-omap2: Fix refcount leak bugs Liang He
2022-06-22 8:53 ` Krzysztof Kozlowski [this message]
2022-06-28 4:05 ` Tony Lindgren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54ba0e78-ad1a-af2b-74de-5db77a022602@kernel.org \
--to=krzk@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=tony@atomide.com \
--cc=windhl@126.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).