From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 1FF01C3DA4A for ; Mon, 29 Jul 2024 23:02:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Date:To:Cc:From:Subject: References:In-Reply-To:Content-Transfer-Encoding:MIME-Version:Content-Type: Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=yzCurV82av03unBcoGcG74J4yRdeDooIgc+oa3Rp/6E=; b=ECyyBWwGpiTY4ZRS8M4n7BY9VB hXQxmL1GleU2BekSgWvX3PWjWeEthhATXF6tcGsGlkqfWUHHdHrXfScPPmSDl8WaxfFxAQyxHwlp9 E88m69bN7J8kGJ/TxvhHAMOueyXf+qhRyyQiGKDYOVMgaKxYk5v1r9xDlcu7Fe0HzzttXSRYZy/uX eZCiEjzzuk3chrIrLGNxkFUeIkljsYhap8Xjqa/Ex/hVGc6yGuAjl/MhfWAekEhsDH0Gz0LojbRm5 3+y4u/7J455Y5EzD77LebsEMoJK+JDjQlfEjnl2N/gBPVK2viHhhFl+45bJTZFSAIuiouQiax1Cdg N8iP/uhA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sYZNY-0000000Cxxu-3Fis; Mon, 29 Jul 2024 23:02:08 +0000 Received: from sin.source.kernel.org ([2604:1380:40e1:4800::1]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sYZN6-0000000Cxtv-31si; Mon, 29 Jul 2024 23:01:42 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id 58C04CE0917; Mon, 29 Jul 2024 23:01:38 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8F9D5C32786; Mon, 29 Jul 2024 23:01:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1722294097; bh=yzCurV82av03unBcoGcG74J4yRdeDooIgc+oa3Rp/6E=; h=In-Reply-To:References:Subject:From:Cc:To:Date:From; b=GQe0VNE5g9ObKIB9IOMY41A6xtRZj967Ka7jdBOBClsfNIetnnHsndBKrgnqNvWKD CgcfPxKm8VJ5WZMopnKqYQQNKL0Lky+yqRDTWekQkHU7ln47ANz/GxuWtBdLab4ugZ w1EE/pNvN80QOdXeAgnV5Kk7M54s6ScmkgQfB/Y/iHX5aJ8oazglvkixXiGvN7Li3i cRcD3/SCArnkpl9A5qMIXUJI7e6WFAzSueH3WJ+YZlvrHsI82vGIxxzo8USqmtZI5C IuX3L4AnN58jh3X/bPJ6LlUcsDECdQQrFnpsWudlDvA6UXyrHub83VoMWnEryJOPRe yqYmhFkB85Lpg== Message-ID: <54decfcc0a311d4447122bb5f49bd491.sboyd@kernel.org> Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable In-Reply-To: <20240717115919.975474-1-fshao@chromium.org> References: <20240717115919.975474-1-fshao@chromium.org> Subject: Re: [PATCH] clk: mediatek: reset: Return regmap's error code From: Stephen Boyd Cc: Fei Shao , Matthias Brugger , Michael Turquette , linux-arm-kernel@lists.infradead.org, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org To: AngeloGioacchino Del Regno , Fei Shao Date: Mon, 29 Jul 2024 16:01:35 -0700 User-Agent: alot/0.10 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240729_160140_955722_68A19482 X-CRM114-Status: UNSURE ( 6.68 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Quoting Fei Shao (2024-07-17 04:58:52) > device_node_to_regmap() can return different errors, and it's better > practice to pass them to callers. >=20 > Clean up the hardcoded -EINVAL and use PTR_ERR(regmap) instead. >=20 > Signed-off-by: Fei Shao > --- Applied to clk-next