From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 6FD02C43334 for ; Fri, 17 Jun 2022 07:47:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Aah10BcQfoA4S16tUFXFLsNKYJbneJyRJTd5txX8eNQ=; b=EsCYw3+dnTqeta DsqzRhRfd8uk1ddc0kEkpugYuThhtcqQ7ALStSIaMcmwqBsgJPHAufdbYi5YDc2kak2Htb2RO3oEM zC5MalmDYPRHX8tAN+ls/gzUoGiD6s+sq4L9pnfHUyPFoJed1Z1fcOnrBE0gwfi/vHD4AQwfeM1YH VHO0KnYxsXkdco8pgzpUDrqhUAZuYNT67ZO//aLG10zP/HT3WI9jWBMVwDtF6jMDOJ2KbTjzCUN2i 15jhDW3TnDSNk1/iYFeQFy8JCKZk35nZKyJyd5S01D3r26Hdo/deGZIntWRNHKzzQoA8eR3FmGBF5 eWe45TcEof2rTzdD2mPw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1o26ft-0064cq-Cy; Fri, 17 Jun 2022 07:45:50 +0000 Received: from mail-ej1-x62b.google.com ([2a00:1450:4864:20::62b]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1o26Rq-005yVg-PS for linux-arm-kernel@lists.infradead.org; Fri, 17 Jun 2022 07:31:21 +0000 Received: by mail-ej1-x62b.google.com with SMTP id fu3so7134173ejc.7 for ; Fri, 17 Jun 2022 00:31:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20210112.gappssmtp.com; s=20210112; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:organization:in-reply-to :content-transfer-encoding; bh=dCV6qGUI7Cqg9TdhqvU2+ai6zKfvgQ0lGjyyVFexPIU=; b=HE7KhYE/xjUlakk27H3lZOjL19q7HyTLJa+vdphCgSnuB+czh4rVByLN78Sj1p+5RQ 4V8QTQUKTVuiHbxXI2U9QY6RCMYc0SE9qc/8DjOd/RNJh2EeSlQIZvmH4UDYmfpClkrl zxOLypIgJzz2CVNok1B3vytvYEoiM+c6yd8QgJaLgL1RGKl6H42d3EGhsIT3QQxedVBT /pDJN8p2MXO2g+YjtQasXNEcF/50BTHOazd2Wsicgek5gQPmLhMx5YXmrqLEyhjT3D/o 4Ws/cOypVK2Z5sotjuPIYRetuiLUSlLrH1Bu6fBSYPxTzUKdoVRUC2jHVFl2RKH8szvS Zn1A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:organization:in-reply-to :content-transfer-encoding; bh=dCV6qGUI7Cqg9TdhqvU2+ai6zKfvgQ0lGjyyVFexPIU=; b=NJjT4NSJGW74ouTeQnoWnJGAvfReGFQ0rjwvj4UQTn9o0CTBqt069IRhWJF99IudAJ P16qVb4hrb7HKGcXBpcPD8pJlo0qcHcRaAXJoZAikPgUnGVG5uEe+s0iY2pmA+Lj0u+D xLK8AzB5rlS2KGguvoJWVfROCfsGrrhoxZIQ4C2v+cKqTVt0QXR5ybOplb1S7r+s+AZh 0MDuP/KHDK3vz3OouPcpXB+3JknP/mYD6XGouvYlZPQsirrojs83Ng5m7WuFekAnYnSt gp1yNQFa2atqavwLctczm1TtGDtbHk0wZ7jODiwZ4WwJgXOFrgq+7FddQk84aWcSb763 HOBw== X-Gm-Message-State: AJIora8jIRgh6FO9Ixt3ViPiTikxd9CLH+SG2FWhBA3ecoJvjRTymvy/ EYTfm0yUAHONEOJxT8bPy+rxECc3ZH64GQ== X-Google-Smtp-Source: AGRyM1tZZKYyQmjR0eXxMRCwbJxX3hwGRDzNXhGufI0x/0CPupOmdiMHa8oj4351VL2iQ1h3Z8vNQg== X-Received: by 2002:a17:906:74cc:b0:712:381:9c5a with SMTP id z12-20020a17090674cc00b0071203819c5amr7885326ejl.466.1655451076601; Fri, 17 Jun 2022 00:31:16 -0700 (PDT) Received: from ?IPV6:2001:861:44c0:66c0:d227:8f3c:286a:d9d8? ([2001:861:44c0:66c0:d227:8f3c:286a:d9d8]) by smtp.gmail.com with ESMTPSA id 7-20020a170906300700b00702d8b37a03sm1852519ejz.17.2022.06.17.00.31.14 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 17 Jun 2022 00:31:16 -0700 (PDT) Message-ID: <54e1434d-e517-9283-3078-7f042c04385b@baylibre.com> Date: Fri, 17 Jun 2022 09:31:13 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.8.1 Subject: Re: [PATCH] soc: amlogic: Fix refcount leak in meson-secure-pwrc.c Content-Language: en-US To: Liang He , khilman@baylibre.com, jbrunet@baylibre.com, martin.blumenstingl@googlemail.com Cc: linux-arm-kernel@lists.infradead.org, linux-amlogic@lists.infradead.org, linux-kernel@vger.kernel.org References: <20220616144915.3988071-1-windhl@126.com> From: Neil Armstrong Organization: Baylibre In-Reply-To: <20220616144915.3988071-1-windhl@126.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220617_003118_966076_1C32F91E X-CRM114-Status: GOOD ( 15.69 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 16/06/2022 16:49, Liang He wrote: > In meson_secure_pwrc_probe(), there is a refcount leak in one fail > path. > > Signed-off-by: Liang He Fixes: b3dde5013e13 ("soc: amlogic: Add support for Secure power domains controller") > --- > drivers/soc/amlogic/meson-secure-pwrc.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/drivers/soc/amlogic/meson-secure-pwrc.c b/drivers/soc/amlogic/meson-secure-pwrc.c > index a10a417a87db..e93518763526 100644 > --- a/drivers/soc/amlogic/meson-secure-pwrc.c > +++ b/drivers/soc/amlogic/meson-secure-pwrc.c > @@ -152,8 +152,10 @@ static int meson_secure_pwrc_probe(struct platform_device *pdev) > } > > pwrc = devm_kzalloc(&pdev->dev, sizeof(*pwrc), GFP_KERNEL); > - if (!pwrc) > + if (!pwrc) { > + of_node_put(sm_np); > return -ENOMEM; > + } > > pwrc->fw = meson_sm_get(sm_np); > of_node_put(sm_np); Reviewed-by: Neil Armstrong _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel