From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 710D1C004D4 for ; Thu, 19 Jan 2023 13:14:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Date:Cc:To:From:Subject:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=7aBHKbkncUC+2KZe8+0Uo7k9mrC//9RMU7ip+lRzxMk=; b=N8zOJDj3nIzSZZ kaRz6q/VYf2thua8BRXRKRJbQN5rixvKhMnwITMUESV2Unv+XGWFDQIMvfjtHZBT7LvNIqA39/m5v AitucbNG55fj2CdcQQOhpbxwrALEZIj4ca3/XC2yOicYenhHvEkHncLjy+184Mazbsu+BGGthHazj tzVW842jCBN7WcOxcD3tOprvAmhDe0ezNdmKT5+ZQLb0qrSRBl/Pe1uupYCuJyIk8/4THQkfrHuE1 Qorfx2nq4xnFiWBrl8l8XkvrBjbHVRA639zNaROKdwmSsfEQu+apfOjZYLq9l/ZwrLz1CUWILLU++ 2P/Q8o61xxRXru8p53QQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pIUjS-0051p1-GR; Thu, 19 Jan 2023 13:13:31 +0000 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pIUck-004z4w-7I for linux-arm-kernel@lists.infradead.org; Thu, 19 Jan 2023 13:06:35 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1674133593; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=HW7PiQ7kMTbEHz3RhIojDWZpyWGPhynbWDqOrHjDTH0=; b=LulVaDoWL0aBb3KtA4gFR3QnapdJTckUxNbIRiI4rLB1mWOBO9nM0trVhJXFWwK/Wyew48 WkDZGAqK3a6+qBK4cs9GY9vF2GIwEFTW35hH+taTnAQbg7oAh9KjGMg/kb8OLw+MxOQezI Y90z9QRRxVS2SpUaOYRKyibs8JQo69k= Received: from mail-yw1-f200.google.com (mail-yw1-f200.google.com [209.85.128.200]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-44-wUlghH14O3moKhIKzqwgLw-1; Thu, 19 Jan 2023 08:06:31 -0500 X-MC-Unique: wUlghH14O3moKhIKzqwgLw-1 Received: by mail-yw1-f200.google.com with SMTP id 00721157ae682-4dd4d4591f7so18252447b3.15 for ; Thu, 19 Jan 2023 05:06:31 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=NllK0azs34zQlNRKoqTNyUNwLOsJ8tnB4tNC7+7ktic=; b=h39ZXVn7WiHtxRCsdGZIon23yNOPxvrE9AUqZ5e1x1nG08xb5gSuBirZltlhpAnmZq T98KNZs1mH5lwEwdBc3paLIlSZmBmN07cRsAV/lFXEbR73T6cwIj0pJH2wN2pHvlzUEB roKi1YQWjdKV033+7GU1uhuhe7iiyfTM437Z11+NEaVo92arSWBtOTbW6Ee/pCQQJt7L Xj6zKaYCNhOXmRq/RrVBIZX4qCyY4Fr5m8NhDRdaAYfTJ9Fg7WmFN0y/mGpLnTKH8buE DHIEExlY8/6XfTxo5E99dvmDIw4AcQiM5zsN5k8aRbtMEuBAiZS0rajDEcKIu1zEtOKD g4ow== X-Gm-Message-State: AFqh2kpLH3bYJ0qgqReXIz1GjY4SjB1+oRtMiCUDcY10ncShwv04G0rT egUCalKf53tYvaUz7XK/Br2mD+Rq5mfukzdgTcrF5IcLLHY5ixxIIuKi0e0HmFyp6E/wlx/PCjx jEHzs8pdYaP++/hVQR0g+rPJMEO2+anwOTNo= X-Received: by 2002:a05:7500:631c:b0:f1:e53f:ed8f with SMTP id ib28-20020a057500631c00b000f1e53fed8fmr942645gab.6.1674133591288; Thu, 19 Jan 2023 05:06:31 -0800 (PST) X-Google-Smtp-Source: AMrXdXtqVdyMFGGKllOmHx/VXgChvv179iGQmaX6P7Z+RaxG6XipFX0sosGMobhJcbX7oss70Pr0IA== X-Received: by 2002:a05:7500:631c:b0:f1:e53f:ed8f with SMTP id ib28-20020a057500631c00b000f1e53fed8fmr942613gab.6.1674133590893; Thu, 19 Jan 2023 05:06:30 -0800 (PST) Received: from gerbillo.redhat.com (146-241-124-97.dyn.eolo.it. [146.241.124.97]) by smtp.gmail.com with ESMTPSA id m3-20020a05620a24c300b007055dce4cecsm265017qkn.97.2023.01.19.05.06.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 19 Jan 2023 05:06:30 -0800 (PST) Message-ID: <54ebe3efac89c68db30658e82b1ba1a7355d4456.camel@redhat.com> Subject: Re: [PATCH net-next v3 2/2] net: ethernet: ti: am65-cpsw/cpts: Fix CPTS release action From: Paolo Abeni To: Siddharth Vadapalli , davem@davemloft.net, edumazet@google.com, kuba@kernel.org, linux@armlinux.org.uk, rogerq@kernel.org, leon@kernel.org Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, vigneshr@ti.com, srk@ti.com Date: Thu, 19 Jan 2023 14:06:26 +0100 In-Reply-To: <20230118095439.114222-3-s-vadapalli@ti.com> References: <20230118095439.114222-1-s-vadapalli@ti.com> <20230118095439.114222-3-s-vadapalli@ti.com> User-Agent: Evolution 3.46.3 (3.46.3-1.fc37) MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230119_050634_377143_B3AF9E4F X-CRM114-Status: UNSURE ( 9.82 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi, On Wed, 2023-01-18 at 15:24 +0530, Siddharth Vadapalli wrote: > @@ -1014,18 +1013,12 @@ struct am65_cpts *am65_cpts_create(struct device *dev, void __iomem *regs, > } > cpts->phc_index = ptp_clock_index(cpts->ptp_clock); > > - ret = devm_add_action_or_reset(dev, am65_cpts_release, cpts); > - if (ret) { > - dev_err(dev, "failed to add ptpclk reset action %d", ret); > - return ERR_PTR(ret); > - } > - > ret = devm_request_threaded_irq(dev, cpts->irq, NULL, > am65_cpts_interrupt, > IRQF_ONESHOT, dev_name(dev), cpts); > if (ret < 0) { > dev_err(cpts->dev, "error attaching irq %d\n", ret); > - return ERR_PTR(ret); > + goto reset_ptpclk; > } > > dev_info(dev, "CPTS ver 0x%08x, freq:%u, add_val:%u\n", This chunk does not apply cleanly to current net-next (context is changed). Please rebase and re-spin (you can preserve/keep the already acquire reviewed-by tags) Thanks! Paolo _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel