From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 27E7CC27C4F for ; Sat, 29 Jun 2024 16:22:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:Message-ID:References:In-Reply-To:Subject:Cc:To:From:Date: MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=TmaryQAjzocqFJcJHYAJO/SJgA2TIwOO9948WPpEdHc=; b=UZHNwBnyD8pjQzkcn5gW0qe36F IeHzdwqb2BLOxL/C1IIYDELHnPaA7b1dzr4WXH/Ft0qZQk9pTTeuhCxnN8Wy+JXSdJIldNziLilpf wUp/1rlp1EB2IALtcPyaYJlXk/a5L8QNhXVm58JlyTO7zwM0RqdRkAAfX476y4wjNmZ3NSj6DW2Z0 PBFNgktE9mH9kWkg9+d6+iYLnfzn+BLQF5b+5LQck4ozzPbjtBvU0Swu1tuAQyLJTitpZJehnX5dn fT33O7/MAKia09999KmwBBp2eQz2sBZmMQVKGqrecgJf66vfvB8j/fv4t2bPVFDs9Qbef2qLs2Vex xb1RrY7w==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sNaqI-0000000GdtX-1iQG; Sat, 29 Jun 2024 16:22:26 +0000 Received: from mail.manjaro.org ([116.203.91.91]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sNaq8-0000000Gdsh-43Ys; Sat, 29 Jun 2024 16:22:18 +0000 MIME-Version: 1.0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=manjaro.org; s=2021; t=1719678135; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=TmaryQAjzocqFJcJHYAJO/SJgA2TIwOO9948WPpEdHc=; b=HwN6sE32jvPYG7rQ4QHo7m9ULaSOYx/0hzY2zZA1SKUQOfRU+eR004fjq+qHMiZlE9+xdn ivu6tuHroDFe+E+gr6Z6CRWe4JG7GabOb7HYj6mrmX5HA4pPM2toLv3JF6tJjrHneOl/up ca7erP5jBUmGpWKuj+jVbMdzByP0Ze+ZpuUJFKVnHh9CK21Azo9prIho17Rb0mK1/RheXA frM1NKbb4opoSgnylYpHINeeaK6X6Lt8JX7gFa526Tb44wY/rilcRAem/jXJLKGlKzbg9d 730b/VsTiM/Yqxs9KzUwrAXAJjyEGkAUThXGuqaIgtY9M2mvoHkMkcQK2eMucg== Date: Sat, 29 Jun 2024 18:22:14 +0200 From: Dragan Simic To: =?UTF-8?Q?Heiko_St=C3=BCbner?= Cc: linux-rockchip@lists.infradead.org, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, linux-kernel@vger.kernel.org, Diederik de Haas , Jonas Karlman Subject: Re: [PATCH] arm64: dts: rockchip: Add optional GPU OPP voltage ranges to RK356x SoC dtsi In-Reply-To: <9297854.CDJkKcVGEf@diego> References: <446399362bd2dbeeaecd8351f68811165429749a.1719637113.git.dsimic@manjaro.org> <36170f8485293b336106e92346478daa@manjaro.org> <9297854.CDJkKcVGEf@diego> Message-ID: <54fc7e18a6498d15e008733864f26070@manjaro.org> X-Sender: dsimic@manjaro.org Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Authentication-Results: ORIGINATING; auth=pass smtp.auth=dsimic@manjaro.org smtp.mailfrom=dsimic@manjaro.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240629_092217_176010_B154B569 X-CRM114-Status: GOOD ( 21.27 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 2024-06-29 18:18, Heiko Stübner wrote: > Am Samstag, 29. Juni 2024, 17:39:34 CEST schrieb Dragan Simic: >> On 2024-06-29 17:25, Dragan Simic wrote: >> > On 2024-06-29 17:10, Heiko Stübner wrote: >> >> Am Samstag, 29. Juni 2024, 07:11:24 CEST schrieb Dragan Simic: >> >> >> >>> +#ifndef RK356X_GPU_NPU_SHARED_REGULATOR >> >> >> >> is there some reason for this duplicating of opps? >> >> >> >> The regulator framework should pick the lowest supported voltage >> >> anyway, so it seems you're just extending them upwards a bit. >> >> >> >> So I really don't so why we'd need to sets here. >> > >> > The reason is improved strictness. Having the exact GPU OPP voltages >> > required for the boards whose GPU regulators can provide those exact >> > voltages makes it possible to detect misconfigurations much easier, >> > just like it was the case with the board dts misconfiguration that >> > resulted in the recent DCDC_REG2 patch. [1] >> > >> > If we had GPU OPP voltage ranges in place instead, the aforementioned >> > issue would probably remain undetected for some time. It wouldn't be >> > the end of the world, :) of course, but the resulting increased power >> > consumption isn't one of the desired outcomes. >> > >> > [1] >> > https://lore.kernel.org/linux-rockchip/e70742ea2df432bf57b3f7de542d81ca22b0da2f.1716225483.git.dsimic@manjaro.org/ >> >> On second thought, after seeing that the RK3399 CPU and GPU OPPs >> already specify voltage ranges, I think it would be better to drop >> the distinction between the separate strict voltages and the voltage >> ranges in this patch, > > yes, that was what I was trying to say :-) > > Also it makes the OPPs less cluttered. Also dt is firmware, I do expect > people to be reasonably knowledgeable if they mess around with their > boards OPPs ;-) . Yes, but we still need new regulator/OPP debugging facilities that should to be used while writing DTs for new boards and while verifying already existing board DTs. :) I'll prepare and send the v2 of this patch, and I'll also start working on the new patch for those debugging facilities.