From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id EFA5FCD37B4 for ; Sun, 17 Sep 2023 07:35:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=8pvdGV6uFLA2E4ZeAl0pGW4FTMhW5WbQwf/PCY8zIK8=; b=h5sj1eelZfsNPU 5fRWbuXKXGiJrDyhtDSmuZq740nunWCs/ef2aW0PlRWGDWDveLLsSvJ8W7z7WVUpXAtAziv7nHI2e W2fe/Y/kAfGmfRTslkLVKikogIxtj57eK+7kllaKJlrK9cozTPOM7mhJM8ahyMcG26g+u7xSygClz Gl68BbPvZ9IlaD6sskKr/iVJgqpMGQ+Aksbp7fI3VGCCJmGaZAwA8u09AorUl4foXaZycRh2KmBbT Q9SqZM0m7YSEb+MxM8opokPYP9PscASUkHkO+s+0DY6IWHAtwU1EyAJrCEby8XX+x7UG6F2A5rg1d xtukN5/ZaSBKPdfL5k7Q==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qhmJW-00DGvJ-2o; Sun, 17 Sep 2023 07:35:30 +0000 Received: from mail-ej1-x629.google.com ([2a00:1450:4864:20::629]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qhmJT-00DGuw-0a for linux-arm-kernel@lists.infradead.org; Sun, 17 Sep 2023 07:35:29 +0000 Received: by mail-ej1-x629.google.com with SMTP id a640c23a62f3a-99bf3f59905so457680766b.3 for ; Sun, 17 Sep 2023 00:35:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1694936124; x=1695540924; darn=lists.infradead.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=GVg4iMqyFo6GXp2VZ+N/pcY2Y8g5Wn2f/zmdGd2t3MI=; b=drBEjNJDV2Ii5zC7u3cRF9GamED0SeRGKiM3IyXojsE3Mh0FssAzK6jVxPjx20FnuB rAd3q9iUEmzENnPK+QGnTDqtxXNTTkroWHgmBe73inyA1zKTv6aHeVwUWgFE+h1XNhez AIx9HoUhORahk5RPh2t7DjcQ/FbJDYNiUtCdyONOWsX5qIyY8hd1y1xNniOGIYS3QlJ0 DtqGbwzpsUjDocC1Lso9p0rfHQJDEV5l3aGAVZlRPULuXRnvXtPsNuie3J578aC4hgIT JydlF21j1ljSn1X169SIMZENEi6XctPxfoktO2AkGkKtXu3nGBWwUqv843rF4CHZwaCd MUcg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1694936124; x=1695540924; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=GVg4iMqyFo6GXp2VZ+N/pcY2Y8g5Wn2f/zmdGd2t3MI=; b=U30pktJ7WdYtdpbEPzYwOPKgZ8I0sWyoTimSihKsfT/vb5fhEnU3ZCNv91E83bDV6p ZKVMrdFACIwRZNQjc6b1wub44FSykcud4iOvgtoS1hgk73UVNNX1Z3+wpFj8NuVubR2S 1x202vi+buEQxjVtc0qEfAbh2u9n8jFNJg5hOkl5Y17z85U6noFtqPEd/wYrlFPGqiVG NSZ0AUOiTkJG5E6qRrssIhLabJndqRnnOlWmfWOqCinG7K6D950mWwmzHhKHEgOWwEJZ LPcpADuCnAzQ6ZjNoX7o2Ph2k9NmH3C8l9+n4LhpAQcLjybI8cWFFAg6VyiknsH+sLax pqVA== X-Gm-Message-State: AOJu0Yz/I7kdMUeLaFuh37TfJaqLLRgrtdjSykF+gN1h56psYrrJn0Rr OSmLtc7i1qmKaqyEOE2Z3Akmcg== X-Google-Smtp-Source: AGHT+IHV9X9GTjPS8Rpcs9R2kxN8xI/rL5gF7b1VuZpWiQozu9bvvyJUcivpO+mDfPfyOicv9EQkxw== X-Received: by 2002:a17:907:775a:b0:9a2:16e2:353 with SMTP id kx26-20020a170907775a00b009a216e20353mr5651059ejc.6.1694936124406; Sun, 17 Sep 2023 00:35:24 -0700 (PDT) Received: from [192.168.1.77] (150-140-187-31.ftth.glasoperator.nl. [31.187.140.150]) by smtp.gmail.com with ESMTPSA id r20-20020a170906365400b0099bd1a78ef5sm4640735ejb.74.2023.09.17.00.35.22 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 17 Sep 2023 00:35:23 -0700 (PDT) Message-ID: <54fcf0c2-c8e2-6ee8-5f6c-4de914c56c19@linaro.org> Date: Sun, 17 Sep 2023 09:35:17 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.15.0 Subject: Re: [PATCH v2 8/8] arm64: defconfig: enable interconnect and pinctrl for SM4450 To: Georgi Djakov , Trilok Soni , Tengfei Fan , will@kernel.org, robin.murphy@arm.com, joro@8bytes.org, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org, agross@kernel.org, andersson@kernel.org, konrad.dybcio@linaro.org, catalin.marinas@arm.com Cc: geert+renesas@glider.be, arnd@arndb.de, neil.armstrong@linaro.org, nfraprado@collabora.com, rafal@milecki.pl, peng.fan@nxp.com, linux-arm-kernel@lists.infradead.org, iommu@lists.linux.dev, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, quic_shashim@quicinc.com, quic_kaushalk@quicinc.com, quic_tdas@quicinc.com, quic_tingweiz@quicinc.com, quic_aiquny@quicinc.com, kernel@quicinc.com References: <20230915021509.25773-1-quic_tengfan@quicinc.com> <20230915021509.25773-10-quic_tengfan@quicinc.com> <8f2c9664-a2c8-50dc-8a1c-e50a071ebeb2@linaro.org> <0a34dd35-7aea-4655-4cdd-e7196a1ba52b@linaro.org> <01c020ae-a019-e4eb-14cb-64503bde05a6@quicinc.com> <212f9bfa-6d4c-bba2-60d2-272c001a4322@quicinc.com> Content-Language: en-US From: Krzysztof Kozlowski In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230917_003527_283991_5251CDD0 X-CRM114-Status: GOOD ( 19.66 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 17/09/2023 00:55, Georgi Djakov wrote: > Hi Krzysztof, > > On 16.09.23 23:32, Krzysztof Kozlowski wrote: >> On 16/09/2023 17:13, Georgi Djakov wrote: >>> >>>> >>>> Complete list here, and it is inconsistent. Latest 8550 is also =y. Do we document >>>> the reasons somewhere on why they are added as =y? >>>> >>>> CONFIG_INTERCONNECT_QCOM=y >>>> CONFIG_INTERCONNECT_QCOM_MSM8916=m >>>> CONFIG_INTERCONNECT_QCOM_MSM8996=m >>>> CONFIG_INTERCONNECT_QCOM_OSM_L3=m >>>> CONFIG_INTERCONNECT_QCOM_QCM2290=m >>>> CONFIG_INTERCONNECT_QCOM_QCS404=m >>>> CONFIG_INTERCONNECT_QCOM_SA8775P=y >>>> CONFIG_INTERCONNECT_QCOM_SC7180=y >>>> CONFIG_INTERCONNECT_QCOM_SC7280=y >>>> CONFIG_INTERCONNECT_QCOM_SC8180X=y >>>> CONFIG_INTERCONNECT_QCOM_SC8280XP=y >>>> CONFIG_INTERCONNECT_QCOM_SDM845=y >>>> CONFIG_INTERCONNECT_QCOM_SM8150=m >>>> CONFIG_INTERCONNECT_QCOM_SM8250=m >>>> CONFIG_INTERCONNECT_QCOM_SM8350=m >>>> CONFIG_INTERCONNECT_QCOM_SM8450=y >>>> CONFIG_INTERCONNECT_QCOM_SM8550=y >>> >>> If the device can boot (to console/initramfs) with =m, we go with that. >>> But if something critical like the UART depends on the interconnect >>> provider, then we make it built-in. >>> >>> On SM8550 for example, we have enabled bandwidth scaling support for QUP >>> and that's why it needs to be =y. >>> >>> It looks like on SM4450 this should be =y too. >> >> I asked why SM4450 has to be =y and there was no answer. The argument >> that SM8450 is a module, is not applicable. > > From the hardware description i see in patch 7, the serial engine depends > on some interconnect provider. But as the serial console driver is only > available as built-in, the interconnect provider also needs be built-in > for the UART device to probe and register the console. > > So the answer to your question should be that this is needed by the UART > device (at least). > > Such details of course deserve to be mentioned in the commit message of > this patch. If you mean here the debug UART with console, then it is the same valid reason as in my change for others. This should be mentioned in commit msg. Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel