From mboxrd@z Thu Jan 1 00:00:00 1970 From: nicolas.ferre@atmel.com (Nicolas Ferre) Date: Wed, 11 Mar 2015 13:48:34 +0100 Subject: [PATCH] backlight: pwm: handle EPROBE_DEFER while requesting the PWM In-Reply-To: <1424338214-24236-1-git-send-email-nicolas.ferre@atmel.com> References: <1424338214-24236-1-git-send-email-nicolas.ferre@atmel.com> Message-ID: <550039A2.9010307@atmel.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Le 19/02/2015 10:30, Nicolas Ferre a ?crit : > When trying to request the PWM device with devm_pwm_get(), the EPROBE_DEFER > flag is not handled properly. It can lead to the PWM not being found. > > Signed-off-by: Boris Brezillon > Signed-off-by: Nicolas Ferre Any comment on this patch? Can we see it included during next cycle (4.1)? (aka ping). Bye, > --- > drivers/video/backlight/pwm_bl.c | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/drivers/video/backlight/pwm_bl.c b/drivers/video/backlight/pwm_bl.c > index 3a145a643e0d..6897f1c1bc73 100644 > --- a/drivers/video/backlight/pwm_bl.c > +++ b/drivers/video/backlight/pwm_bl.c > @@ -274,6 +274,10 @@ static int pwm_backlight_probe(struct platform_device *pdev) > > pb->pwm = devm_pwm_get(&pdev->dev, NULL); > if (IS_ERR(pb->pwm)) { > + ret = PTR_ERR(pb->pwm); > + if (ret == -EPROBE_DEFER) > + goto err_alloc; > + > dev_err(&pdev->dev, "unable to request PWM, trying legacy API\n"); > pb->legacy = true; > pb->pwm = pwm_request(data->pwm_id, "pwm-backlight"); > -- Nicolas Ferre