linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: santosh.shilimkar@oracle.com (santosh shilimkar)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: OMAP4: remove dead kconfig option OMAP4_ERRATA_I688
Date: Tue, 17 Mar 2015 09:26:31 -0700	[thread overview]
Message-ID: <550855B7.3020905@oracle.com> (raw)
In-Reply-To: <20150316233005.GA2598@atomide.com>



On 3/16/2015 4:30 PM, Tony Lindgren wrote:
> * Stefan Hengelein <stefan.hengelein@fau.de> [150225 10:48]:
>> The Kconfig-Option OMAP4_ERRATA_I688 is never visible due to a
>> contradiction in it's dependencies.
>> The option requires ARCH_MULTIPLATFORM to be 'disabled'. However, an
>> enclosing menu requires either ARCH_MULTI_V6 or ARCH_MULTI_V7 to be
>> enabled. These options inherit a dependency from an enclosing menu,
>> that requires ARCH_MULTIPLATFORM to be 'enabled'.
>> This is a contradiction and made this option also unavailable for
>> non-multiplatform configurations.
>>
>> Since there are no selects on OMAP4_ERRATA_I688, which would ignore
>> dependencies, the code related to that option is dead and can be
>> removed.
>>
>> This (logical) defect has been found with the undertaker tool.
>> (https://undertaker.cs.fau.de)
>>
>> Signed-off-by: Stefan Hengelein <stefan.hengelein@fau.de>
>>
>> ---
>> Tony Lindgren suggested to remove the code since nobody complained for
>> a few years and Santosh Shilimkar agreed.
>> https://lkml.org/lkml/2015/2/25/449
>> ---
>> As far as I see, this should remove all the code related to
>> OMAP4_ERRATA_I688, I hope I didn't remove too much.
>
> Seems to boot fine, so applying into omap-for-v4.1/fixes-not-urgent.
>
Acked-by: Santosh Shilimkar <ssantosh@kernel.org>

  reply	other threads:[~2015-03-17 16:26 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-02-25 18:44 [PATCH] ARM: OMAP4: remove dead kconfig option OMAP4_ERRATA_I688 Stefan Hengelein
2015-03-16 23:30 ` Tony Lindgren
2015-03-17 16:26   ` santosh shilimkar [this message]
2015-03-17 16:31     ` Nishanth Menon
2015-03-17 16:34       ` Tony Lindgren
2015-03-17 16:57         ` Nishanth Menon
2015-03-17 17:10           ` Tony Lindgren
2015-03-17 17:18             ` Nishanth Menon
2015-03-17 17:27               ` Tony Lindgren

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=550855B7.3020905@oracle.com \
    --to=santosh.shilimkar@oracle.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).