linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: hdegoede@redhat.com (Hans de Goede)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH RFC 2/3] ARM: sun7i: Add A20 SRAM and SRAM controller
Date: Wed, 18 Mar 2015 20:12:13 +0100	[thread overview]
Message-ID: <5509CE0D.7000904@redhat.com> (raw)
In-Reply-To: <1426166024-24922-3-git-send-email-maxime.ripard@free-electrons.com>

Hi,

On 12-03-15 14:13, Maxime Ripard wrote:
> The A20 has a few SRAM that can be mapped either to a device or to the CPU,
> with the mapping being controlled by an SRAM controller.
>
> Since most of the time these SRAM won't be accessible by the CPU, we can't use
> the mmio-sram driver and compatible.
>
> Signed-off-by: Maxime Ripard <maxime.ripard@free-electrons.com>
> ---
>   arch/arm/boot/dts/sun7i-a20.dtsi | 31 ++++++++++++++++++++++++++++++-
>   1 file changed, 30 insertions(+), 1 deletion(-)
>
> diff --git a/arch/arm/boot/dts/sun7i-a20.dtsi b/arch/arm/boot/dts/sun7i-a20.dtsi
> index a1ebd80e6f24..a249828a1df5 100644
> --- a/arch/arm/boot/dts/sun7i-a20.dtsi
> +++ b/arch/arm/boot/dts/sun7i-a20.dtsi
> @@ -522,12 +522,41 @@
>   		};
>   	};
>
> -	soc at 01c00000 {
> +	soc {

Please do not do this, this changes devicetree paths used by
u-boot, see:

http://git.denx.de/?p=u-boot.git;a=blob;f=include/configs/sunxi-common.h#l232

Other then that this sets looks good to me, I'm giving it a test-spin
now.

Regards,

Hans


>   		compatible = "simple-bus";
>   		#address-cells = <1>;
>   		#size-cells = <1>;
>   		ranges;
>
> +		sram at 00000000 {
> +			compatible = "allwinner,sun4i-a10-sram";
> +			reg = <0x00000000 0x4000>;
> +			allwinner,sram-name = "A1";
> +		};
> +
> +		sram at 00004000 {
> +			compatible = "allwinner,sun4i-a10-sram";
> +			reg = <0x00004000 0x4000>;
> +			allwinner,sram-name = "A2";
> +		};
> +
> +		sram at 00008000 {
> +			compatible = "allwinner,sun4i-a10-sram";
> +			reg = <0x00008000 0x4000>;
> +			allwinner,sram-name = "A3-A4";
> +		};
> +
> +		sram at 00010000 {
> +			compatible = "allwinner,sun4i-a10-sram";
> +			reg = <0x00010000 0x1000>;
> +			allwinner,sram-name = "D";
> +		};
> +
> +		sram-controller at 01c00000 {
> +			compatible = "allwinner,sun7i-a20-sram-controller";
> +			reg = <0x01c00000 0x30>;
> +		};
> +
>   		nmi_intc: interrupt-controller at 01c00030 {
>   			compatible = "allwinner,sun7i-a20-sc-nmi";
>   			interrupt-controller;
>

  reply	other threads:[~2015-03-18 19:12 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-03-12 13:13 [PATCH RFC 0/3] ARM: sunxi: SRAM mapping support Maxime Ripard
2015-03-12 13:13 ` [PATCH RFC 1/3] drivers: soc: sunxi: Introduce SoC driver to map SRAMs Maxime Ripard
2015-03-12 13:13 ` [PATCH RFC 2/3] ARM: sun7i: Add A20 SRAM and SRAM controller Maxime Ripard
2015-03-18 19:12   ` Hans de Goede [this message]
2015-03-20 20:53     ` Maxime Ripard
2015-03-12 13:13 ` [PATCH RFC 3/3] net: allwinner: emac: Claim our SRAM Maxime Ripard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5509CE0D.7000904@redhat.com \
    --to=hdegoede@redhat.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).