From: dinguyen@opensource.altera.com (Dinh Nguyen)
To: linux-arm-kernel@lists.infradead.org
Subject: ARM: socfpga: dts: fix spi1 interrupt
Date: Thu, 19 Mar 2015 09:14:37 -0500 [thread overview]
Message-ID: <550AD9CD.5020805@opensource.altera.com> (raw)
In-Reply-To: <20150318080950.GB10862@pengutronix.de>
On 03/18/2015 03:09 AM, Steffen Trumtrar wrote:
> Hi!
>
> On Tue, Mar 17, 2015 at 09:35:23PM +0000, Mark James wrote:
>> Hello,
>>
>> The socfpga.dtsi currently has the wrong interrupt number set for SPI master 1. Trying to use the master without this change results in the kernel boot process waiting forever for an interrupt that will never occur while attempting to probe any slave devices configured in the device tree as being under SPI master 1.
>>
>> The change works for the Cyclone V, and according to the Arria 5 handbook should be good there too.
>>
>>
>> Signed-off-by: Mark James <maj@jamers.net>
>> Acked-by: Steffen Trumtrar <s.trumtrar@pengutronix.de>
>>
>> ---
>> arch/arm/boot/dts/socfpga.dtsi | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/arch/arm/boot/dts/socfpga.dtsi b/arch/arm/boot/dts/socfpga.dtsi
>> index 9d87609..d9176e6 100644
>> --- a/arch/arm/boot/dts/socfpga.dtsi
>> +++ b/arch/arm/boot/dts/socfpga.dtsi
>> @@ -660,7 +660,7 @@
>> #address-cells = <1>;
>> #size-cells = <0>;
>> reg = <0xfff01000 0x1000>;
>> - interrupts = <0 156 4>;
>> + interrupts = <0 155 4>;
>> num-cs = <4>;
>> clocks = <&spi_m_clk>;
>> status = "disabled";
>
> Thanks for sending the patch to the mainline list.
> One little nitpick about the patchformat though:
>
> Please add linebreaks after 70-75 characters for readability. And remove the
> "Hello,\n\n" otherwise this would land in the final git commit, where it
> doesn't belong.
> For reference have a look at Documentation/SubmittingPatches in the kernel
> tree.
>
> Maybe Dinh can fix this up, otherwise he will tell you what to do.
>
Yes, I can pick this up and fix up the commit.
Dinh
next prev parent reply other threads:[~2015-03-19 14:14 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-17 21:35 ARM: socfpga: dts: fix spi1 interrupt Mark James
2015-03-18 8:09 ` Steffen Trumtrar
2015-03-19 14:14 ` Dinh Nguyen [this message]
2015-03-19 17:23 ` Mark James
2015-03-19 19:21 ` Steffen Trumtrar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=550AD9CD.5020805@opensource.altera.com \
--to=dinguyen@opensource.altera.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).