linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: ola@adapteva.com (Ola Jeppsson)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2] arm: zynq: Fix system clock with multi_v7_defconfig
Date: Mon, 23 Mar 2015 02:39:38 +0100	[thread overview]
Message-ID: <550F6EDA.30709@adapteva.com> (raw)

As mentioned in this commit:
arm: zynq: Don't use arm_global_timer with cpufreq
61f1fc7e9258a169ac8afb5ddf657a181e60d052

arm_global_timer depends on the CPU frequency. With cpufreq altering the
CPU frequency arm_global_timer will not maintain a stable time base. So
arm_global_timer must not be the clocksource when cpufreq is enabled.

The above commit tries to solve this at build time by only selecting
CONFIG_ARM_GLOBAL_TIMER if CONFIG_CPU_FREQ is disabled. This is not
always sufficient because other machs can also enable
CONFIG_ARM_GLOBAL_TIMER.

Therefore: If built with CONFIG_CPU_FREQ and CONFIG_ARM_GLOBAL_TIMER,
disable (on Zynq) the arm_global_timer devicetree node at boot before
clock sources are initialized. This ensures that arm_global_timer will
not be selected clocksource.

Signed-off-by: Ola Jeppsson <ola@adapteva.com>
---
 arch/arm/mach-zynq/common.c | 26 ++++++++++++++++++++++++++
 1 file changed, 26 insertions(+)

diff --git a/arch/arm/mach-zynq/common.c b/arch/arm/mach-zynq/common.c
index c887196..a4666d4 100644
--- a/arch/arm/mach-zynq/common.c
+++ b/arch/arm/mach-zynq/common.c
@@ -148,10 +148,36 @@ out:
 	platform_device_register_full(&devinfo);
 }
 
+#if defined(CONFIG_CPU_FREQ) && defined(CONFIG_ARM_GLOBAL_TIMER)
+static struct property zynq_disable_arm_global_timer_prop = {
+	.name = "status",
+	.length = sizeof("disabled"),
+	.value = "disabled"
+};
+
+static void __init zynq_disable_arm_global_timer(void)
+{
+	struct device_node *np;
+
+	np = of_find_compatible_node(NULL, NULL, "arm,cortex-a9-global-timer");
+	if (!np)
+		return;
+
+	pr_info("%s: disabling arm_global_timer node\n", __func__);
+
+	if (of_update_property(np, &zynq_disable_arm_global_timer_prop))
+		pr_warn("%s: could not disable arm_global_timer node\n",
+			__func__);
+}
+#endif
+
 static void __init zynq_timer_init(void)
 {
 	zynq_early_slcr_init();
 
+#if defined(CONFIG_CPU_FREQ) && defined(CONFIG_ARM_GLOBAL_TIMER)
+	zynq_disable_arm_global_timer();
+#endif
 	zynq_clock_init();
 	of_clk_init(NULL);
 	clocksource_of_init();
-- 
2.3.3

             reply	other threads:[~2015-03-23  1:39 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-03-23  1:39 Ola Jeppsson [this message]
2015-03-23  6:55 ` [PATCH v2] arm: zynq: Fix system clock with multi_v7_defconfig Michal Simek
2015-03-23  7:05 ` Michal Simek
2015-04-10 13:44   ` Arnd Bergmann
2015-04-10 15:09     ` Ola Jeppsson
2015-04-10 20:04       ` Arnd Bergmann
2015-04-10 20:41         ` Sören Brinkmann
2015-04-10 20:59           ` Arnd Bergmann
2015-04-10 22:15             ` Sören Brinkmann
2015-04-10 22:42               ` Arnd Bergmann
2015-04-10 16:02 ` Sören Brinkmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=550F6EDA.30709@adapteva.com \
    --to=ola@adapteva.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).