From: arnd@arndb.de (Arnd Bergmann)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM:mm: fix kmap_atomic_to_page
Date: Tue, 13 Oct 2015 13:44:09 +0200 [thread overview]
Message-ID: <5510159.Ge1KiGjbaB@wuerfel> (raw)
In-Reply-To: <561C6734.7010509@lge.com>
On Tuesday 13 October 2015 11:06:44 Jongsung Kim wrote:
> On 10/12/2015 06:27 PM, Arnd Bergmann wrote:
> > How about changing the zcomp code to pass the page pointer instead of the kernel space pointer? That would avoid having to do the kmap_atomic, which can itself be expensive on 32-bit machines and should not be needed here if you have a HW DMA engine doing the compression. Arnd
>
> Mainline zram uses lzo / lz4 library functions as backend. Using kmap_atomic and passing address look reasonable.
Yes, I know, but changing this to do the kmap_atomic in the backend
seems better here if you are adding another backend that doesn't
want or need the kmap_atomic.
Arnd
next prev parent reply other threads:[~2015-10-13 11:44 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-06 11:09 [PATCH] ARM:mm: fix kmap_atomic_to_page Chanho Min
2015-10-06 19:28 ` Russell King - ARM Linux
2015-10-07 1:37 ` Nicolas Pitre
2015-10-07 3:55 ` Jongsung Kim
2015-10-07 9:01 ` Russell King - ARM Linux
2015-10-12 5:30 ` Jongsung Kim
2015-10-12 9:27 ` Arnd Bergmann
2015-10-13 2:06 ` Jongsung Kim
2015-10-13 11:44 ` Arnd Bergmann [this message]
2015-10-12 6:00 ` yalin wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5510159.Ge1KiGjbaB@wuerfel \
--to=arnd@arndb.de \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).