Renaming ARM_CCI

Renaming ARM_CCI

[Valentin Rothberg]

Hi Suzuki,

your commit c9966c98697a ("arm-cci: Split the code for PMU vs driver
support") renames the Kconfig option ARM_CCI to ARM_CCI400_PORT_CTRL.
However, the commit does not rename all references on ARM_CCI:

drivers/bus/Kconfig:29: select ARM_CCI
drivers/bus/Makefile:6:obj-$(CONFIG_ARM_CCI)            += arm-cci.o
include/linux/arm-cci.h:31:#ifdef CONFIG_ARM_CCI

Is this intentional or is there a patch scheduled somewhere to fix this issue?

I detected your commit with scripts/checkkconfigsymbols.py.  A recent
patch added support to make the script git aware, so that it lets you
check git commits.  It's added to Greg's misc tree and should arrive
soon in linux-next.

[linux-next]$ ./checkkconfigsymbols.py --diff next-20150320..next-20150323
ARM_CCI drivers/bus/Makefile, include/linux/arm-cci.h, drivers/bus/Kconfig

Kind regards,
 Valentin

Renaming ARM_CCI

[Suzuki K. Poulose]

On 23/03/15 15:10, Valentin Rothberg wrote:
> Hi Suzuki,
>
> your commit c9966c98697a ("arm-cci: Split the code for PMU vs driver
> support") renames the Kconfig option ARM_CCI to ARM_CCI400_PORT_CTRL.
> However, the commit does not rename all references on ARM_CCI:
>
It renames, but still, leaves the ARM_CCI to build the arm-cci.o, which 
is in the original commit.

> drivers/bus/Kconfig:29: select ARM_CCI
> drivers/bus/Makefile:6:obj-$(CONFIG_ARM_CCI)            += arm-cci.o
> include/linux/arm-cci.h:31:#ifdef CONFIG_ARM_CCI
>
> Is this intentional or is there a patch scheduled somewhere to fix this issue?
Yes, it is. This problem was introduced due to a conflict in the linux-next.

See :
  https://lkml.org/lkml/2015/3/22/240

Cheers
Suzuki

Renaming ARM_CCI

[Suzuki K. Poulose]

On 23/03/15 15:17, Suzuki K. Poulose wrote:
> On 23/03/15 15:10, Valentin Rothberg wrote:
>> Hi Suzuki,
>>
>> your commit c9966c98697a ("arm-cci: Split the code for PMU vs driver
>> support") renames the Kconfig option ARM_CCI to ARM_CCI400_PORT_CTRL.
>> However, the commit does not rename all references on ARM_CCI:
>>
> It renames, but still, leaves the ARM_CCI to build the arm-cci.o, which
> is in the original commit.
>
>> drivers/bus/Kconfig:29: select ARM_CCI
>> drivers/bus/Makefile:6:obj-$(CONFIG_ARM_CCI)            += arm-cci.o
>> include/linux/arm-cci.h:31:#ifdef CONFIG_ARM_CCI
>>
>> Is this intentional or is there a patch scheduled somewhere to fix this issue?
> Yes, it is. This problem was introduced due to a conflict in the linux-next.
>
> See :
>    https://lkml.org/lkml/2015/3/22/240
Somehow, the link above doesn't link my response to the thread.
Please find it below.

	https://lkml.org/lkml/2015/3/23/484

Suzuki

Renaming ARM_CCI

[Valentin Rothberg]

On Mon, Mar 23, 2015 at 5:04 PM, Suzuki K. Poulose
<Suzuki.Poulose@arm.com> wrote:
> On 23/03/15 15:17, Suzuki K. Poulose wrote:
>>
>> On 23/03/15 15:10, Valentin Rothberg wrote:
>>>
>>> Hi Suzuki,
>>>
>>> your commit c9966c98697a ("arm-cci: Split the code for PMU vs driver
>>> support") renames the Kconfig option ARM_CCI to ARM_CCI400_PORT_CTRL.
>>> However, the commit does not rename all references on ARM_CCI:
>>>
>> It renames, but still, leaves the ARM_CCI to build the arm-cci.o, which
>> is in the original commit.
>>
>>> drivers/bus/Kconfig:29: select ARM_CCI
>>> drivers/bus/Makefile:6:obj-$(CONFIG_ARM_CCI)            += arm-cci.o
>>> include/linux/arm-cci.h:31:#ifdef CONFIG_ARM_CCI
>>>
>>> Is this intentional or is there a patch scheduled somewhere to fix this
>>> issue?
>>
>> Yes, it is. This problem was introduced due to a conflict in the
>> linux-next.
>>
>> See :
>>    https://lkml.org/lkml/2015/3/22/240
>
> Somehow, the link above doesn't link my response to the thread.
> Please find it below.
>
>         https://lkml.org/lkml/2015/3/23/484

Thank you for the answer and the explanation.

Kind regards,
 Valentin