From: pbonzini@redhat.com (Paolo Bonzini)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 01/25] arm: Use bool function return values of true/false not 1/0
Date: Tue, 31 Mar 2015 17:58:28 +0200 [thread overview]
Message-ID: <551AC424.9010802@redhat.com> (raw)
In-Reply-To: <912ed0ebae3c6a16f58b1452d5ce9226681bc8df.1427759009.git.joe@perches.com>
On 31/03/2015 01:45, Joe Perches wrote:
> Use the normal return values for bool functions
>
> Signed-off-by: Joe Perches <joe@perches.com>
> ---
> arch/arm/include/asm/dma-mapping.h | 8 ++++----
> arch/arm/include/asm/kvm_emulate.h | 2 +-
> arch/arm/mach-omap2/powerdomain.c | 14 +++++++-------
> 3 files changed, 12 insertions(+), 12 deletions(-)
>
> diff --git a/arch/arm/include/asm/dma-mapping.h b/arch/arm/include/asm/dma-mapping.h
> index b52101d..166e1e1 100644
> --- a/arch/arm/include/asm/dma-mapping.h
> +++ b/arch/arm/include/asm/dma-mapping.h
> @@ -151,18 +151,18 @@ static inline bool dma_capable(struct device *dev, dma_addr_t addr, size_t size)
> u64 limit, mask;
>
> if (!dev->dma_mask)
> - return 0;
> + return false;
>
> mask = *dev->dma_mask;
>
> limit = (mask + 1) & ~mask;
> if (limit && size > limit)
> - return 0;
> + return false;
>
> if ((addr | (addr + size - 1)) & ~mask)
> - return 0;
> + return false;
>
> - return 1;
> + return true;
> }
>
> static inline void dma_mark_clean(void *addr, size_t size) { }
> diff --git a/arch/arm/include/asm/kvm_emulate.h b/arch/arm/include/asm/kvm_emulate.h
> index a9c80a2..ad200a0 100644
> --- a/arch/arm/include/asm/kvm_emulate.h
> +++ b/arch/arm/include/asm/kvm_emulate.h
> @@ -51,7 +51,7 @@ static inline void vcpu_set_hcr(struct kvm_vcpu *vcpu, unsigned long hcr)
>
> static inline bool vcpu_mode_is_32bit(struct kvm_vcpu *vcpu)
> {
> - return 1;
> + return true;
> }
>
> static inline unsigned long *vcpu_pc(struct kvm_vcpu *vcpu)
> diff --git a/arch/arm/mach-omap2/powerdomain.c b/arch/arm/mach-omap2/powerdomain.c
> index 78af6d8..897f9fb 100644
> --- a/arch/arm/mach-omap2/powerdomain.c
> +++ b/arch/arm/mach-omap2/powerdomain.c
> @@ -950,7 +950,7 @@ int pwrdm_disable_hdwr_sar(struct powerdomain *pwrdm)
> */
> bool pwrdm_has_hdwr_sar(struct powerdomain *pwrdm)
> {
> - return (pwrdm && pwrdm->flags & PWRDM_HAS_HDWR_SAR) ? 1 : 0;
> + return pwrdm && (pwrdm->flags & PWRDM_HAS_HDWR_SAR);
> }
>
> int pwrdm_state_switch_nolock(struct powerdomain *pwrdm)
> @@ -1185,24 +1185,24 @@ bool pwrdm_can_ever_lose_context(struct powerdomain *pwrdm)
> if (!pwrdm) {
> pr_debug("powerdomain: %s: invalid powerdomain pointer\n",
> __func__);
> - return 1;
> + return true;
> }
>
> if (pwrdm->pwrsts & PWRSTS_OFF)
> - return 1;
> + return true;
>
> if (pwrdm->pwrsts & PWRSTS_RET) {
> if (pwrdm->pwrsts_logic_ret & PWRSTS_OFF)
> - return 1;
> + return true;
>
> for (i = 0; i < pwrdm->banks; i++)
> if (pwrdm->pwrsts_mem_ret[i] & PWRSTS_OFF)
> - return 1;
> + return true;
> }
>
> for (i = 0; i < pwrdm->banks; i++)
> if (pwrdm->pwrsts_mem_on[i] & PWRSTS_OFF)
> - return 1;
> + return true;
>
> - return 0;
> + return false;
> }
>
Marc/Christoffer, please pick this up yourself.
Paolo
next prev parent reply other threads:[~2015-03-31 15:58 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-30 23:45 [PATCH 00/25] treewide: Use bool function return values of true/false not 1/0 Joe Perches
2015-03-30 23:45 ` [PATCH 01/25] arm: " Joe Perches
2015-03-31 15:54 ` Tony Lindgren
2015-03-31 15:58 ` Paolo Bonzini [this message]
2015-03-31 16:05 ` Marc Zyngier
2015-03-30 23:46 ` [PATCH 02/25] arm64: " Joe Perches
2015-03-31 15:29 ` Will Deacon
[not found] ` <5519E53B.5040504@schaufler-ca.com>
2015-03-31 0:14 ` [PATCH 00/25] treewide: " Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=551AC424.9010802@redhat.com \
--to=pbonzini@redhat.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).