linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: nicolas.ferre@atmel.com (Nicolas Ferre)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: at91/dt: sama5d3 xplained: add phy address for macb1
Date: Fri, 3 Apr 2015 10:43:40 +0200	[thread overview]
Message-ID: <551E52BC.3040702@atmel.com> (raw)
In-Reply-To: <1427792170-13162-1-git-send-email-nicolas.ferre@atmel.com>

Le 31/03/2015 10:56, Nicolas Ferre a ?crit :
> After 57a38effa598 (net: phy: micrel: disable broadcast for KSZ8081/KSZ8091)
> the macb1 interface refuses to work properly because it tries
> to cling to address 0 which isn't able to communicate in broadcast with
> the mac anymore. The micrel phy on the board is actually configured
> to show up at address 1.
> Adding the phy node and its real address fixes the issue.
> 
> Signed-off-by: Nicolas Ferre <nicolas.ferre@atmel.com>
> Cc: Johan Hovold <johan@kernel.org>
> Cc: <stable@vger.kernel.org> #3.19
> ---

Arnd, Olof, Kevin,

It seems late but, is it possible to queue this patch as a 4.0 fixes?

Without it, the 10/100 Ethernet on sama5d3 doesn't work if it's not used
by u-boot previously.

Bye,

>  arch/arm/boot/dts/at91-sama5d3_xplained.dts | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/at91-sama5d3_xplained.dts b/arch/arm/boot/dts/at91-sama5d3_xplained.dts
> index fec1fca2ad66..6c4bc53cbf4e 100644
> --- a/arch/arm/boot/dts/at91-sama5d3_xplained.dts
> +++ b/arch/arm/boot/dts/at91-sama5d3_xplained.dts
> @@ -167,7 +167,13 @@
>  
>  			macb1: ethernet at f802c000 {
>  				phy-mode = "rmii";
> +				#address-cells = <1>;
> +				#size-cells = <0>;
>  				status = "okay";
> +
> +				ethernet-phy at 1 {
> +					reg = <0x1>;
> +				};
>  			};
>  
>  			dbgu: serial at ffffee00 {
> 


-- 
Nicolas Ferre

  reply	other threads:[~2015-04-03  8:43 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-03-31  8:56 [PATCH] ARM: at91/dt: sama5d3 xplained: add phy address for macb1 Nicolas Ferre
2015-04-03  8:43 ` Nicolas Ferre [this message]
2015-04-03 20:55   ` Olof Johansson
2015-04-03 21:56     ` Olof Johansson
2015-04-04 12:45       ` Nicolas Ferre

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=551E52BC.3040702@atmel.com \
    --to=nicolas.ferre@atmel.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).