linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: sebastian.hesselbarth@gmail.com (Sebastian Hesselbarth)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 3/4] ARM: berlin: add an ADC node for the BG2Q
Date: Sat, 04 Apr 2015 12:25:56 +0200	[thread overview]
Message-ID: <551FBC34.4070501@gmail.com> (raw)
In-Reply-To: <1428066409-30392-4-git-send-email-antoine.tenart@free-electrons.com>

On 03.04.2015 15:06, Antoine Tenart wrote:
> This patch adds the ADC node for the Berlin BG2Q, using the newly added
> Berlin IIO ADC driver.
>
> Signed-off-by: Antoine Tenart <antoine.tenart@free-electrons.com>
> ---
>   arch/arm/boot/dts/berlin2q.dtsi | 8 ++++++++
>   1 file changed, 8 insertions(+)
>
> diff --git a/arch/arm/boot/dts/berlin2q.dtsi b/arch/arm/boot/dts/berlin2q.dtsi
> index 187d056f7ad2..72b1c969a99d 100644
> --- a/arch/arm/boot/dts/berlin2q.dtsi
> +++ b/arch/arm/boot/dts/berlin2q.dtsi
> @@ -565,6 +565,14 @@
>   						function = "twsi3";
>   					};
>   				};
> +
> +				adc: adc {
> +					compatible = "marvell,berlin2-adc";
> +					interrupt-parent = <&sic>;
> +					interrupts = <12>, <14>;
> +					interrupt-names = "adc", "tsen";
> +					status = "disabled";
> +				};

Antoine,

nit: there is no gated clock for the ADC, I guess we can just always
enable it. That will save you the last patch of the series.

BTW, I have the strong feeling that moving berlin's clk drivers to
regmap will block any subsequent patches you are preparing. How about
we target the next merge window for moving the clk node but not the
drivers (except of_iomap of the _parent's_ reg property) and push the
less controversal patches (pinctrl, reset) with regmap/syscon forward?

Sebastian

>   			};
>
>   			sic: interrupt-controller at e000 {
>

  reply	other threads:[~2015-04-04 10:25 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-04-03 13:06 [PATCH v2 0/4] ARM: berlin: ADC support Antoine Tenart
2015-04-03 13:06 ` [PATCH v2 1/4] iio: adc: add support for Berlin Antoine Tenart
2015-04-09 13:58   ` Jonathan Cameron
2015-04-03 13:06 ` [PATCH v2 2/4] Documentation: bindings: document the Berlin ADC driver Antoine Tenart
2015-04-09 14:00   ` Jonathan Cameron
2015-04-03 13:06 ` [PATCH v2 3/4] ARM: berlin: add an ADC node for the BG2Q Antoine Tenart
2015-04-04 10:25   ` Sebastian Hesselbarth [this message]
2015-04-07 10:20     ` Antoine Tenart
2015-04-07 10:25       ` Sebastian Hesselbarth
2015-04-03 13:06 ` [PATCH v2 4/4] ARM: berlin: enable the ADC on the BG2Q DMP Antoine Tenart

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=551FBC34.4070501@gmail.com \
    --to=sebastian.hesselbarth@gmail.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).