From: Patrice CHOTARD <patrice.chotard@foss.st.com>
To: Felipe Balbi <felipe@balbi.sh>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Krzysztof Kozlowski <krzk@kernel.org>,
Serge Semin <Sergey.Semin@baikalelectronics.ru>,
<linux-arm-kernel@lists.infradead.org>,
<linux-usb@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
Jerome Audu <jerome.audu@st.com>
Subject: Re: [PATCH] usb: dwc3: st: Fix node's child name
Date: Wed, 28 Sep 2022 08:45:54 +0200 [thread overview]
Message-ID: <552281f4-dc8c-7cd7-32af-fa48de5aa414@foss.st.com> (raw)
In-Reply-To: <87o7v0g860.fsf@balbi.sh>
Hi Felipe, Krzysztof
On 9/27/22 17:15, Felipe Balbi wrote:
>
> <patrice.chotard@foss.st.com> writes:
>
>> From: Patrice Chotard <patrice.chotard@foss.st.com>
>>
>> Update node's child name from "dwc3" to "usb", this fixes
>> the following issue:
>>
>> [3.773852] usb-st-dwc3 8f94000.dwc3: failed to find dwc3 core node
>>
>> Fixes: 3120910a099b ("ARM: dts: stih407-family: Harmonize DWC USB3 DT nodes name")
>>
>> Reported-by: Jerome Audu <jerome.audu@st.com>
>> Signed-off-by: Patrice Chotard <patrice.chotard@foss.st.com>
>> ---
>> drivers/usb/dwc3/dwc3-st.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/usb/dwc3/dwc3-st.c b/drivers/usb/dwc3/dwc3-st.c
>> index 166b5bde45cb..6c14a79279f9 100644
>> --- a/drivers/usb/dwc3/dwc3-st.c
>> +++ b/drivers/usb/dwc3/dwc3-st.c
>> @@ -251,7 +251,7 @@ static int st_dwc3_probe(struct platform_device *pdev)
>> /* Manage SoftReset */
>> reset_control_deassert(dwc3_data->rstc_rst);
>>
>> - child = of_get_child_by_name(node, "dwc3");
>> + child = of_get_child_by_name(node, "usb");
>
> there could be DTBs in the wild which have `dwc3' as the child name. It
> seems to me that you should try both names, instead.
>
As this patch is already merged, i will submit an additional patch which will
rely on child's compatible string instead of child's node name, as done in other
dwc3 driver.
Thanks
Patrice
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
prev parent reply other threads:[~2022-09-28 6:47 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-26 12:43 [PATCH] usb: dwc3: st: Fix node's child name patrice.chotard
2022-09-26 13:52 ` Krzysztof Kozlowski
2022-09-27 15:15 ` Felipe Balbi
2022-09-28 6:45 ` Patrice CHOTARD [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=552281f4-dc8c-7cd7-32af-fa48de5aa414@foss.st.com \
--to=patrice.chotard@foss.st.com \
--cc=Sergey.Semin@baikalelectronics.ru \
--cc=felipe@balbi.sh \
--cc=gregkh@linuxfoundation.org \
--cc=jerome.audu@st.com \
--cc=krzk@kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).