From mboxrd@z Thu Jan 1 00:00:00 1970 From: srinivas.kandagatla@linaro.org (Srinivas Kandagatla) Date: Fri, 10 Apr 2015 19:32:31 +0100 Subject: [PATCH v2 09/12] ARM: dts: apq8064: Add USB OTG support for CM QS-600 In-Reply-To: <552807CF.4070600@codeaurora.org> References: <1428669187-10775-1-git-send-email-srinivas.kandagatla@linaro.org> <1428669293-11165-1-git-send-email-srinivas.kandagatla@linaro.org> <552807CF.4070600@codeaurora.org> Message-ID: <5528173F.6000509@linaro.org> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 10/04/15 18:26, Stephen Boyd wrote: > On 04/10/15 05:34, Srinivas Kandagatla wrote: >> From: Nicolas Dechesne >> >> This patch adds USB OTG support on USB1 for Compulab QS-600 Board. >> >> Signed-off-by: Srinivas Kandagatla >> [Srinivas Kandagatla: fixed up regulators and status properties] >> Signed-off-by: Nicolas Dechesne >> --- >> arch/arm/boot/dts/qcom-apq8064-cm-qs600.dts | 17 +++++++++++++++++ >> 1 file changed, 17 insertions(+) >> >> diff --git a/arch/arm/boot/dts/qcom-apq8064-cm-qs600.dts b/arch/arm/boot/dts/qcom-apq8064-cm-qs600.dts >> index fc69931..d353694 100644 >> --- a/arch/arm/boot/dts/qcom-apq8064-cm-qs600.dts >> +++ b/arch/arm/boot/dts/qcom-apq8064-cm-qs600.dts >> @@ -101,6 +101,14 @@ >> }; >> }; >> >> + /* OTG */ >> + usb1_phy:phy at 12500000 { > > Space after that ':' please. > Yep, I will fix it in next version. >> + status = "okay"; >> + vddcx-supply = <&pm8921_s3>; >> + v3p3-supply = <&pm8921_l3>; >> + v1p8-supply = <&pm8921_l4>; >> + }; >> + >> usb3_phy:phy at 12520000 { >> status = "okay"; >> vddcx-supply = <&pm8921_s3>; >> @@ -115,6 +123,15 @@ >> v1p8-supply = <&pm8921_l23>; >> }; >> >> + gadget1:gadget at 12500000 { >> + status = "ok"; >> + }; >> + >> + /* OTG */ >> + usb1: usb at 12500000 { > > This one is good. > >> + status = "ok"; >> + }; >> + >> usb3: usb at 12520000 { >> status = "okay"; >> }; > >