From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7BF67C43381 for ; Thu, 14 Mar 2019 19:03:26 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4D4822186A for ; Thu, 14 Mar 2019 19:03:26 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="FtKg2QO8" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4D4822186A Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=sntech.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=HaqXeMVQlzn0us/FA62blXW41GQIDUp+yUou1IGyjFY=; b=FtKg2QO8zsNPvY A4FkgBaV0py4oxUqV4pjDkqxvVPKDtVTp3Cq+JspfHIup6bREbm61/dC4BXYSXOf+MQxPqr7bO2TS Ia3AiwrJhLnEDXmvxRLI0dJyd/H7ksRA/AwUH765PxkuniDUKhawmEP/YJjL5wJYz3W/80HmKiAdk 0x1GNxkXLkArQ0XIDHEUFvsq/1GsGZLxyOE07OyIduvaPhi9454ZkJ57cWwjyPlDgL4/tzLhM/gqh TM7gy9Ue7EIVDhYq9wq5N693qZLm2AueUFxu+w4PWMbwIPXAECJ9m440YCnCkJLsL5vK2EFUXACg3 katjFv5YMBMtDA9aSWsw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1h4VdL-0000bP-FI; Thu, 14 Mar 2019 19:03:15 +0000 Received: from gloria.sntech.de ([185.11.138.130]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1h4VdG-0000ab-FI; Thu, 14 Mar 2019 19:03:13 +0000 Received: from ip5f5a6320.dynamic.kabel-deutschland.de ([95.90.99.32] helo=diego.localnet) by gloria.sntech.de with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1h4Vd3-0007BM-Ct; Thu, 14 Mar 2019 20:02:57 +0100 From: Heiko =?ISO-8859-1?Q?St=FCbner?= To: "Leonidas P. Papadakos" Subject: Re: [PATCH] arm64: dts: rockchip: add usb3 controller node for RK3328 SoCs Date: Thu, 14 Mar 2019 20:02:55 +0100 Message-ID: <5530020.nRYjYCbPGH@diego> In-Reply-To: <20190314182035.7101-1-papadakospan@gmail.com> References: <20190314182035.7101-1-papadakospan@gmail.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190314_120310_660920_592E30FE X-CRM114-Status: GOOD ( 15.39 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , devicetree@vger.kernel.org, linux-rockchip@lists.infradead.org, Rob Herring , william.wu@rock-chips.com, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi, Am Donnerstag, 14. M=E4rz 2019, 19:20:35 CET schrieb Leonidas P. Papadakos: > From: William Wu > = > RK3328 has one USB 3.0 OTG controller which uses DWC_USB3 > core's general architecture. It can act as static xHCI host > controller, static device controller, USB 3.0/2.0 OTG basing > on ID of USB3.0 PHY. > = > Signed-off-by: William Wu > Signed-off-by: Leonidas P. Papadakos the rk3328 usb3-phy has an issue with detecting any plugin events after a previous device got removed - see the inno-usb3-phy driver in the vendor kernel. So once you unplug an usb device from the port it won't detect a newly connected device. This is also the reason why the original usb3 patches are still sitting around in my tree, as I don't want to codify a binding that may not last once somebody actually manages to go around that issue with kernel code - especially as the node below claims to be compatible with the rk3399 dwc3. Heiko > --- > arch/arm64/boot/dts/rockchip/rk3328.dtsi | 27 ++++++++++++++++++++++++ > 1 file changed, 27 insertions(+) > = > diff --git a/arch/arm64/boot/dts/rockchip/rk3328.dtsi > b/arch/arm64/boot/dts/rockchip/rk3328.dtsi index 84f14b132..f5c1ab596 > 100644 > --- a/arch/arm64/boot/dts/rockchip/rk3328.dtsi > +++ b/arch/arm64/boot/dts/rockchip/rk3328.dtsi > @@ -917,6 +917,33 @@ > status =3D "disabled"; > }; > = > + usbdrd3: usb@ff600000 { > + compatible =3D "rockchip,rk3328-dwc3", "rockchip,rk3399-dwc3"; > + clocks =3D <&cru SCLK_USB3OTG_REF>, <&cru SCLK_USB3OTG_SUSPEND>, > + <&cru ACLK_USB3OTG>; > + clock-names =3D "ref_clk", "suspend_clk", > + "bus_clk"; > + #address-cells =3D <2>; > + #size-cells =3D <2>; > + ranges; > + status =3D "disabled"; > + > + usbdrd_dwc3: dwc3@ff600000 { > + compatible =3D "snps,dwc3"; > + reg =3D <0x0 0xff600000 0x0 0x100000>; > + interrupts =3D ; > + dr_mode =3D "otg"; > + phy_type =3D "utmi_wide"; > + snps,dis_enblslpm_quirk; > + snps,dis-u2-freeclk-exists-quirk; > + snps,dis_u2_susphy_quirk; > + snps,dis_u3_susphy_quirk; > + snps,dis-del-phy-power-chg-quirk; > + snps,dis-tx-ipgap-linecheck-quirk; > + status =3D "disabled"; > + }; > + }; > + > gic: interrupt-controller@ff811000 { > compatible =3D "arm,gic-400"; > #interrupt-cells =3D <3>; _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel