From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 6C430C2BA4C for ; Wed, 26 Jan 2022 17:38:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=4B25GgowkntVh+r+jDY2UajoRrsU8GGMTMYmXJKxWu4=; b=f867sVPjQYJj7i CenmbG0KgkqZ8jyvIc0FWAms+36GnTxgVpUdoTIL0F1kgAOBYjZ8DFurraQNpyHEj//URAXu+xGng 0mcC6a89HaxBnwk9ZEvVct/z47GyOY2OjYV4pWvdW4bD44xBiSgaTxBa5karVyau4eyrN7+nIO4JF WHnkr8UxGgNoiLHU9QZeaYOLcwLO8rH8sWUfoX95tdy9y4TpvSOQrPNq9Fi4yDNiOH5lqLUsOAJyv pWXlIog9gXV9Cg+/Tv8nc6SAkcBdPLPlzRVgRUzVuGfVyBG7zrft9vmfJpdIpq3K+XsqjUAoIJJI6 VJiE2PbzZCn13n+Xm7Zg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nCmE4-00D3B8-Cm; Wed, 26 Jan 2022 17:36:57 +0000 Received: from mail-wr1-x42f.google.com ([2a00:1450:4864:20::42f]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nClsL-00CvG0-6r for linux-arm-kernel@lists.infradead.org; Wed, 26 Jan 2022 17:14:30 +0000 Received: by mail-wr1-x42f.google.com with SMTP id h21so192455wrb.8 for ; Wed, 26 Jan 2022 09:14:27 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=gXtdrW27fCZ/wJUPBVbcRIlDfwjyibpVlA/v0Qe0N+A=; b=ShEI2vtBBOEzdM8KBa2+C+sra9rF3eUL8rq9LzYJlSnCdzLTrR9bprTUNRFKfPviWE 9LxSGdHftoFFaEfs5hs4wlUS92fvaNMhsVvPgTvT2ilBpLXxDvPOF61ztFbDBhyABL1T NeAJUgNQN40uFADgvWGHHvtXEXm6/Ml8nuddZ7Oji2LkhqqcjoyLsgnsrnl+kd6/i1iI yQRqPJInXft4GD+ohxuxSx1AAny0JGtYF1WIsfY27wSah06MVOWb4YXlTQSzlElHgJAI dMjR619JNdTUz0aIjR8ixqhJOIRS0C31q6OhH3D1GxGbZ8jz/18gsCQB3V33I37fzdsc T8Sw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=gXtdrW27fCZ/wJUPBVbcRIlDfwjyibpVlA/v0Qe0N+A=; b=cOh7G9SUVnLZ52VmHHfSDy/LvYwG5+0+5dwcUrF/c9IDC43mqSmuR0fnLXNeSlm5N3 QMmMwpk+ZOQj7B7fw3DjiLVA3aV4UvReUzFPXER0PYqnjYoTRytuDOhWStS8sqZrrwgJ Cd+qWzFOOZJr2udC5eMzAqbqekD8YbplM7AOlg49hiADHAE/PkMaSJu+jjMVN4IAD2c/ sTZlE6YpyrIvsoOlWdPmlAHrrKuNMjPeMeQI7Nnp8/NdRmV2rvRo1+/ky98iYx2fnPK2 NJX9H2Scwvo4OZqmwuP+Yne6/1hdo887ArxS3oMpnCo0nvfSX0Hkxmkr981AIjkS+OX5 D3zA== X-Gm-Message-State: AOAM531J09IcBkREGACaBKcuTMZzqBfJ3AtFrqRcOgFCNohcau4uY5Rs UBlUBkdSBYb3kBWyWzLo580= X-Google-Smtp-Source: ABdhPJwj+3itbOp8dJx8AHey5VYTt5YOotHUNr1kojxGb+QydODRJny0bAdqTKmSHnhQdy6BUYrH6g== X-Received: by 2002:a05:6000:81:: with SMTP id m1mr18100420wrx.385.1643217266591; Wed, 26 Jan 2022 09:14:26 -0800 (PST) Received: from kista.localnet (cpe-86-58-32-107.static.triera.net. [86.58.32.107]) by smtp.gmail.com with ESMTPSA id c8sm4800962wmq.34.2022.01.26.09.14.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 26 Jan 2022 09:14:26 -0800 (PST) From: Jernej =?utf-8?B?xaBrcmFiZWM=?= To: Giuseppe Cavallaro , Alexandre Torgue , Jose Abreu , "David S . Miller" , Jakub Kicinski , Maxime Coquelin , Maxime Ripard , Chen-Yu Tsai , Jisheng Zhang Cc: netdev@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH] net: stmmac: dwmac-sun8i: use return val of readl_poll_timeout() Date: Wed, 26 Jan 2022 18:14:25 +0100 Message-ID: <5533854.DvuYhMxLoT@kista> In-Reply-To: <20220126165215.1921-1-jszhang@kernel.org> References: <20220126165215.1921-1-jszhang@kernel.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220126_091429_384445_2F0B3968 X-CRM114-Status: GOOD ( 16.50 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi! Dne sreda, 26. januar 2022 ob 17:52:15 CET je Jisheng Zhang napisal(a): > When readl_poll_timeout() timeout, we'd better directly use its return > value. > > Before this patch: > [ 2.145528] dwmac-sun8i: probe of 4500000.ethernet failed with error -14 > > After this patch: > [ 2.138520] dwmac-sun8i: probe of 4500000.ethernet failed with error -110 > > Signed-off-by: Jisheng Zhang Acked-by: Jernej Skrabec Best regards, Jernej > --- > drivers/net/ethernet/stmicro/stmmac/dwmac-sun8i.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/ethernet/stmicro/stmmac/dwmac-sun8i.c b/drivers/net/ ethernet/stmicro/stmmac/dwmac-sun8i.c > index 617d0e4c6495..09644ab0d87a 100644 > --- a/drivers/net/ethernet/stmicro/stmmac/dwmac-sun8i.c > +++ b/drivers/net/ethernet/stmicro/stmmac/dwmac-sun8i.c > @@ -756,7 +756,7 @@ static int sun8i_dwmac_reset(struct stmmac_priv *priv) > > if (err) { > dev_err(priv->device, "EMAC reset timeout\n"); > - return -EFAULT; > + return err; > } > return 0; > } > -- > 2.34.1 > > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel