From: grygorii.strashko@linaro.org (Grygorii.Strashko@linaro.org)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] mmc: core: add missing pm event in mmc_pm_notify to fix hib restore
Date: Fri, 24 Apr 2015 13:52:15 +0300 [thread overview]
Message-ID: <553A205F.6020608@linaro.org> (raw)
In-Reply-To: <CAPDyKFqA5Wvod_0J-52FJ9Vktt1kdq7H7c9UcX-daJ0hazWU+Q@mail.gmail.com>
On 04/23/2015 04:19 PM, Ulf Hansson wrote:
> On 23 April 2015 at 12:43, <grygorii.strashko@linaro.org> wrote:
>> From: Grygorii Strashko <Grygorii.Strashko@linaro.org>
>>
>> The PM_RESTORE_PREPARE is not handled now in mmc_pm_notify(),
>> as result mmc_rescan() could be scheduled and executed at
>> late hibernation restore stages when MMC device is suspended
>> already - which, in turn, will lead to system crash on TI dra7-evm board:
>>
>> WARNING: CPU: 0 PID: 3188 at drivers/bus/omap_l3_noc.c:148 l3_interrupt_handler+0x258/0x374()
>> 44000000.ocp:L3 Custom Error: MASTER MPU TARGET L4_PER1_P3 (Idle): Data Access in User mode during Functional access
>>
>> Hence, add missed PM_RESTORE_PREPARE PM event in mmc_pm_notify().
>>
>> Signed-off-by: Grygorii Strashko <Grygorii.Strashko@linaro.org>
>
> Huh, that was an old bug you found. :-)
oh yes. it's happened thanks to HW issue on my board which
generates a flood of SDCD IRQs :)
It's the worst case ever to track wrong/missed PM notifiers (
>
> I have applied it for fixes and added the below fixes tag.
>
> Fixes: 4c2ef25fe0b8 (mmc: fix all hangs related to mmc/sd card
> insert/removal during suspend/resume)
Thanks.
--
regards,
-grygorii
prev parent reply other threads:[~2015-04-24 10:52 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-23 10:43 [PATCH] mmc: core: add missing pm event in mmc_pm_notify to fix hib restore grygorii.strashko at linaro.org
2015-04-23 13:19 ` Ulf Hansson
2015-04-24 10:52 ` Grygorii.Strashko@linaro.org [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=553A205F.6020608@linaro.org \
--to=grygorii.strashko@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).