From: santosh.shilimkar@oracle.com (santosh shilimkar)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 0/3] Introduce SET_NOIRQ_SYSTEM_SLEEP_PM_OPS and use it
Date: Mon, 27 Apr 2015 13:27:10 -0700 [thread overview]
Message-ID: <553E9B9E.4080401@oracle.com> (raw)
In-Reply-To: <1430159072-31440-1-git-send-email-grygorii.strashko@linaro.org>
On 4/27/2015 11:24 AM, grygorii.strashko at linaro.org wrote:
> From: Grygorii Strashko <grygorii.strashko@linaro.org>
>
> While working on suspend-to-disk functionality on TI dra7-evm (DRA7xx SoC)
> i've found that the most common problem I have to dial with is absence
> of corresponding PM callbacks in drivers and, in particular, noirq callbacks.
> So, I've fixed one driver first
> commit 6248015d6867 "ARM: omap-device: add missed callback for suspend-to-disk"
> but then found another one which need to be fixed too (omap_l3_noc.c).
> At this moment I decided to make my life easier and added new macro
> SET_NOIRQ_SYSTEM_SLEEP_PM_OPS using the same approach as for the existing
> SET_SYSTEM_SLEEP_PM_OPS macro.
>
> SET_NOIRQ_SYSTEM_SLEEP_PM_OPS: defined for CONFIG_PM_SLEEP and
> assigns ->suspend_noirq, ->freeze_noirq and ->poweroff_noirq to the same
> function. Vice versa happens for ->resume_noirq, ->thaw_noirq and
> ->restore_noirq.
>
> Further two patches reuse this newly introduced macro.
>
> SET_NOIRQ_SYSTEM_SLEEP_PM_OPS, defined for CONFIG_PM_SLEEP, will
> point ->suspend_noirq, ->freeze_noirq and ->poweroff_noirq to the same
> function. Vice versa happens for ->resume_noirq, ->thaw_noirq and
> ->restore_noirq.
>
[...]
>
> Grygorii Strashko (3):
> PM / Sleep: Add macro to define common noirq system PM callbacks
> bus: omap_l3_noc: add missed callbacks for suspend-to-disk
> ARM: omap-device: use SET_NOIRQ_SYSTEM_SLEEP_PM_OPS
>
> arch/arm/mach-omap2/omap_device.c | 7 ++-----
> drivers/bus/omap_l3_noc.c | 4 ++--
> include/linux/pm.h | 12 ++++++++++++
> 3 files changed, 16 insertions(+), 7 deletions(-)
>
Looks fine to me.....
Acked-by: Santosh Shilimkar <ssantosh@kernel.org>
next prev parent reply other threads:[~2015-04-27 20:27 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-27 18:24 [PATCH 0/3] Introduce SET_NOIRQ_SYSTEM_SLEEP_PM_OPS and use it grygorii.strashko at linaro.org
2015-04-27 18:24 ` [PATCH 1/3] PM / Sleep: Add macro to define common noirq system PM callbacks grygorii.strashko at linaro.org
2015-04-27 18:24 ` [PATCH 2/3] bus: omap_l3_noc: add missed callbacks for suspend-to-disk grygorii.strashko at linaro.org
2015-04-27 19:30 ` Nishanth Menon
2015-04-27 18:24 ` [PATCH 3/3] ARM: omap-device: use SET_NOIRQ_SYSTEM_SLEEP_PM_OPS grygorii.strashko at linaro.org
2015-04-27 20:27 ` santosh shilimkar [this message]
2015-04-28 7:40 ` [PATCH 0/3] Introduce SET_NOIRQ_SYSTEM_SLEEP_PM_OPS and use it Ulf Hansson
2015-04-28 15:40 ` Kevin Hilman
2015-05-15 0:06 ` Rafael J. Wysocki
2015-04-30 17:37 ` Pavel Machek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=553E9B9E.4080401@oracle.com \
--to=santosh.shilimkar@oracle.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).