From: f.fainelli@gmail.com (Florian Fainelli)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: proc-feroceon: Fix feroceon_proc_info macro
Date: Wed, 29 Apr 2015 09:33:12 -0700 [thread overview]
Message-ID: <554107C8.7050701@gmail.com> (raw)
In-Reply-To: <1430319415-6421-1-git-send-email-andrew@lunn.ch>
On 29/04/15 07:56, Andrew Lunn wrote:
> bf35706f3d09 ("ARM: 8314/1: replace PROCINFO embedded branch with
> relative offset") broke booting for Kirkwood. The kernel would say:
>
> Starting kernel ...
>
> Uncompressing Linux... done, booting the kernel.
>
> Error: unrecognized/unsupported processor variant (0x56251311).
>
> Fix it by removing the extraneous .long __feroceon_setup from the
> feroceon_proc_info macro.
>
> Reported-by: Florian Fainelli <f.fainelli@gmail.com>
> Suggested-by: Arnd Bergmann <arnd@arndb.de>
> Signed-off-by: Andrew Lunn <andrew@lunn.ch>
> Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Tested-by: Florian Fainelli <f.fainelli@gmail.com>
Thanks everyone!
> Fixes: bf35706f3d09 ("ARM: 8314/1: replace PROCINFO embedded branch with relative offset")
> ---
> arch/arm/mm/proc-feroceon.S | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/arch/arm/mm/proc-feroceon.S b/arch/arm/mm/proc-feroceon.S
> index e494d6d6acbe..92e08bf37aad 100644
> --- a/arch/arm/mm/proc-feroceon.S
> +++ b/arch/arm/mm/proc-feroceon.S
> @@ -602,7 +602,6 @@ __\name\()_proc_info:
> PMD_SECT_AP_WRITE | \
> PMD_SECT_AP_READ
> initfn __feroceon_setup, __\name\()_proc_info
> - .long __feroceon_setup
> .long cpu_arch_name
> .long cpu_elf_name
> .long HWCAP_SWP|HWCAP_HALF|HWCAP_THUMB|HWCAP_FAST_MULT|HWCAP_EDSP
>
--
Florian
next prev parent reply other threads:[~2015-04-29 16:33 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-29 14:05 Regression: Kirkwood fails to boot because of bf35706f3d0929b Andrew Lunn
2015-04-29 14:37 ` Ard Biesheuvel
2015-04-29 14:56 ` [PATCH] ARM: proc-feroceon: Fix feroceon_proc_info macro Andrew Lunn
2015-04-29 15:05 ` Ard Biesheuvel
2015-04-29 16:33 ` Florian Fainelli [this message]
2015-05-02 19:35 ` Aaro Koskinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=554107C8.7050701@gmail.com \
--to=f.fainelli@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).