From: Suzuki.Poulose@arm.com (Suzuki K. Poulose)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH V2] drivers: CCI: fix used_mask init in validate_group()
Date: Thu, 30 Apr 2015 11:55:20 +0100 [thread overview]
Message-ID: <55420A18.7080203@arm.com> (raw)
In-Reply-To: <20150413124121.GF2869@arm.com>
On 13/04/15 13:41, Will Deacon wrote:
> On Thu, Apr 09, 2015 at 04:36:29PM +0100, Mark Rutland wrote:
>> On Thu, Apr 09, 2015 at 03:57:05PM +0100, Mark Salter wrote:
>>> Currently in validate_group(), there is a static initializer
>>> for fake_pmu.used_mask which is based on CPU_BITS_NONE but
>>> the used_mask array size is based on CCI_PMU_MAX_HW_EVENTS.
>>> CCI_PMU_MAX_HW_EVENTS is not based on NR_CPUS, so CPU_BITS_NONE
>>> is not correct and will cause a build failure if NR_CPUS
>>> is set high enough to make CPU_BITS_NONE larger than used_mask.
>>>
>>> Signed-off-by: Mark Salter <msalter@redhat.com>
>>
>> Reviewed-by: Mark Rutland <mark.rutland@arm.com>
>>
>> Arnd, Olof, are you happy to take this via arm-soc?
>>
>> My (broken) patch went via Will's tree because of a perf dependency, but
>> other CCI patches have gone via you guys.
>
> Yeah, arm-soc is the best place for this. You should resend to
> arm at kernel.org as a new patch with the relevant acks.
Mark
Could you please send this to arm-soc as suggested by Will, with the
relevant acks/reviews ?
Thanks
Suzuki
next prev parent reply other threads:[~2015-04-30 10:55 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-08 18:21 [PATCH] drivers: CCI: fix used_mask init in validate_group() Mark Salter
2015-04-09 11:06 ` Suzuki K. Poulose
2015-04-09 13:51 ` Mark Rutland
2015-04-09 14:11 ` Mark Salter
2015-04-09 14:20 ` Mark Rutland
2015-04-09 14:26 ` Mark Salter
2015-04-09 14:40 ` Mark Rutland
2015-04-09 14:57 ` [PATCH V2] " Mark Salter
2015-04-09 15:36 ` Mark Rutland
2015-04-13 12:41 ` Will Deacon
2015-04-30 10:55 ` Suzuki K. Poulose [this message]
2015-04-30 13:26 ` Mark Salter
2015-04-30 13:33 ` Mark Rutland
2015-04-30 14:03 ` Mark Salter
2015-04-30 14:38 ` Mark Rutland
2015-04-30 14:46 ` Mark Salter
2015-04-30 14:52 ` Arnd Bergmann
2015-04-15 10:44 ` Suzuki K. Poulose
2015-04-15 11:58 ` Will Deacon
2015-04-15 12:50 ` Suzuki K. Poulose
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55420A18.7080203@arm.com \
--to=suzuki.poulose@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).