linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: labbott@redhat.com (Laura Abbott)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] arm64: mm: Fix build error with CONFIG_SPARSEMEM_VMEMMAP disabled
Date: Mon, 04 May 2015 09:51:01 -0700	[thread overview]
Message-ID: <5547A375.7040903@redhat.com> (raw)
In-Reply-To: <1430735628-14455-1-git-send-email-js07.lee@gmail.com>

On 05/04/2015 03:33 AM, Jungseung Lee wrote:
> This fix the below build error:
>
> arch/arm64/mm/dump.c: In function ?ptdump_init?:
> arch/arm64/mm/dump.c:331:18: error: ?VMEMMAP_START_NR? undeclared (first use in this function)
>    address_markers[VMEMMAP_START_NR].start_address =
>                    ^
> arch/arm64/mm/dump.c:331:18: note: each undeclared identifier is reported only once for each
> function it appears in
> arch/arm64/mm/dump.c:333:18: error: ?VMEMMAP_END_NR? undeclared (first use in this function)
>    address_markers[VMEMMAP_END_NR].start_address =
>                    ^
>
> Signed-off-by: Jungseung Lee <js07.lee@gmail.com>
> ---
>   arch/arm64/mm/dump.c | 2 ++
>   1 file changed, 2 insertions(+)
>
> diff --git a/arch/arm64/mm/dump.c b/arch/arm64/mm/dump.c
> index 74c2567..f3d6221 100644
> --- a/arch/arm64/mm/dump.c
> +++ b/arch/arm64/mm/dump.c
> @@ -328,10 +328,12 @@ static int ptdump_init(void)
>   			for (j = 0; j < pg_level[i].num; j++)
>   				pg_level[i].mask |= pg_level[i].bits[j].mask;
>
> +#ifdef CONFIG_SPARSEMEM_VMEMMAP
>   	address_markers[VMEMMAP_START_NR].start_address =
>   				(unsigned long)virt_to_page(PAGE_OFFSET);
>   	address_markers[VMEMMAP_END_NR].start_address =
>   				(unsigned long)virt_to_page(high_memory);
> +#endif
>
>   	pe = debugfs_create_file("kernel_page_tables", 0400, NULL, NULL,
>   				 &ptdump_fops);
>

Acked-by: Laura Abbott <labbott@redhat.com>

Did something change recently to make SPARSEMEM_VMEMMAP actually
deselectable? For some reason I thought that couldn't be turned off.

      reply	other threads:[~2015-05-04 16:51 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-05-04 10:33 [PATCH] arm64: mm: Fix build error with CONFIG_SPARSEMEM_VMEMMAP disabled Jungseung Lee
2015-05-04 16:51 ` Laura Abbott [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5547A375.7040903@redhat.com \
    --to=labbott@redhat.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).