From mboxrd@z Thu Jan 1 00:00:00 1970 From: jsarha@ti.com (Jyri Sarha) Date: Fri, 8 May 2015 16:37:29 +0300 Subject: [alsa-devel] [PATCH RFC v2 10/13] sound/core: add DRM ELD helper In-Reply-To: <20150508132701.GJ2067@n2100.arm.linux.org.uk> References: <20150402092050.GH24899@n2100.arm.linux.org.uk> <34627ba55428fd0dd821d99a5326e451@kapsi.fi> <20150508132701.GJ2067@n2100.arm.linux.org.uk> Message-ID: <554CBC19.6000701@ti.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 05/08/15 16:27, Russell King - ARM Linux wrote: > On Fri, May 08, 2015 at 04:16:08PM +0300, Jyri Sarha wrote: >> On 2015-04-02 12:22, Russell King wrote: ... >> For what I can see, you are setting the cross dependency between >> the sample rate and channels incorrectly. > > There is a dependency between sample rate and channels. > >> You should look for the >> currently tested channel count directly from hw params. > > I'm not so sure that's right after looking at snd_ac97_pcm_double_rate_rules(). > That's pretty much the same problem - AC'97 codecs can operate at a > sample rate of either the bus frame frequency or twice the bus frame > frequency. > Maybe digging the channels from intervals works too, I have just never used that myself. The param_channels() works too and it is slightly simpler.