From: swarren@wwwdotorg.org (Stephen Warren)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: tegra: add "nor-jedec" flash compatible binding
Date: Fri, 08 May 2015 10:00:12 -0600 [thread overview]
Message-ID: <554CDD8C.7050000@wwwdotorg.org> (raw)
In-Reply-To: <1431066098-19821-1-git-send-email-zajec5@gmail.com>
On 05/08/2015 12:21 AM, Rafa? Mi?ecki wrote:
> Starting with commits
> 8ff16cf ("Documentation: devicetree: m25p80: add "nor-jedec" binding")
> 1103b85 ("mtd: m25p80: bind to "nor-jedec" ID, for auto-detection")
> we have "nor-jedec" binding indicating support for JEDEC identification.
The documentation looks quite incomplete. "nor-jedec" sounds like it's
intended to be something generic. As such, it should be documented in
e.g. Documentation/devicetree/bindings/mtd/nor-jedec.txt, not buried in
one particular flash device's binding. If it's not intended to be
generic, why isn't the existing "winbond,w25q32dw" enough?
Equally, "nor-jedec" doesn't sound like the right name. It doesn't
differentiate between SPI and parallel NOR flash, which presumably need
different compatible values, since the programming model is quite
different, and the compatible value is supposed to define/imply the
SW-visible programming model.
next prev parent reply other threads:[~2015-05-08 16:00 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-08 6:21 [PATCH] ARM: tegra: add "nor-jedec" flash compatible binding Rafał Miłecki
2015-05-08 16:00 ` Stephen Warren [this message]
2015-05-08 18:43 ` Brian Norris
2015-05-08 18:47 ` Brian Norris
2015-05-08 20:01 ` Stephen Warren
2015-05-08 20:15 ` Brian Norris
2015-05-08 21:03 ` Stephen Warren
2015-05-08 20:57 ` Geert Uytterhoeven
2015-05-08 21:04 ` Stephen Warren
2015-05-08 21:34 ` Brian Norris
2015-05-11 22:46 ` Brian Norris
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=554CDD8C.7050000@wwwdotorg.org \
--to=swarren@wwwdotorg.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).