From: kgene@kernel.org (Kukjin Kim)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/1] ARM: dts: Add keep-power-in-suspend to WiFi SDIO nodefor Snow
Date: Sat, 09 May 2015 03:14:04 +0900 [thread overview]
Message-ID: <554CFCEC.5070803@kernel.org> (raw)
In-Reply-To: <CAJKOXPc88v_VzqE54sup4JHAgqwYCn0g_zpKgJwpny3egaZAbw@mail.gmail.com>
On 05/08/15 09:09, Krzysztof Kozlowski wrote:
> 2015-05-07 1:36 GMT+09:00 Doug Anderson <dianders@chromium.org>:
>> Javier,
>>
>> On Wed, May 6, 2015 at 9:32 AM, Javier Martinez Canillas
>> <javier.martinez@collabora.co.uk> wrote:
>>> The Marvell mwifiex driver prevents the system to enter into a suspend
>>> state if the card power is not preserved during a suspend/resume cycle.
>>>
>>> So Suspend-to-RAM and Suspend-to-idle are failing on Exynos5250 Snow.
>>>
>>> Add the keep-power-in-suspend Power Management property to the SDIO/MMC
>>> node so the mwifiex suspend handler doesn't fail and the system is able
>>> to enter into a suspend state.
>>>
>>> Signed-off-by: Javier Martinez Canillas <javier.martinez@collabora.co.uk>
>>> ---
>>>
>>> Kukjin and Krzysztof,
>>>
>>> I didn't notice that Snow was also missing this property when I did the
>>> same change for Peach Pit and and Pi Chromebooks [0], sorry about that.
>>>
No problem and thanks for your effort.
>>> Best regards,
>>> Javier
>>>
>>> [0]: https://lkml.org/lkml/2015/4/7/377
>>> ---
>>> arch/arm/boot/dts/exynos5250-snow.dts | 1 +
>>> 1 file changed, 1 insertion(+)
>>
>> Reviewed-by: Doug Anderson <dianders@chromium.org>
>
Doug, thanks for your review.
> Thanks, applied to dts-fixes branch, I'll try to push it sooner than
> later but it depends on status of previous pull requests.
>
Krzysztof, I've applied this into my tree directly.
Thanks for your gentle reminder and time.
- Kukjin
prev parent reply other threads:[~2015-05-08 18:14 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-06 16:32 [PATCH 1/1] ARM: dts: Add keep-power-in-suspend to WiFi SDIO node for Snow Javier Martinez Canillas
2015-05-06 16:36 ` Doug Anderson
2015-05-08 0:09 ` Krzysztof Kozlowski
2015-05-08 18:14 ` Kukjin Kim [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=554CFCEC.5070803@kernel.org \
--to=kgene@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).