linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: swarren@wwwdotorg.org (Stephen Warren)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: tegra: add "nor-jedec" flash compatible binding
Date: Fri, 08 May 2015 15:03:40 -0600	[thread overview]
Message-ID: <554D24AC.9080404@wwwdotorg.org> (raw)
In-Reply-To: <20150508201527.GC32500@ld-irv-0074>

On 05/08/2015 02:15 PM, Brian Norris wrote:
> On Fri, May 08, 2015 at 02:01:40PM -0600, Stephen Warren wrote:
>> On 05/08/2015 12:43 PM, Brian Norris wrote:
>>> On Fri, May 08, 2015 at 10:00:12AM -0600, Stephen Warren wrote:
>>>> Equally, "nor-jedec" doesn't sound like the right name. It doesn't
>>>> differentiate between SPI and parallel NOR flash, which presumably
>>>> need different compatible values, since the programming model is
>>>> quite different, and the compatible value is supposed to
>>>> define/imply the SW-visible programming model.
>>>
>>> It's definitely for SPI only. There was much discussion about this a
>>> few months back. Somewhere along the way, it was mentioned that the
>>> context (SPI slave is a child of SPI master) would make this clear. I'm
>>> still not sure why we didn't end up with something more descriptive,
>>> though, like "spi-nor,nor-jedec".
>>>
>>> I'm open to change, as this binding is new in 4.1-rc1.
>>
>> I don't believe compatible values should be interpreted according to
>> context; compatible value matching isn't implemented that way AFAIK,
>> and I'm not aware of any precedent for it to work that way.
>
> For SPI slaves, they are always nested within their SPI master/bus node.
> The master driver chooses how to probe its children. So there is some
> context-sensitivity.

That means it might be possible to implement context-sensitivity. 
However, it does not mean context-sensitivity is or should be implemented.

>> Did the discussion involve the core DT maintainers? If so, whatever
>> they decided can stick. Otherwise, the discussion should be rubn by
>> them.
>
> Yes. I never got an "ack", but Mark Rutland commented a few times and
> didn't seem to object to the name. e.g.:
>
> http://lists.infradead.org/pipermail/linux-mtd/2015-March/058275.html

Nobody pointed out in that thread the "jedec-nor" isn't remotely 
SPI-specific.

  reply	other threads:[~2015-05-08 21:03 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-05-08  6:21 [PATCH] ARM: tegra: add "nor-jedec" flash compatible binding Rafał Miłecki
2015-05-08 16:00 ` Stephen Warren
2015-05-08 18:43   ` Brian Norris
2015-05-08 18:47     ` Brian Norris
2015-05-08 20:01     ` Stephen Warren
2015-05-08 20:15       ` Brian Norris
2015-05-08 21:03         ` Stephen Warren [this message]
2015-05-08 20:57     ` Geert Uytterhoeven
2015-05-08 21:04       ` Stephen Warren
2015-05-08 21:34         ` Brian Norris
2015-05-11 22:46           ` Brian Norris

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=554D24AC.9080404@wwwdotorg.org \
    --to=swarren@wwwdotorg.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).