* [PATCH 1/3] clocksource: exynos_mct: Change exynos4_mct_tick_clear return type to void
@ 2015-04-30 4:42 Krzysztof Kozlowski
2015-04-30 4:42 ` [PATCH 2/3] clocksource: exynos_mct: Staticize struct clocksource Krzysztof Kozlowski
` (2 more replies)
0 siblings, 3 replies; 6+ messages in thread
From: Krzysztof Kozlowski @ 2015-04-30 4:42 UTC (permalink / raw)
To: linux-arm-kernel
Return value of exynos4_mct_tick_clear() was never checked so it can
be safely changed to void.
Signed-off-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
---
drivers/clocksource/exynos_mct.c | 8 ++------
1 file changed, 2 insertions(+), 6 deletions(-)
diff --git a/drivers/clocksource/exynos_mct.c b/drivers/clocksource/exynos_mct.c
index 83564c9cfdbe..87c2e558c465 100644
--- a/drivers/clocksource/exynos_mct.c
+++ b/drivers/clocksource/exynos_mct.c
@@ -413,7 +413,7 @@ static inline void exynos4_tick_set_mode(enum clock_event_mode mode,
}
}
-static int exynos4_mct_tick_clear(struct mct_clock_event_device *mevt)
+static void exynos4_mct_tick_clear(struct mct_clock_event_device *mevt)
{
struct clock_event_device *evt = &mevt->evt;
@@ -426,12 +426,8 @@ static int exynos4_mct_tick_clear(struct mct_clock_event_device *mevt)
exynos4_mct_tick_stop(mevt);
/* Clear the MCT tick interrupt */
- if (readl_relaxed(reg_base + mevt->base + MCT_L_INT_CSTAT_OFFSET) & 1) {
+ if (readl_relaxed(reg_base + mevt->base + MCT_L_INT_CSTAT_OFFSET) & 1)
exynos4_mct_write(0x1, mevt->base + MCT_L_INT_CSTAT_OFFSET);
- return 1;
- } else {
- return 0;
- }
}
static irqreturn_t exynos4_mct_tick_isr(int irq, void *dev_id)
--
1.9.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH 2/3] clocksource: exynos_mct: Staticize struct clocksource
2015-04-30 4:42 [PATCH 1/3] clocksource: exynos_mct: Change exynos4_mct_tick_clear return type to void Krzysztof Kozlowski
@ 2015-04-30 4:42 ` Krzysztof Kozlowski
2015-05-11 14:06 ` Daniel Lezcano
2015-04-30 4:42 ` [PATCH 3/3] clocksource: exynos_mct: Remove old platform mct_init() Krzysztof Kozlowski
2015-05-11 14:05 ` [PATCH 1/3] clocksource: exynos_mct: Change exynos4_mct_tick_clear return type to void Daniel Lezcano
2 siblings, 1 reply; 6+ messages in thread
From: Krzysztof Kozlowski @ 2015-04-30 4:42 UTC (permalink / raw)
To: linux-arm-kernel
The struct clocksource 'mct_frc' is not exported and used outside so
make it static.
Signed-off-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
---
drivers/clocksource/exynos_mct.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/clocksource/exynos_mct.c b/drivers/clocksource/exynos_mct.c
index 87c2e558c465..8b2a9fc66dcc 100644
--- a/drivers/clocksource/exynos_mct.c
+++ b/drivers/clocksource/exynos_mct.c
@@ -209,7 +209,7 @@ static void exynos4_frc_resume(struct clocksource *cs)
exynos4_mct_frc_start();
}
-struct clocksource mct_frc = {
+static struct clocksource mct_frc = {
.name = "mct-frc",
.rating = 400,
.read = exynos4_frc_read,
--
1.9.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH 3/3] clocksource: exynos_mct: Remove old platform mct_init()
2015-04-30 4:42 [PATCH 1/3] clocksource: exynos_mct: Change exynos4_mct_tick_clear return type to void Krzysztof Kozlowski
2015-04-30 4:42 ` [PATCH 2/3] clocksource: exynos_mct: Staticize struct clocksource Krzysztof Kozlowski
@ 2015-04-30 4:42 ` Krzysztof Kozlowski
2015-05-11 14:06 ` Daniel Lezcano
2015-05-11 14:05 ` [PATCH 1/3] clocksource: exynos_mct: Change exynos4_mct_tick_clear return type to void Daniel Lezcano
2 siblings, 1 reply; 6+ messages in thread
From: Krzysztof Kozlowski @ 2015-04-30 4:42 UTC (permalink / raw)
To: linux-arm-kernel
Since commit 228e3023eb04 ("Merge tag 'mct-exynos-for-v3.10' of ...") the
mct_init() was superseded by mct_init_dt() and is not referenced
anywhere. Remove it.
Signed-off-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
---
drivers/clocksource/exynos_mct.c | 12 ------------
1 file changed, 12 deletions(-)
diff --git a/drivers/clocksource/exynos_mct.c b/drivers/clocksource/exynos_mct.c
index 8b2a9fc66dcc..935b05936dbd 100644
--- a/drivers/clocksource/exynos_mct.c
+++ b/drivers/clocksource/exynos_mct.c
@@ -560,18 +560,6 @@ out_irq:
free_percpu_irq(mct_irqs[MCT_L0_IRQ], &percpu_mct_tick);
}
-void __init mct_init(void __iomem *base, int irq_g0, int irq_l0, int irq_l1)
-{
- mct_irqs[MCT_G0_IRQ] = irq_g0;
- mct_irqs[MCT_L0_IRQ] = irq_l0;
- mct_irqs[MCT_L1_IRQ] = irq_l1;
- mct_int_type = MCT_INT_SPI;
-
- exynos4_timer_resources(NULL, base);
- exynos4_clocksource_init();
- exynos4_clockevent_init();
-}
-
static void __init mct_init_dt(struct device_node *np, unsigned int int_type)
{
u32 nr_irqs, i;
--
1.9.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH 1/3] clocksource: exynos_mct: Change exynos4_mct_tick_clear return type to void
2015-04-30 4:42 [PATCH 1/3] clocksource: exynos_mct: Change exynos4_mct_tick_clear return type to void Krzysztof Kozlowski
2015-04-30 4:42 ` [PATCH 2/3] clocksource: exynos_mct: Staticize struct clocksource Krzysztof Kozlowski
2015-04-30 4:42 ` [PATCH 3/3] clocksource: exynos_mct: Remove old platform mct_init() Krzysztof Kozlowski
@ 2015-05-11 14:05 ` Daniel Lezcano
2 siblings, 0 replies; 6+ messages in thread
From: Daniel Lezcano @ 2015-05-11 14:05 UTC (permalink / raw)
To: linux-arm-kernel
On 04/30/2015 06:42 AM, Krzysztof Kozlowski wrote:
> Return value of exynos4_mct_tick_clear() was never checked so it can
> be safely changed to void.
>
> Signed-off-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
Applied to my tree for 4.2
-- Daniel
--
<http://www.linaro.org/> Linaro.org ? Open source software for ARM SoCs
Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH 2/3] clocksource: exynos_mct: Staticize struct clocksource
2015-04-30 4:42 ` [PATCH 2/3] clocksource: exynos_mct: Staticize struct clocksource Krzysztof Kozlowski
@ 2015-05-11 14:06 ` Daniel Lezcano
0 siblings, 0 replies; 6+ messages in thread
From: Daniel Lezcano @ 2015-05-11 14:06 UTC (permalink / raw)
To: linux-arm-kernel
On 04/30/2015 06:42 AM, Krzysztof Kozlowski wrote:
> The struct clocksource 'mct_frc' is not exported and used outside so
> make it static.
>
> Signed-off-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
> ---
Applied to my tree for 4.2
-- Daniel
> drivers/clocksource/exynos_mct.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/clocksource/exynos_mct.c b/drivers/clocksource/exynos_mct.c
> index 87c2e558c465..8b2a9fc66dcc 100644
> --- a/drivers/clocksource/exynos_mct.c
> +++ b/drivers/clocksource/exynos_mct.c
> @@ -209,7 +209,7 @@ static void exynos4_frc_resume(struct clocksource *cs)
> exynos4_mct_frc_start();
> }
>
> -struct clocksource mct_frc = {
> +static struct clocksource mct_frc = {
> .name = "mct-frc",
> .rating = 400,
> .read = exynos4_frc_read,
>
--
<http://www.linaro.org/> Linaro.org ? Open source software for ARM SoCs
Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH 3/3] clocksource: exynos_mct: Remove old platform mct_init()
2015-04-30 4:42 ` [PATCH 3/3] clocksource: exynos_mct: Remove old platform mct_init() Krzysztof Kozlowski
@ 2015-05-11 14:06 ` Daniel Lezcano
0 siblings, 0 replies; 6+ messages in thread
From: Daniel Lezcano @ 2015-05-11 14:06 UTC (permalink / raw)
To: linux-arm-kernel
On 04/30/2015 06:42 AM, Krzysztof Kozlowski wrote:
> Since commit 228e3023eb04 ("Merge tag 'mct-exynos-for-v3.10' of ...") the
> mct_init() was superseded by mct_init_dt() and is not referenced
> anywhere. Remove it.
>
> Signed-off-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
Applied to my tree for 4.2
Thanks !
-- Daniel
--
<http://www.linaro.org/> Linaro.org ? Open source software for ARM SoCs
Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2015-05-11 14:06 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-04-30 4:42 [PATCH 1/3] clocksource: exynos_mct: Change exynos4_mct_tick_clear return type to void Krzysztof Kozlowski
2015-04-30 4:42 ` [PATCH 2/3] clocksource: exynos_mct: Staticize struct clocksource Krzysztof Kozlowski
2015-05-11 14:06 ` Daniel Lezcano
2015-04-30 4:42 ` [PATCH 3/3] clocksource: exynos_mct: Remove old platform mct_init() Krzysztof Kozlowski
2015-05-11 14:06 ` Daniel Lezcano
2015-05-11 14:05 ` [PATCH 1/3] clocksource: exynos_mct: Change exynos4_mct_tick_clear return type to void Daniel Lezcano
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).