From: tremyfr@gmail.com (Philippe Reynes)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] imx27: dt: only map 1 Kbyte for fec registers
Date: Mon, 11 May 2015 23:25:08 +0200 [thread overview]
Message-ID: <55511E34.5040908@gmail.com> (raw)
In-Reply-To: <20150511120101.GA25495@tiger>
Hi Shawn,
On 11/05/15 14:01, Shawn Guo wrote:
> On Sat, May 09, 2015 at 10:54:30PM +0200, Philippe Reynes wrote:
>> According to the imx27 documentation, fec has a 1 Kbyte
>> memory space map, spitted in two regions of 512 bytes.
>> The first one for control/status registers, and the
>> second one for event/statistic registers. So, we don't
>> need to map 16 Kbyte for registers, 1 Kbyte is enough.
>>
>> Signed-off-by: Philippe Reynes<tremyfr@gmail.com>
>> ---
>> arch/arm/boot/dts/imx27.dtsi | 2 +-
>> 1 files changed, 1 insertions(+), 1 deletions(-)
>>
>> diff --git a/arch/arm/boot/dts/imx27.dtsi b/arch/arm/boot/dts/imx27.dtsi
>> index 6951b66..56bb917 100644
>> --- a/arch/arm/boot/dts/imx27.dtsi
>> +++ b/arch/arm/boot/dts/imx27.dtsi
>> @@ -533,7 +533,7 @@
>>
>> fec: ethernet at 1002b000 {
>> compatible = "fsl,imx27-fec";
>> - reg =<0x1002b000 0x4000>;
>> + reg =<0x1002b000 0x400>;
>
> No. Per MCIMX27RM.pdf, Table 2-7. AIPI2 Memory Map, it should be 4KiB.
I agree, this table show that 4KiB is reserved for fec registers.
But, in paragraph 29.6.1, there is :
"The FEC implementation requires a 1-Kbyte memory map space"
So I've thought that 1 Kbye is enough for the register memory space.
I'm pleased to understand that we're both agree that 16 Kbyte is too large.
If you prefer 4 Kbyte, I'll send a v2 of this patch with this value.
> Shawn
Regards,
Philippe
next prev parent reply other threads:[~2015-05-11 21:25 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-09 20:54 [PATCH] imx27: dt: only map 1 Kbyte for fec registers Philippe Reynes
2015-05-11 12:01 ` Shawn Guo
2015-05-11 21:25 ` Philippe Reynes [this message]
2015-05-12 7:01 ` Uwe Kleine-König
2015-05-12 22:21 ` Philippe Reynes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55511E34.5040908@gmail.com \
--to=tremyfr@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).