From: afaerber@suse.de (Andreas Färber)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] Show proper respect for Heinrich Hertz by using the correct unit for frequency
Date: Mon, 11 May 2015 23:39:08 +0200 [thread overview]
Message-ID: <5551217C.9090504@suse.de> (raw)
In-Reply-To: <20150511131952.GD2067@n2100.arm.linux.org.uk>
Am 11.05.2015 um 15:19 schrieb Russell King - ARM Linux:
> The SI unit of frequency is Hertz, named after Heinrich Hertz, and is
> given the symbol "Hz" to denote this. "hz" is not the unit of frequency,
> and is in fact meaningless.
>
> Fix arch/arm to correctly use "Hz", thereby acknowledging Heinrich Hertz
> contribution to the modern world.
>
> Signed-off-by: Russell King <rmk+kernel@arm.linux.org.uk>
Nice. :) Since you're being exact, should it be "Hertz' contribution"?
> diff --git a/arch/arm/boot/dts/omap3-cm-t3517.dts b/arch/arm/boot/dts/omap3-cm-t3517.dts
> index f5b5a1d96cd7..53ae04f9104d 100644
> --- a/arch/arm/boot/dts/omap3-cm-t3517.dts
> +++ b/arch/arm/boot/dts/omap3-cm-t3517.dts
> @@ -66,7 +66,7 @@
>
> otg_drv_vbus: pinmux_otg_drv_vbus {
> pinctrl-single,pins = <
> - OMAP3_CORE1_IOPAD(0x2210, PIN_INPUT_PULLDOWN | MUX_MODE0) /* rmii_50Mhz_clk.usb0_drvvbus */
> + OMAP3_CORE1_IOPAD(0x2210, PIN_INPUT_PULLDOWN | MUX_MODE0) /* rmii_50MHz_clk.usb0_drvvbus */
This one looks like an identifier - did you check where it comes from
and whether it needs to be fixed there as well?
> >;
> };
>
Rest looks good,
Reviewed-by: Andreas F?rber <afaerber@suse.de>
Cheers,
Andreas
--
SUSE Linux GmbH, Maxfeldstr. 5, 90409 N?rnberg, Germany
GF: Felix Imend?rffer, Jane Smithard, Dilip Upmanyu, Graham Norton; HRB
21284 (AG N?rnberg)
next prev parent reply other threads:[~2015-05-11 21:39 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-11 13:19 [PATCH] Show proper respect for Heinrich Hertz by using the correct unit for frequency Russell King - ARM Linux
2015-05-11 19:08 ` Tony Lindgren
2015-05-11 20:18 ` Robert Jarzmik
2015-05-11 21:39 ` Andreas Färber [this message]
2015-05-14 15:20 ` Russell King - ARM Linux
2015-06-23 16:52 ` Pavel Machek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5551217C.9090504@suse.de \
--to=afaerber@suse.de \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).