v2 exynos_defconfig: Enable SENSORS_PWM_FAN, SENSORS_INA2XX, LEDS for OdroidXU3

v2 exynos_defconfig: Enable SENSORS_PWM_FAN, SENSORS_INA2XX, LEDS for OdroidXU3

[Anand Moon]

Enable SENSORS_PWM_FAN, SENSORS_INA2XX, LEDS for OdroidXU3 on exynos_defonfig.

-Anand Moon

[PATCHv2 1/3] ARM: exynos_defconfig: Enable CONFIG_SENSORS_PWM_FAN for odroidxu3 pmw-fan

[Anand Moon]

Enable CONFIG_SENSORS_PWM_FAN on exynos_defconfig to control fan power on Odroidxu3.

Signed-off-by: Anand Moon <linux.amoon@gmail.com>
---
 arch/arm/configs/exynos_defconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/arm/configs/exynos_defconfig b/arch/arm/configs/exynos_defconfig
index d034c96..3c2784f 100644
--- a/arch/arm/configs/exynos_defconfig
+++ b/arch/arm/configs/exynos_defconfig
@@ -101,6 +101,7 @@ CONFIG_CHARGER_MAX77693=y
 CONFIG_CHARGER_TPS65090=y
 CONFIG_HWMON=y
 CONFIG_SENSORS_LM90=y
+CONFIG_SENSORS_PWM_FAN=y
 CONFIG_CPU_FREQ=y
 CONFIG_CPU_THERMAL=y
 CONFIG_THERMAL=y
-- 
1.9.1

[PATCHv2 1/3] ARM: exynos_defconfig: Enable CONFIG_SENSORS_PWM_FAN for odroidxu3 pmw-fan

[Krzysztof Kozlowski]

On 13.05.2015 12:52, Anand Moon wrote:
> Enable CONFIG_SENSORS_PWM_FAN on exynos_defconfig to control fan power on Odroidxu3.

s/Odroidxu3/Odroid XU3/ (or Odroid-XU3, just capitalize the symbol).

Please go back to default length of wrapping commit messages. This one
exceeds it. Default is 75 characters so git log or git show output would
fit in 80 characters terminal.

With these changes you can add my tag:
Reviewed-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>

Best regards,
Krzysztof

> 
> Signed-off-by: Anand Moon <linux.amoon@gmail.com>
> ---
>  arch/arm/configs/exynos_defconfig | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/arch/arm/configs/exynos_defconfig b/arch/arm/configs/exynos_defconfig
> index d034c96..3c2784f 100644
> --- a/arch/arm/configs/exynos_defconfig
> +++ b/arch/arm/configs/exynos_defconfig
> @@ -101,6 +101,7 @@ CONFIG_CHARGER_MAX77693=y
>  CONFIG_CHARGER_TPS65090=y
>  CONFIG_HWMON=y
>  CONFIG_SENSORS_LM90=y
> +CONFIG_SENSORS_PWM_FAN=y
>  CONFIG_CPU_FREQ=y
>  CONFIG_CPU_THERMAL=y
>  CONFIG_THERMAL=y
> 

[PATCHv2 2/3] ARM: exynos_defconfig: Enable CONFIG_SENSORS_INA2XX for odroidxu3.

[Anand Moon]

Odroidxu3 board support power monitor sensor.

Below is the output of boot log.
[    3.241438] ina2xx 0-0040: power monitor ina231 (Rshunt = 10000 uOhm)
[    3.248068] ina2xx 0-0041: power monitor ina231 (Rshunt = 10000 uOhm)
[    3.254724] ina2xx 0-0044: power monitor ina231 (Rshunt = 10000 uOhm)
[    3.261354] ina2xx 0-0045: power monitor ina231 (Rshunt = 10000 uOhm)

ina231-i2c-0-40
Adapter: s3c2410-i2c
in0:          +0.00 V
in1:          +1.01 V
power1:      175.00 mW
curr1:        +0.18 A

ina231-i2c-0-41
Adapter: s3c2410-i2c
in0:          +0.00 V
in1:          +1.21 V
power1:       50.00 mW
curr1:        +0.04 A

ina231-i2c-0-44
Adapter: s3c2410-i2c
in0:          +0.00 V
in1:          +1.02 V
power1:       50.00 mW
curr1:        +0.04 A

ina231-i2c-0-45
Adapter: s3c2410-i2c
in0:          +0.00 V
in1:          +1.04 V
power1:       75.00 mW
curr1:        +0.07 A

Signed-off-by: Anand Moon <linux.amoon@gmail.com>
---
 arch/arm/configs/exynos_defconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/arm/configs/exynos_defconfig b/arch/arm/configs/exynos_defconfig
index 3c2784f..300678a 100644
--- a/arch/arm/configs/exynos_defconfig
+++ b/arch/arm/configs/exynos_defconfig
@@ -102,6 +102,7 @@ CONFIG_CHARGER_TPS65090=y
 CONFIG_HWMON=y
 CONFIG_SENSORS_LM90=y
 CONFIG_SENSORS_PWM_FAN=y
+CONFIG_SENSORS_INA2XX=y
 CONFIG_CPU_FREQ=y
 CONFIG_CPU_THERMAL=y
 CONFIG_THERMAL=y
-- 
1.9.1

[PATCHv2 2/3] ARM: exynos_defconfig: Enable CONFIG_SENSORS_INA2XX for odroidxu3.

[Krzysztof Kozlowski]

On 13.05.2015 12:52, Anand Moon wrote:
> Odroidxu3 board support power monitor sensor.

1. s/Odroidxu3/Odroid XU3/ (or Odroid-XU3, just capitalize the symbol).
2. Remove the trailing stop (dot) from commit title.

With these changes you can add my tag:
Reviewed-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>

Best regards,
Krzysztof

[PATCHv2 3/3] ARM: exynos_defconfig: Enable LEDs for odroidxu3.

[Anand Moon]

Enable CONFIG_LEDS_GPIO, CONFIG_LEDS_TRIGGERS, CONFIG_LEDS_TRIGGER_HEARTBEAT.

Signed-off-by: Anand Moon <linux.amoon@gmail.com>
---
 arch/arm/configs/exynos_defconfig | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/arch/arm/configs/exynos_defconfig b/arch/arm/configs/exynos_defconfig
index 300678a..21411c5 100644
--- a/arch/arm/configs/exynos_defconfig
+++ b/arch/arm/configs/exynos_defconfig
@@ -179,6 +179,9 @@ CONFIG_MMC_SDHCI_S3C_DMA=y
 CONFIG_MMC_DW=y
 CONFIG_MMC_DW_IDMAC=y
 CONFIG_MMC_DW_EXYNOS=y
+CONFIG_LEDS_GPIO=y
+CONFIG_LEDS_TRIGGERS=y
+CONFIG_LEDS_TRIGGER_HEARTBEAT=y
 CONFIG_RTC_CLASS=y
 CONFIG_RTC_DRV_MAX77686=y
 CONFIG_RTC_DRV_MAX77802=y
-- 
1.9.1

[PATCHv2 3/3] ARM: exynos_defconfig: Enable LEDs for odroidxu3.

[Krzysztof Kozlowski]

On 13.05.2015 12:52, Anand Moon wrote:
> Enable CONFIG_LEDS_GPIO, CONFIG_LEDS_TRIGGERS, CONFIG_LEDS_TRIGGER_HEARTBEAT.

1. Remove the trailing stop (dot) from commit title.
2. Please go back to default length of wrapping commit messages. This
one exceeds it. Default is 75 characters so git log or git show output
would fit in 80 characters terminal.
3. It would be nice to see here WHY you are enabling these configs (what
is the benefit). One sentence would be enough.

With these changes you can add my tag:
Reviewed-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>

Best regards,
Krzysztof