linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: k.kozlowski.k@gmail.com (Krzysztof Kozlowski)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v4 02/13] ARM: dts: exynos4: Use labels for overriding nodesin Exynos4210
Date: Wed, 13 May 2015 18:51:26 +0900	[thread overview]
Message-ID: <55531E9E.2030805@gmail.com> (raw)
In-Reply-To: <5553130D.3010909@kernel.org>

W dniu 13.05.2015 o 18:02, Kukjin Kim pisze:
> On 05/11/15 22:42, Krzysztof Kozlowski wrote:
>> Usage of labels instead of full paths reduces possible mistakes when
>> overriding nodes.
>>
> Well, I'm not sure what kind of the possible mistakes you mentioned...?

One can make a mistake in path when overriding. For example we have:
exynos4.dtsi:
/ {
	gic: interrupt-controller at 10490000 {
		...
	};
}

and someone can add in child dtsi (like exynos4210.dtsi):
/ {
	soc {
		interrupt-controller at 10490000 {
			cpu-offset = <0x8000>;
		}
	}
}

or he can make a mistake in address.

As a result the gic node won't be properly overridden.

> 
> I don't think we need to use the label for gic, combiner.

They are overridden by child DTSI. First definition is in exynos4.dtsi
and exynos4210.dtsi adds a cpu-offset.

Best regards,
Krzysztof

  reply	other threads:[~2015-05-13  9:51 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-05-11 13:42 [PATCH v4 00/13] ARM: dts: exynos4: labels for overriding nodes Krzysztof Kozlowski
2015-05-11 13:42 ` [PATCH v4 01/13] ARM: dts: Add labels to Exynos4 nodes Krzysztof Kozlowski
2015-05-13  8:59   ` Kukjin Kim
2015-05-13  9:42     ` Krzysztof Kozłowski
2015-05-11 13:42 ` [PATCH v4 02/13] ARM: dts: exynos4: Use labels for overriding nodes in Exynos4210 Krzysztof Kozlowski
2015-05-13  9:02   ` [PATCH v4 02/13] ARM: dts: exynos4: Use labels for overriding nodesin Exynos4210 Kukjin Kim
2015-05-13  9:51     ` Krzysztof Kozlowski [this message]
2015-05-11 13:42 ` [PATCH v4 03/13] ARM: dts: exynos4: Use labels for overriding nodes in Exynos4210 Origen Krzysztof Kozlowski
2015-05-13  9:11   ` Kukjin Kim
2015-05-13  9:55     ` Krzysztof Kozlowski
2015-05-11 13:42 ` [PATCH v4 04/13] ARM: dts: exynos4: Use labels for overriding nodes in SMDKv310 Krzysztof Kozlowski
2015-05-11 13:42 ` [PATCH v4 05/13] ARM: dts: exynos4: Use labels for overriding nodes in Trats Krzysztof Kozlowski
2015-05-11 13:42 ` [PATCH v4 06/13] ARM: dts: exynos4: Use labels for overriding nodes in Exynos4212 Krzysztof Kozlowski
2015-05-11 13:42 ` [PATCH v4 07/13] ARM: dts: exynos4: Use labels for overriding nodes in Exynos4x12 Krzysztof Kozlowski
2015-05-11 13:42 ` [PATCH v4 08/13] ARM: dts: exynos4: Use labels for overriding nodes in Exynos4412 Krzysztof Kozlowski
2015-05-11 13:42 ` [PATCH v4 09/13] ARM: dts: exynos4: Use labels for overriding nodes in Odroid Krzysztof Kozlowski
2015-05-11 23:51   ` Eduardo Valentin
2015-05-11 13:42 ` [PATCH v4 10/13] ARM: dts: exynos4: Use labels for overriding nodes in SMDK4412 Krzysztof Kozlowski
2015-05-11 13:42 ` [PATCH v4 11/13] ARM: dts: exynos4: Use labels for overriding nodes in Trats2 Krzysztof Kozlowski
2015-05-11 13:42 ` [PATCH v4 12/13] ARM: dts: exynos4: Use labels for overriding nodes in Exynos4412 Origen Krzysztof Kozlowski
2015-05-11 13:42 ` [PATCH v4 13/13] ARM: dts: exynos4: Use labels for overriding nodes in Tiny4412 Krzysztof Kozlowski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=55531E9E.2030805@gmail.com \
    --to=k.kozlowski.k@gmail.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).