linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: zhengxing@rock-chips.com (zhengxing)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/4] ASoC: rockchip: add rockchip machine driver
Date: Thu, 14 May 2015 10:22:18 +0800	[thread overview]
Message-ID: <555406DA.8040709@rock-chips.com> (raw)
In-Reply-To: <CAEUnVG5nkagx7CZC3t=-oOAyXOBaxxVynBxaGMf0NJpfr9ZVbA@mail.gmail.com>

On 2015?05?14? 07:11, Dylan Reid wrote:
> On Wed, May 13, 2015 at 10:21 AM, Dylan Reid<dgreid@chromium.org>  wrote:
>> On Wed, May 13, 2015 at 9:42 AM, Mark Brown<broonie@kernel.org>  wrote:
>>> On Wed, May 13, 2015 at 09:23:01PM +0800, zhengxing wrote:
>>>> On 2015?05?13? 03:22, Mark Brown wrote:
>>>>> Is it not possible to extend simple card to handle your use cases?
>>>>> Given the very generic naming and the fact that things like jack
>>>>> detection and so on should depend on the CODEC and board usually rather
>>>>> than on the SoC it doesn't sound like this is Rockchip specific.
>>>>> This also looks like you're reimplementing some device model enumeration
>>>>> stuff which probably shouldn't be happening but let's understand the
>>>>> problem you're trying to solve here before going too far into the code.
>>>> Because we are trying to bring rt5650 in the project, so we intend to
>>>> describe supported codecs with DTS via only a rockchip machine driver file,
>>>> others remain pre-implement(like max98090 / rt5645 that vendor machine
>>>> driver).
>>> I don't undertand what you're saying here, sorry - why is this not just
>>> a case of writing multiple machine drivers?
>> I don't understand this either.  I'd think the best solution is
>> simple-card, configured through DTS for each device.

Hi Mark, Dylan,
I tried to use simple-card and had some trouble that jack detection. So 
my idea is simply:
                                                   /-- rockchip_max98090 
(to configure max98090, and no need to via DTS)
    rockchip_machine_driver  |-- rockchip_rt5645 (to configure 
rt5650/rt5645, and no need to via DTS)
(supported codecs via DTS)   \-- rockchip_(maybe other codecs)

It is right that it is base on original rockchip_max98090, but the old 
rockchip_max98090 used DTS.

I tried to explain my ideas. Your kind suggestions will be highly 
appreciated.

Thanks.

  reply	other threads:[~2015-05-14  2:22 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-05-12  9:26 [PATCH 0/4] ASoC: rockchip: add rockchip machine driver Xing Zheng
2015-05-12  9:26 ` [PATCH 1/4] " Xing Zheng
2015-05-12 19:22   ` Mark Brown
2015-05-13 13:23     ` zhengxing
2015-05-13 16:42       ` Mark Brown
2015-05-13 17:21         ` Dylan Reid
2015-05-13 23:11           ` Dylan Reid
2015-05-14  2:22             ` zhengxing [this message]
2015-05-15 20:40             ` [alsa-devel] " Lars-Peter Clausen
2015-05-19 11:16               ` Mark Brown
2015-05-19 16:37                 ` Dylan Reid
2015-05-21 11:10                   ` Mark Brown
2015-05-12  9:26 ` [PATCH 2/4] ASoC: rockchip: add rockchip machine driver for max98090 Xing Zheng
2015-05-12 19:26   ` Mark Brown
2015-05-13 13:23     ` zhengxing
2015-05-13 16:47       ` Mark Brown
2015-05-12  9:26 ` [PATCH 3/4] ASoC: rockchip: add rockchip machine driver for rt5650/rt5645 Xing Zheng
2015-05-12 19:30   ` Mark Brown
2015-05-12  9:26 ` [PATCH 4/4] ASoC: rockchip-audio-machine: add rockchip machine driver bindings Xing Zheng

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=555406DA.8040709@rock-chips.com \
    --to=zhengxing@rock-chips.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).