From: sboyd@codeaurora.org (Stephen Boyd)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2] clk: sirf: add CSR atlas7 clk and reset support
Date: Fri, 15 May 2015 09:47:28 -0700 [thread overview]
Message-ID: <55562320.9060402@codeaurora.org> (raw)
In-Reply-To: <CAGsJ_4xJrCX5Bk=Ry1QhDvQO6jM8VhDvCmFG73HqxM6ZiXq0RA@mail.gmail.com>
On 05/15/15 00:39, Barry Song wrote:
>
>>> +static struct atlas7_reset_desc atlas7_reset_unit[] = {
>>> + {"PWM", 0x0244, 0, 0x0320, 0, &leaf0_gate_lock}, /*0-5*/
>> Style nitpick: Please put some space around the braces here.
>>
>>> + {"THCGUM", 0x0244, 3, 0x0320, 1, &leaf0_gate_lock},
>>> + {"CVD", 0x04A0, 0, 0x032C, 0, &leaf1_gate_lock},
>>> + {"TIMER", 0x04A0, 1, 0x032C, 1, &leaf1_gate_lock},
>>> + {"PULSEC", 0x04A0, 2, 0x032C, 2, &leaf1_gate_lock},
>> [...]
>>> +
>
> all other issues have been cleared in v3 i sent minutes ago. for this
> one, where do you want the spaces added?
>
I'd prefer it look like:
{ "THCGUM", 0x0244, ..., &leaf0_gate_lock },
--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project
prev parent reply other threads:[~2015-05-15 16:47 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-12 14:14 [PATCH v2] clk: sirf: add CSR atlas7 clk and reset support Barry Song
2015-05-14 23:41 ` Stephen Boyd
2015-05-15 7:39 ` Barry Song
2015-05-15 16:47 ` Stephen Boyd [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55562320.9060402@codeaurora.org \
--to=sboyd@codeaurora.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).